From: Jakub Kicinski <kuba@kernel.org>
To: Detlev Casanova <detlev.casanova@collabora.com>
Cc: linux-kernel@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
David Wu <david.wu@rock-chips.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com, kernel@collabora.com
Subject: Re: [PATCH v3 3/3] ethernet: stmmac: dwmac-rk: Add GMAC support for RK3576
Date: Tue, 27 Aug 2024 13:35:50 -0700 [thread overview]
Message-ID: <20240827133550.19c9eee4@kernel.org> (raw)
In-Reply-To: <20240823141318.51201-4-detlev.casanova@collabora.com>
On Fri, 23 Aug 2024 10:11:15 -0400 Detlev Casanova wrote:
> +static void rk3576_set_to_rgmii(struct rk_priv_data *bsp_priv,
> + int tx_delay, int rx_delay)
> +{
> + struct device *dev = &bsp_priv->pdev->dev;
> + unsigned int offset_con;
> +
> + if (IS_ERR(bsp_priv->grf) || IS_ERR(bsp_priv->php_grf)) {
> + dev_err(dev, "Missing rockchip,grf or rockchip,php-grf property\n");
> + return;
> + }
Seems like there's plenty of precedent in this file, but seems a little
strange that we just print a message and carry on, without returning an
error.
Would be better to return an error or add some info to the ops
struct, so that the caller can check if the correct (of the two)
regmaps are set
next prev parent reply other threads:[~2024-08-27 20:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 14:11 [PATCH v3 0/3] Add GMAC support for rk3576 Detlev Casanova
2024-08-23 14:11 ` [PATCH v3 1/3] ethernet: stmmac: dwmac-rk: Fix typo for RK3588 code Detlev Casanova
2024-08-23 14:21 ` Heiko Stübner
2024-08-23 14:11 ` [PATCH v3 2/3] dt-bindings: net: Add support for rk3576 dwmac Detlev Casanova
2024-08-23 14:21 ` Heiko Stübner
2024-08-23 14:11 ` [PATCH v3 3/3] ethernet: stmmac: dwmac-rk: Add GMAC support for RK3576 Detlev Casanova
2024-08-27 20:35 ` Jakub Kicinski [this message]
2024-08-27 20:40 ` [PATCH v3 0/3] Add GMAC support for rk3576 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827133550.19c9eee4@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=david.wu@rock-chips.com \
--cc=detlev.casanova@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=heiko@sntech.de \
--cc=joabreu@synopsys.com \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).