From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 4/6] media: rcar-isp: Add family compatible for R-Car Gen4 family
Date: Wed, 28 Aug 2024 01:00:28 +0300 [thread overview]
Message-ID: <20240827220028.GD30398@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20240826144352.3026980-5-niklas.soderlund+renesas@ragnatech.se>
Hi Niklas,
Thank you for the patch.
On Mon, Aug 26, 2024 at 04:43:50PM +0200, Niklas Söderlund wrote:
> Add the Gen4 family compatible. This will be used instead of a SoC
> specific compatible for the new Gen4 SoC V4M. Two Gen4 boards (V3U and
> V4H) have already been added prior and their bindings need to be kept
> for backward compatibility.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Assuming 1/6 gets accepted,
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> * Changes since v1
> - Reworked to add a family compatible instead of V4M specific one.
> ---
> drivers/media/platform/renesas/rcar-isp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/platform/renesas/rcar-isp.c b/drivers/media/platform/renesas/rcar-isp.c
> index 4512ac338ca5..6504c7025a40 100644
> --- a/drivers/media/platform/renesas/rcar-isp.c
> +++ b/drivers/media/platform/renesas/rcar-isp.c
> @@ -429,8 +429,11 @@ static int risp_probe_resources(struct rcar_isp *isp,
> }
>
> static const struct of_device_id risp_of_id_table[] = {
> + /* Keep to be compatible with old DTS files. */
> { .compatible = "renesas,r8a779a0-isp" },
> + /* Keep to be compatible with old DTS files. */
> { .compatible = "renesas,r8a779g0-isp" },
> + { .compatible = "renesas,rcar-gen4-isp" },
> { /* sentinel */ },
> };
> MODULE_DEVICE_TABLE(of, risp_of_id_table);
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2024-08-27 22:00 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 14:43 [PATCH v2 0/6] rcar-isp: Add support for R-Car V4M Niklas Söderlund
2024-08-26 14:43 ` [PATCH v2 1/6] dt-bindings: media: renesas,isp: Add Gen4 family fallback Niklas Söderlund
2024-08-27 6:31 ` Krzysztof Kozlowski
2024-08-27 8:12 ` Niklas Söderlund
2024-08-27 21:34 ` Laurent Pinchart
2024-08-28 5:36 ` Krzysztof Kozlowski
2024-08-28 10:50 ` Laurent Pinchart
2024-08-28 11:06 ` Krzysztof Kozlowski
2024-08-28 15:05 ` Rob Herring
2024-08-28 14:46 ` Rob Herring
2024-08-28 15:15 ` Conor Dooley
2024-08-29 8:17 ` Geert Uytterhoeven
2024-08-28 11:09 ` Krzysztof Kozlowski
2024-08-28 7:31 ` Geert Uytterhoeven
2024-08-26 14:43 ` [PATCH v2 2/6] arm64: dts: renesas: r8a779g0: Add family fallback for CSISP IP Niklas Söderlund
2024-08-27 21:37 ` Laurent Pinchart
2024-08-28 7:32 ` Geert Uytterhoeven
2024-08-26 14:43 ` [PATCH v2 3/6] arm64: dts: renesas: r8a779a0: " Niklas Söderlund
2024-08-27 21:58 ` Laurent Pinchart
2024-08-28 7:33 ` Geert Uytterhoeven
2024-08-26 14:43 ` [PATCH v2 4/6] media: rcar-isp: Add family compatible for R-Car Gen4 family Niklas Söderlund
2024-08-26 14:48 ` Biju Das
2024-08-27 8:13 ` Niklas Söderlund
2024-08-27 11:32 ` Biju Das
2024-08-27 22:00 ` Laurent Pinchart [this message]
2024-08-28 7:34 ` Geert Uytterhoeven
2024-08-26 14:43 ` [PATCH v2 5/6] dt-bindings: media: renesas,isp: Add binding for V4M Niklas Söderlund
2024-08-27 22:01 ` Laurent Pinchart
2024-08-28 7:39 ` Geert Uytterhoeven
2024-09-22 21:06 ` Krzysztof Kozlowski
2024-08-26 14:43 ` [PATCH v2 6/6] arm64: dts: renesas: r8a779h0: Add family fallback for CSISP IP Niklas Söderlund
2024-08-27 22:01 ` Laurent Pinchart
2024-08-28 7:40 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827220028.GD30398@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).