From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 6/6] arm64: dts: renesas: r8a779h0: Add family fallback for CSISP IP
Date: Wed, 28 Aug 2024 01:01:59 +0300 [thread overview]
Message-ID: <20240827220159.GF30398@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20240826144352.3026980-7-niklas.soderlund+renesas@ragnatech.se>
Hi Niklas,
Thank you for the patch.
On Mon, Aug 26, 2024 at 04:43:52PM +0200, Niklas Söderlund wrote:
> The usage of the V4M CSISP bindings where merged before the bindings
> where approved. At that time the family fallback compatible where not
> part of the bindings, add them.
>
> Fixes: 2bb78d9fb7c9 ("arm64: dts: renesas: r8a779h0: Add video capture nodes")
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> * Changes since v1
> - New in v2.
> ---
> arch/arm64/boot/dts/renesas/r8a779h0.dtsi | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a779h0.dtsi b/arch/arm64/boot/dts/renesas/r8a779h0.dtsi
> index 28ca59e735e5..12d8be3fd579 100644
> --- a/arch/arm64/boot/dts/renesas/r8a779h0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779h0.dtsi
> @@ -1829,7 +1829,8 @@ csi41isp1: endpoint {
> };
>
> isp0: isp@fed00000 {
> - compatible = "renesas,r8a779h0-isp";
> + compatible = "renesas,r8a779h0-isp",
> + "renesas,rcar-gen4-isp";
> reg = <0 0xfed00000 0 0x10000>;
> interrupts = <GIC_SPI 473 IRQ_TYPE_LEVEL_LOW>;
> clocks = <&cpg CPG_MOD 612>;
> @@ -1912,7 +1913,8 @@ isp0vin07: endpoint {
> };
>
> isp1: isp@fed20000 {
> - compatible = "renesas,r8a779h0-isp";
> + compatible = "renesas,r8a779h0-isp",
> + "renesas,rcar-gen4-isp";
> reg = <0 0xfed20000 0 0x10000>;
> interrupts = <GIC_SPI 474 IRQ_TYPE_LEVEL_LOW>;
> clocks = <&cpg CPG_MOD 613>;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2024-08-27 22:02 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 14:43 [PATCH v2 0/6] rcar-isp: Add support for R-Car V4M Niklas Söderlund
2024-08-26 14:43 ` [PATCH v2 1/6] dt-bindings: media: renesas,isp: Add Gen4 family fallback Niklas Söderlund
2024-08-27 6:31 ` Krzysztof Kozlowski
2024-08-27 8:12 ` Niklas Söderlund
2024-08-27 21:34 ` Laurent Pinchart
2024-08-28 5:36 ` Krzysztof Kozlowski
2024-08-28 10:50 ` Laurent Pinchart
2024-08-28 11:06 ` Krzysztof Kozlowski
2024-08-28 15:05 ` Rob Herring
2024-08-28 14:46 ` Rob Herring
2024-08-28 15:15 ` Conor Dooley
2024-08-29 8:17 ` Geert Uytterhoeven
2024-08-28 11:09 ` Krzysztof Kozlowski
2024-08-28 7:31 ` Geert Uytterhoeven
2024-08-26 14:43 ` [PATCH v2 2/6] arm64: dts: renesas: r8a779g0: Add family fallback for CSISP IP Niklas Söderlund
2024-08-27 21:37 ` Laurent Pinchart
2024-08-28 7:32 ` Geert Uytterhoeven
2024-08-26 14:43 ` [PATCH v2 3/6] arm64: dts: renesas: r8a779a0: " Niklas Söderlund
2024-08-27 21:58 ` Laurent Pinchart
2024-08-28 7:33 ` Geert Uytterhoeven
2024-08-26 14:43 ` [PATCH v2 4/6] media: rcar-isp: Add family compatible for R-Car Gen4 family Niklas Söderlund
2024-08-26 14:48 ` Biju Das
2024-08-27 8:13 ` Niklas Söderlund
2024-08-27 11:32 ` Biju Das
2024-08-27 22:00 ` Laurent Pinchart
2024-08-28 7:34 ` Geert Uytterhoeven
2024-08-26 14:43 ` [PATCH v2 5/6] dt-bindings: media: renesas,isp: Add binding for V4M Niklas Söderlund
2024-08-27 22:01 ` Laurent Pinchart
2024-08-28 7:39 ` Geert Uytterhoeven
2024-09-22 21:06 ` Krzysztof Kozlowski
2024-08-26 14:43 ` [PATCH v2 6/6] arm64: dts: renesas: r8a779h0: Add family fallback for CSISP IP Niklas Söderlund
2024-08-27 22:01 ` Laurent Pinchart [this message]
2024-08-28 7:40 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827220159.GF30398@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).