From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D559EEC9; Fri, 30 Aug 2024 15:47:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725032842; cv=none; b=f0M81GJp5xfiNlPcuKvtkIobRrLXnURFCxxggsrz2mDcE8wZytmbxHilaQFNPSrQoxLykGzkfgVw5hYMsBbrzN5Ui0hoeIphzO1iptApbX8Sc0EMhqanm2BnXFeYy7qplQWJHbtIBu+rEbrBAkYFrFeSAA1WUMakvdO60imiWkY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725032842; c=relaxed/simple; bh=kVHG/ikzROeUrI8TkIhYUFF1lltgE9xiBdJrX5pyrqo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GCRy9jkhxbKhyk0Jo9xc8vS1QXJmcCOtiTgNCXzAsOLktkyCx6XZYAkC/AqVRALdz21Fy9GFW6OymwqiCovHjpjAD7KHpBIGJ2Q6dXzw1/u+q6D6Dn1HPA7STBw6Y3uK6Ils3dwbj1XFsN/Vqke8zzCZ2WOnmaJr2adif2Nf2Uo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=U/0xvgtj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U/0xvgtj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6FE5C4CEC2; Fri, 30 Aug 2024 15:47:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725032842; bh=kVHG/ikzROeUrI8TkIhYUFF1lltgE9xiBdJrX5pyrqo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U/0xvgtjfTOjVUMrXzxy5584S9c1FzUcDNNifVsobkVn/s380gG5WIvAnEw0P4pAh WfVtqsAKvS9AG8YqUe4+0tyX61k1dd9+oP3oMH/srech142FBW+g+twqx81ZuW9NKE fSpTiX2JU0MUz4P9eGiziQ9n4+h7XRiabQ5YZxqaDr11mx17IPqfAVRxH4OBYr9WSn cTZc5yk9yBRJaygmNSAvGqfItA2n8+zrqfHRM+f0CpA31dZVl1g6MCgEFMENVocrWn nMGqOdHD7+Sulo77E6BHpafwYDVW+irukrZBs0amzmgG1DuHbfa6tpGXpWOOu5RtfO 5Bnop4slPp3zw== Date: Fri, 30 Aug 2024 10:47:19 -0500 From: Rob Herring To: Geert Uytterhoeven Cc: Krzysztof Kozlowski , Krzysztof Kozlowski , Conor Dooley , Magnus Damm , Srinivas Kandagatla , Yoshihiro Shimoda , Arnd Bergmann , devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/7] dt-bindings: fuse: Move renesas,rcar-{efuse,otp} to nvmem Message-ID: <20240830154719.GA45646-robh@kernel.org> References: <1a3d4ff8ce34a5e676d1cb1fafd40525378e29a4.1721999833.git.geert+renesas@glider.be> <20240730162435.GA1480758-robh@kernel.org> <67hcoj3haiptjh4f7qvaz4xwcdamr3x33xxrxusuwq2t3veiln@z2ggc7razty4> <20240829135845.GA297607-robh@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Aug 29, 2024 at 04:34:41PM +0200, Geert Uytterhoeven wrote: > Hi Rob, > > On Thu, Aug 29, 2024 at 3:58 PM Rob Herring wrote: > > On Thu, Aug 29, 2024 at 11:10:41AM +0200, Geert Uytterhoeven wrote: > > > On Thu, Aug 29, 2024 at 10:55 AM Krzysztof Kozlowski wrote: > > > > On 28/08/2024 22:10, Geert Uytterhoeven wrote: > > > > > On Mon, Aug 19, 2024 at 1:11 PM Krzysztof Kozlowski wrote: > > > > >> On Wed, Jul 31, 2024 at 09:37:36AM +0200, Geert Uytterhoeven wrote: > > > > >>> On Tue, Jul 30, 2024 at 6:24 PM Rob Herring wrote: > > > > >>>> On Fri, Jul 26, 2024 at 03:38:06PM +0200, Geert Uytterhoeven wrote: > > > > >>>>> The R-Car E-FUSE blocks can be modelled better using the nvmem > > > > >>>>> framework. > > > > >>>>> > > > > >>>>> Replace the R-Car V3U example by an R-Car S4-8 ES1.2 example, to show > > > > >>>>> the definition of nvmem cells. While at it, drop unneeded labels from > > > > >>>>> the examples, and fix indentation. > > > > >>>>> > > > > >>>>> Add an entry to the MAINTAINERS file. > > > > >>>>> > > > > >>>>> Reported-by: Arnd Bergmann > > > > >>>>> Signed-off-by: Geert Uytterhoeven > > > > >>>>> --- > > > > >>>>> v3: > > > > >>>>> - New. > > > > >>>>> > > > > >>>>> I would expect that the calib@144 node needs: > > > > >>>>> > > > > >>>>> #nvmem-cell-cells = <0>; > > > > > > > > So this is for mac-base... > > > > > > No, mac-base is not involved. > > > > It is because that's the only case that allows #nvmem-cell-cells in > > fixed-cell.yaml. While fixed-cell.yaml allows additional properties, > > where it is referenced in fixed-layout.yaml does not. > > So all of this is normal, and you should just never use #nvmem-cell-cells, > except in a node describing the location of the MAC address? I was just explaining the source. If you have another use, then adjust the schema. > When no #nvmem-cell-cells property is present, > of_parse_phandle_with_optional_args() (as used in > of_nvmem_cell_get()) returns zero anyway Yeah, I don't see much value in disallowing #nvmem-cell-cells. Rob