From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9613D81AB4; Wed, 4 Sep 2024 08:39:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725439169; cv=none; b=r9W3K7qwZJuS2tagDdpTumQSMrlq28fA1CML1xG0CMRMvIeLqRyjsj1x8FdI/ZZolVJE9ID1Uo7R9AY6JtsceRgjLgNPd3hXcOVMr3Ot6tcxhrLRId1Y4l5ilo35pkD4Kml/0UVOukRNZytfwqCfNNo6rPq4sFVsGkwc27EyIvU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725439169; c=relaxed/simple; bh=jHtf8/HDMOU4CTQWvdR71mhZAyAdMJZ5rhR63YWQMEs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QQKbYNlteT3KJbFa6NtJ6z0MI1LPsqTjbTxv8gxntp2cbzjt7ErHiXw1VZTQCUp1XrPndsH5f9SXIyxqKW6FAa6MK2XwLiAdxBffnNI3tlyKCHo8GlVCpsg9ShnC5XxVfiuyFHdymt/AbMMqRapxrbY5ab4QxYYX+z9Jrg+Svig= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org; spf=pass smtp.mailfrom=gentoo.org; arc=none smtp.client-ip=140.211.166.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gentoo.org Date: Wed, 4 Sep 2024 08:39:21 +0000 From: Yixun Lan To: Krzysztof Kozlowski Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yangyu Chen , Jisheng Zhang , Inochi Amaoto , Icenowy Zheng , Meng Zhang , Meng Zhang , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH 1/3] dt-bindings: gpio: spacemit: add support for K1 SoC Message-ID: <20240904083921-GYB107481@gentoo> References: <20240904-03-k1-gpio-v1-0-6072ebeecae0@gentoo.org> <20240904-03-k1-gpio-v1-1-6072ebeecae0@gentoo.org> <20240904070520-GYA107481@gentoo> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 09:42 Wed 04 Sep , Krzysztof Kozlowski wrote: > On 04/09/2024 09:05, Yixun Lan wrote: > > Hi Krzysztof > > >>> + "#interrupt-cells": > >>> + const: 2 > >>> + description: | > >>> + The first cell is the GPIO number, the second should specify > >>> + flags. The following subset of flags is supported: > >>> + - bits[3:0] trigger type flags (no level trigger type support) > >>> + 1 = low-to-high edge triggered > >>> + 2 = high-to-low edge triggered > >>> + Valid combinations are 1, 2, 3 > >> > >> Hm? No, you must use standard interrupt flags, not custom ones. > >> > > It should be same as standard flags, my intention here was try to say > > the controller support edge trigger only, but no level trigger flags (4, 8) > > should I just replace number to macro, and put it like this: > > Then just say that level interrupts are not supported. Do not refer to Ok, got > some bits (bits of what?). > the flags IRQ_TYPE_LEVEL_HIGH=4, IRQ_TYPE_LEVEL_LOW=4 -- Yixun Lan (dlan) Gentoo Linux Developer GPG Key ID AABEFD55