Re: [PATCH 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568

Junhao Xie
2024-09-05T05:46:17Z

On 2024/9/5 01:25, Andrew Lunn wrote:
>> +&gmac1 {
>> + assigned-clocks = <&cru SCLK_GMAC1_RX_TX>, <&cru SCLK_GMAC1>;
>> + assigned-clock-parents = <&cru SCLK_GMAC1_RGMII_SPEED>;
>> + assigned-clock-rates = <0>, <125000000>;
>> + clock_in_out = "output";
>> + phy-handle = <&rgmii_phy1>;
>> + phy-mode = "rgmii";
>> + phy-supply = <&vcc_3v3>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&gmac1m1_miim
>> + &gmac1m1_tx_bus2
>> + &gmac1m1_rx_bus2
>> + &gmac1m1_rgmii_clk
>> + &gmac1m1_rgmii_bus>;
>> + snps,reset-gpio = <&gpio4 RK_PC0 GPIO_ACTIVE_LOW>;
>> + snps,reset-active-low;
>> + snps,reset-delays-us = <0 20000 100000>;
>> + tx_delay = <0x38>;
>> + rx_delay = <0x15>;
>> + status = "okay";
>
> This has been discussed a few times. You should be using phy-mode
> rgmii-id.
>
> arch/arm/boot/dts/rockchip/rk3288-phycore-som.dtsi is i think also a
> YT8521SC.
>
> Andrew

Thanks, I changed phy-mode to rgmii-id and it seems to work fine.

Best regards,
Junhao