From: Rob Herring <robh@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Mark Brown <broonie@kernel.org>,
Saravana Kannan <saravanak@google.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: renesas,rsnd: add post-init-providers property
Date: Wed, 4 Sep 2024 10:07:20 -0500 [thread overview]
Message-ID: <20240904150720.GA2578755-robh@kernel.org> (raw)
In-Reply-To: <87cylj7ul2.wl-kuninori.morimoto.gx@renesas.com>
On Wed, Sep 04, 2024 at 07:21:14AM +0000, Kuninori Morimoto wrote:
> sometimes, fwnode dependency cycles can be broken, and in such case,
> rsnd driver will never be probed. To avoid such case, we would like to
> use post-init-providers to avoid it.
> Enable post-init-providers property on rsnd.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> index 07ec6247d9def..cb44478d9e420 100644
> --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> @@ -112,6 +112,10 @@ properties:
> description: List of necessary clock names.
> # details are defined below
>
> + post-init-providers:
> + description: ignore fw_devlink dependency cycles and avoid driver probe dead-lock
Drop. Don't need to describe (again) what a common property is. If you
want to say what your dependency cycle is, that would be good.
> + $ref: /schemas/types.yaml#/definitions/phandle-array
Already has a type, don't define one again.
What you need, if you know, is how many entries (maxItems).
Rob
next prev parent reply other threads:[~2024-09-04 15:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 7:21 [PATCH] ASoC: dt-bindings: renesas,rsnd: add post-init-providers property Kuninori Morimoto
2024-09-04 15:07 ` Rob Herring [this message]
2024-09-04 19:25 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904150720.GA2578755-robh@kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).