From: Chukun Pan <amadeus@jmu.edu.cn>
To: bigfoot@classfun.cn
Cc: amadeus@jmu.edu.cn, conor+dt@kernel.org,
devicetree@vger.kernel.org, dsimic@manjaro.org, heiko@sntech.de,
jonas@kwiboo.se, krzk+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568
Date: Thu, 5 Sep 2024 18:01:00 +0800 [thread overview]
Message-ID: <20240905100100.348444-1-amadeus@jmu.edu.cn> (raw)
In-Reply-To: <010a9c5e-205b-40b9-9655-9e168b2def97@classfun.cn>
Hi Junhao,
>>> + vcc5v0_usb_modem: regulator-5v0-vcc-usb-modem {
>>
>> Are you sure this regulator is 5v?
>>
>
> It should actually be 3.3V, I will fix it and rename
> to vcc3v3_usb_modem
I prefer vcc3v3_rf or vcc3v3_ngff,
this is closer to the schematics.
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pcie30x2m1_pins>;
>>
>> These are actually pcie30x1m0_pins.
>
> pcie30x1m0_pins seems to conflict with sdmmc0,
> I changed it to pcie30x1m1_pins
This is obviously incorrect. I didn't notice that
your pinctrl for sdmmc0 is wrong.
(Because the cd pin are different)
The sdmmc0 node should be like this:
&sdmmc0 {
bus-width = <4>;
cap-sd-highspeed;
cd-gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_LOW>;
disable-wp;
no-1-8-v;
pinctrl-names = "default";
pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd>;
vmmc-supply = <&vcc3v3_sd>;
vqmmc-supply = <&vcc_3v3>;
status = "okay";
};
--
2.25.1
next prev parent reply other threads:[~2024-09-05 10:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 11:14 [PATCH 0/3] Add support for Ariaboard Photonicat RK3568 Junhao Xie
2024-09-04 11:14 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add Shanghai Novotech Ariaboard Junhao Xie
2024-09-04 11:35 ` Krzysztof Kozlowski
2024-09-04 12:14 ` Junhao Xie
2024-09-04 13:29 ` Krzysztof Kozlowski
2024-09-05 5:22 ` Junhao Xie
2024-09-04 11:14 ` [PATCH 2/3] dt-bindings: arm: rockchip: Add Ariaboard Photonicat RK3568 Junhao Xie
2024-09-04 11:36 ` Krzysztof Kozlowski
2024-09-04 11:14 ` [PATCH 3/3] arm64: dts: rockchip: add dts for " Junhao Xie
2024-09-04 17:25 ` Andrew Lunn
2024-09-05 5:47 ` Junhao Xie
2024-09-05 11:17 ` Junhao Xie
2024-09-05 12:53 ` Andrew Lunn
2024-09-05 18:01 ` Junhao Xie
2024-09-05 18:20 ` Andrew Lunn
2024-09-06 3:50 ` Chukun Pan
2024-09-06 4:13 ` Junhao Xie
2024-09-05 3:40 ` Chukun Pan
2024-09-05 9:17 ` Junhao Xie
2024-09-05 10:01 ` Chukun Pan [this message]
2024-09-05 11:06 ` Junhao Xie
2024-09-04 13:36 ` [PATCH 0/3] Add support " Rob Herring (Arm)
2024-09-05 5:37 ` Junhao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240905100100.348444-1-amadeus@jmu.edu.cn \
--to=amadeus@jmu.edu.cn \
--cc=bigfoot@classfun.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox