Re: [PATCH v15 30/32] ARM: dts: aspeed: yosemite4: add SQ52205 support

Krzysztof Kozlowski
2024-09-06T09:28:58Z

On 06/09/2024 08:26, Delphine CC Chiu wrote:
> Add SQ52205 in yosemite4 DTS.

No, that's not what your commit is doing.

>
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
> ---
> .../boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> index d056f6d5ff6e..04aa428f94b7 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> @@ -1245,35 +1245,35 @@ adc@37 {
> };
>
> power-sensor@40 {
> - compatible = "ti,ina233", "richtek,rtq6056";
> + compatible = "ti,ina233", "richtek,rtq6056", "silergy,sq52205";

Why are you changing same line multiple times? It does not make any sense.

Best regards,
Krzysztof