From: kernel test robot <lkp@intel.com>
To: Binbin Zhou <zhoubinbin@loongson.cn>,
Binbin Zhou <zhoubb.aaron@gmail.com>,
Huacai Chen <chenhuacai@loongson.cn>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: oe-kbuild-all@lists.linux.dev, devicetree@vger.kernel.org,
linux-sound@vger.kernel.org, Xuerui Wang <kernel@xen0n.name>,
loongarch@lists.linux.dev
Subject: Re: [PATCH v1 04/10] ASoC: codecs: Add uda1342 codec driver
Date: Fri, 6 Sep 2024 10:10:47 +0800 [thread overview]
Message-ID: <202409060936.0UeDj3S7-lkp@intel.com> (raw)
In-Reply-To: <3fd0c3a04f5f3bd293168732db457f6854db706e.1725518229.git.zhoubinbin@loongson.cn>
Hi Binbin,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 097a44db5747403b19d05a9664e8ec6adba27e3b]
url: https://github.com/intel-lab-lkp/linux/commits/Binbin-Zhou/ASoC-dt-bindings-Add-Everest-ES8323-Codec/20240905-150958
base: 097a44db5747403b19d05a9664e8ec6adba27e3b
patch link: https://lore.kernel.org/r/3fd0c3a04f5f3bd293168732db457f6854db706e.1725518229.git.zhoubinbin%40loongson.cn
patch subject: [PATCH v1 04/10] ASoC: codecs: Add uda1342 codec driver
config: parisc-randconfig-r071-20240906 (https://download.01.org/0day-ci/archive/20240906/202409060936.0UeDj3S7-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240906/202409060936.0UeDj3S7-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409060936.0UeDj3S7-lkp@intel.com/
All warnings (new ones prefixed by >>):
sound/soc/codecs/uda1342.c: In function 'uda1342_i2c_probe':
>> sound/soc/codecs/uda1342.c:331:13: warning: unused variable 'ret' [-Wunused-variable]
331 | int ret;
| ^~~
sound/soc/codecs/uda1342.c: At top level:
>> sound/soc/codecs/uda1342.c:358:12: warning: 'uda1342_resume' defined but not used [-Wunused-function]
358 | static int uda1342_resume(struct device *dev)
| ^~~~~~~~~~~~~~
>> sound/soc/codecs/uda1342.c:349:12: warning: 'uda1342_suspend' defined but not used [-Wunused-function]
349 | static int uda1342_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~
>> sound/soc/codecs/uda1342.c:232:30: warning: 'uda1342_mixer_enum' defined but not used [-Wunused-const-variable=]
232 | static const struct soc_enum uda1342_mixer_enum[] = {
| ^~~~~~~~~~~~~~~~~~
vim +/ret +331 sound/soc/codecs/uda1342.c
231
> 232 static const struct soc_enum uda1342_mixer_enum[] = {
233 SOC_ENUM_SINGLE(0x10, 3, 0x04, uda1342_deemph),
234 SOC_ENUM_SINGLE(0x10, 0, 0x04, uda1342_mixmode),
235 };
236
237 static const struct snd_kcontrol_new uda1342_snd_controls[] = {
238 SOC_SINGLE("Master Playback Volume", 0x11, 0, 0x3F, 1),
239 SOC_SINGLE("Analog1 Volume", 0x12, 0, 0x1F, 1),
240 };
241
242 /* Common DAPM widgets */
243 static const struct snd_soc_dapm_widget uda1342_dapm_widgets[] = {
244 SND_SOC_DAPM_INPUT("VINL1"),
245 SND_SOC_DAPM_INPUT("VINR1"),
246 SND_SOC_DAPM_INPUT("VINL2"),
247 SND_SOC_DAPM_INPUT("VINR2"),
248
249 SND_SOC_DAPM_DAC("DAC", "Playback", 0, 1, 0),
250 SND_SOC_DAPM_ADC("ADC", "Capture", 0, 9, 0),
251
252 SND_SOC_DAPM_OUTPUT("VOUTL"),
253 SND_SOC_DAPM_OUTPUT("VOUTR"),
254 };
255
256 static const struct snd_soc_dapm_route uda1342_dapm_routes[] = {
257 { "ADC", NULL, "VINL1" },
258 { "ADC", NULL, "VINR1" },
259 { "ADC", NULL, "VINL2" },
260 { "ADC", NULL, "VINR2" },
261 { "VOUTL", NULL, "DAC" },
262 { "VOUTR", NULL, "DAC" },
263 };
264
265 static const struct snd_soc_dai_ops uda1342_dai_ops = {
266 .startup = uda1342_startup,
267 .shutdown = uda1342_shutdown,
268 .hw_params = uda1342_hw_params,
269 .mute_stream = uda1342_mute,
270 .set_sysclk = uda1342_set_dai_sysclk,
271 .set_fmt = uda1342_set_dai_fmt,
272 };
273
274 static struct snd_soc_dai_driver uda1342_dai = {
275 .name = "uda1342-hifi",
276 /* playback capabilities */
277 .playback = {
278 .stream_name = "Playback",
279 .channels_min = 1,
280 .channels_max = 2,
281 .rates = SNDRV_PCM_RATE_8000_48000,
282 .formats = UDA134X_FORMATS,
283 },
284 /* capture capabilities */
285 .capture = {
286 .stream_name = "Capture",
287 .channels_min = 1,
288 .channels_max = 2,
289 .rates = SNDRV_PCM_RATE_8000_48000,
290 .formats = UDA134X_FORMATS,
291 },
292 /* pcm operations */
293 .ops = &uda1342_dai_ops,
294 };
295
296 static int uda1342_soc_probe(struct snd_soc_component *component)
297 {
298 struct snd_soc_dapm_context *dapm = snd_soc_component_get_dapm(component);
299
300 snd_soc_add_component_controls(component, uda1342_snd_controls,
301 ARRAY_SIZE(uda1342_snd_controls));
302 snd_soc_dapm_new_controls(dapm, uda1342_dapm_widgets,
303 ARRAY_SIZE(uda1342_dapm_widgets));
304 snd_soc_dapm_add_routes(dapm, uda1342_dapm_routes,
305 ARRAY_SIZE(uda1342_dapm_routes));
306
307 return 0;
308 }
309
310 static const struct snd_soc_component_driver soc_component_dev_uda1342 = {
311 .probe = uda1342_soc_probe,
312 .set_bias_level = uda1342_set_bias_level,
313 .suspend_bias_off = 1,
314 .idle_bias_on = 1,
315 .use_pmdown_time = 1,
316 .endianness = 1,
317 };
318
319 static const struct regmap_config uda1342_regmap = {
320 .reg_bits = 8,
321 .val_bits = 16,
322 .max_register = 0x21,
323 .reg_defaults = uda1342_reg_defaults,
324 .num_reg_defaults = ARRAY_SIZE(uda1342_reg_defaults),
325 .cache_type = REGCACHE_RBTREE,
326 };
327
328 static int uda1342_i2c_probe(struct i2c_client *i2c)
329 {
330 struct uda1342_priv *uda1342;
> 331 int ret;
332
333 uda1342 = devm_kzalloc(&i2c->dev, sizeof(*uda1342), GFP_KERNEL);
334 if (!uda1342)
335 return -ENOMEM;
336
337 uda1342->regmap = devm_regmap_init_i2c(i2c, &uda1342_regmap);
338 if (IS_ERR(uda1342->regmap))
339 return PTR_ERR(uda1342->regmap);
340
341 i2c_set_clientdata(i2c, uda1342);
342 uda1342->i2c = i2c;
343
344 return devm_snd_soc_register_component(&i2c->dev,
345 &soc_component_dev_uda1342,
346 &uda1342_dai, 1);
347 }
348
> 349 static int uda1342_suspend(struct device *dev)
350 {
351 struct uda1342_priv *uda1342 = dev_get_drvdata(dev);
352
353 regcache_cache_only(uda1342->regmap, true);
354
355 return 0;
356 }
357
> 358 static int uda1342_resume(struct device *dev)
359 {
360 struct uda1342_priv *uda1342 = dev_get_drvdata(dev);
361
362 regcache_mark_dirty(uda1342->regmap);
363 regcache_sync(uda1342->regmap);
364
365 return 0;
366 }
367
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-09-06 2:10 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 7:02 [PATCH v1 00/10] ASoC: Some issues about loongson i2s Binbin Zhou
2024-09-05 7:02 ` [PATCH v1 01/10] ASoC: dt-bindings: Add Everest ES8323 Codec Binbin Zhou
2024-09-06 10:21 ` Krzysztof Kozlowski
2024-09-09 8:12 ` Binbin Zhou
2024-09-05 7:02 ` [PATCH v1 02/10] ASoC: codecs: Add support for ES8323 Binbin Zhou
2024-09-05 14:05 ` Mark Brown
2024-09-13 2:02 ` Binbin Zhou
2024-09-13 16:44 ` Mark Brown
2024-09-18 9:24 ` Binbin Zhou
2024-09-18 11:15 ` Mark Brown
2024-09-05 20:31 ` kernel test robot
2024-09-05 7:02 ` [PATCH v1 03/10] ASoC: dt-bindings: Add NXP uda1342 Codec Binbin Zhou
2024-09-06 10:22 ` Krzysztof Kozlowski
2024-09-05 7:02 ` [PATCH v1 04/10] ASoC: codecs: Add uda1342 codec driver Binbin Zhou
2024-09-05 14:28 ` Mark Brown
2024-09-10 7:36 ` Binbin Zhou
2024-09-06 2:10 ` kernel test robot [this message]
2024-09-05 7:02 ` [PATCH v1 05/10] ASoC: loongson: Improve code readability Binbin Zhou
2024-09-05 14:31 ` Mark Brown
2024-09-07 7:53 ` Binbin Zhou
2024-09-05 7:02 ` [PATCH v1 06/10] ASoC: loongson: Fix codec detection failure on FDT systems Binbin Zhou
2024-09-06 10:28 ` Krzysztof Kozlowski
2024-09-09 7:51 ` Binbin Zhou
2024-09-09 7:53 ` Krzysztof Kozlowski
2024-09-05 7:02 ` [PATCH v1 07/10] ASoC: dt-bindings: Add Loongson I2S controller Binbin Zhou
2024-09-06 10:23 ` Krzysztof Kozlowski
2024-09-07 8:26 ` Binbin Zhou
2024-09-05 7:07 ` [PATCH v1 08/10] ASoC: loongson: Add I2S controller driver as platform device Binbin Zhou
2024-09-05 14:36 ` Mark Brown
2024-09-07 8:08 ` Binbin Zhou
2024-09-07 12:14 ` Mark Brown
2024-09-06 1:08 ` kernel test robot
2024-09-06 6:18 ` kernel test robot
2024-09-06 11:37 ` Geert Uytterhoeven
2024-09-07 8:18 ` Binbin Zhou
2024-09-05 7:07 ` [PATCH v1 09/10] LoongArch: dts: Add I2S support to Loongson-2K1000 Binbin Zhou
2024-09-05 7:07 ` [PATCH v1 10/10] LoongArch: dts: Add I2S support to Loongson-2K2000 Binbin Zhou
2024-09-05 8:13 ` [PATCH v1 00/10] ASoC: Some issues about loongson i2s Krzysztof Kozlowski
2024-09-05 8:34 ` Binbin Zhou
2024-09-05 8:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202409060936.0UeDj3S7-lkp@intel.com \
--to=lkp@intel.com \
--cc=broonie@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@xen0n.name \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).