devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Marek Vasut <marex@denx.de>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: renesas: white-hawk-cpu: Move avb0 reset gpio to mdio node
Date: Fri, 6 Sep 2024 15:52:01 +0200	[thread overview]
Message-ID: <20240906135201.GU3708622@fsdn.se> (raw)
In-Reply-To: <CAMuHMdXRhUr1My-w0+hoAhQKgOq9iwecjow4iZTh82ED5DEfdA@mail.gmail.com>

Hello Geert and Marek,

On 2024-08-22 15:56:44 +0200, Geert Uytterhoeven wrote:
> Hi Marek,
> 
> On Fri, Aug 2, 2024 at 7:16 PM Marek Vasut <marex@denx.de> wrote:
> > On 8/2/24 10:33 AM, Geert Uytterhoeven wrote:
> > > What is your stance on this?
> 
> > > On Thu, Jul 4, 2024 at 5:26 PM Niklas Söderlund
> > > <niklas.soderlund+renesas@ragnatech.se> wrote:
> > >> When creating a dedicated mdio node to describe the bus the gpio reset
> > >> property was erroneously left in the phy node. The reason for adding
> > >> mdio nodes on WhiteHawk was to ensure the PHYs where reset before they
> > >> were probed, keeping the property in the phy node prevented this.
> >
> > If the PHYs should be reset before they are probed, that is something
> > the PHY driver should take care of, right ? The PHY driver can bind to
> > the PHY via compatible string. Does the PHY driver not reset the PHYs ?
> 
> AFAIK, there is no requirement to reset the PHY before it is probed.
> However, the reset signal may be in asserted state when the PHY is
> probed (e.g. after unbind from the Ethernet driver, or during kexec).
> Identifying the PHY by reading the ID register requires deasserting
> the reset first.

Did we reach consensus on this? My primary motivation for this was to 
align it what is done for the other AVB instances on WhiteHawk, which do 
have the reset-gpios property in the mdio node and not the phy node.

As having a mdio node at all is a new-ish thing for AVB as this was
needed or the mv88q2110 PHYs connected to the other AVBs to function. If 
we are happy to have this here for AVB0 I will drop this patch.

-- 
Kind Regards,
Niklas Söderlund

  reply	other threads:[~2024-09-06 13:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-04 15:26 [PATCH] arm64: dts: renesas: white-hawk-cpu: Move avb0 reset gpio to mdio node Niklas Söderlund
2024-08-02  8:33 ` Geert Uytterhoeven
2024-08-02 17:16   ` Marek Vasut
2024-08-22 13:56     ` Geert Uytterhoeven
2024-09-06 13:52       ` Niklas Söderlund [this message]
2024-09-06 18:09       ` Marek Vasut
2024-10-15 14:48         ` Niklas Söderlund
2024-10-20 22:16           ` Marek Vasut
2024-10-21  7:13             ` Geert Uytterhoeven
2024-10-21 21:31               ` Marek Vasut
2024-10-22  7:38                 ` Geert Uytterhoeven
2024-10-27 15:21                   ` Marek Vasut
2024-10-28 10:13                     ` Geert Uytterhoeven
2024-10-28 18:18                       ` Marek Vasut
2024-10-29  8:26                         ` Geert Uytterhoeven
2024-10-30 14:45                           ` Marek Vasut
2025-01-23 13:18                             ` Niklas Söderlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240906135201.GU3708622@fsdn.se \
    --to=niklas.soderlund+renesas@ragnatech.se \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).