Re: [PATCH v5 2/9] iio: adc: ad7606: add 'bits' parameter to channels macros

Jonathan Cameron
2024-09-07T14:53:50Z

On Sat, 7 Sep 2024 09:50:35 +0300
Alexandru Ardelean <aardelean@baylibre.com> wrote:

> There are some newer additions to the AD7606 family, which support 18 bit
> precision.
> Up until now, all chips were 16 bit.

Trivial but this is really odd style. Sort of has a paragraph and
a 'sub paragraph' going on.

Go with this:

There are some newer additions to the AD7606 family, which support 18 bit
precision. Up until now, all chips were 16 bit.

This change adds a 'bits' parameter to the AD760X_CHANNEL macro and renames
'ad7606_channels' -> 'ad7606_channels_16bit' for the current devices.

etc.

Patch looks fine to me.

>
> This change adds a 'bits' parameter to the AD760X_CHANNEL macro and renames
> 'ad7606_channels' -> 'ad7606_channels_16bit' for the current devices.
>
> The AD7606_SW_CHANNEL() macro is also introduced, as a short-hand for IIO
> channels in SW mode.
>
> Signed-off-by: Alexandru Ardelean <aardelean@baylibre.com>