From: Vasileios Amoiridis <vassilisamir@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Vasileios Amoiridis <vassilisamir@gmail.com>,
robh@kernel.org, saravanak@google.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] of/irq: Use helper to define resources
Date: Wed, 11 Sep 2024 00:00:34 +0200 [thread overview]
Message-ID: <20240910220034.GC12725@vamoiridPC> (raw)
In-Reply-To: <w4mq5nareqaf3fpwf3hr4oywgxlnjy33va5ftspw5rmdxuflms@x3lw3pj64tig>
On Sun, Sep 08, 2024 at 10:44:15AM +0200, Krzysztof Kozlowski wrote:
> On Thu, Sep 05, 2024 at 11:34:54AM +0300, Andy Shevchenko wrote:
> > On Wed, Sep 04, 2024 at 06:02:38PM +0200, Vasileios Amoiridis wrote:
> > > Resources definition can become simpler and more organised by using the
> > > dedicated helpers.
> >
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > ...
> >
> > > + *r = DEFINE_RES_IRQ_NAMED(irq, name ? name : of_node_full_name(dev))
> >
> > Just use Elvis to make this shorten.
> > Btw, have you ever compiled this?
>
> It wasn't ever built... and if not built, probably not tested, either.
>
> Best regards,
> Krzysztof
>
Hi Andy, Krzysztof,
That is a stupid mistake. I was sending around quite some patches and
lost concentration a bit. Will fix that.
Cheers,
Vasilis
next prev parent reply other threads:[~2024-09-10 22:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 16:02 [PATCH v2 0/2] Use functionality of irq_get_trigger_type() Vasileios Amoiridis
2024-09-04 16:02 ` [PATCH v2 1/2] of/irq: Make use " Vasileios Amoiridis
2024-09-04 16:02 ` [PATCH v2 2/2] of/irq: Use helper to define resources Vasileios Amoiridis
2024-09-05 8:34 ` Andy Shevchenko
2024-09-08 8:44 ` Krzysztof Kozlowski
2024-09-10 22:00 ` Vasileios Amoiridis [this message]
2024-09-07 19:22 ` kernel test robot
2024-09-07 20:16 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910220034.GC12725@vamoiridPC \
--to=vassilisamir@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).