From: Amit Sunil Dhamne <amitsd@google.com>
To: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, heikki.krogerus@linux.intel.com,
gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, kyletso@google.com,
rdbabiera@google.com, Amit Sunil Dhamne <amitsd@google.com>,
Badhri Jagan Sridharan <badhri@google.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org
Subject: [RFC 1/2] dt-bindings: connector: Add property to set pd timer values
Date: Tue, 10 Sep 2024 17:07:05 -0700 [thread overview]
Message-ID: <20240911000715.554184-2-amitsd@google.com> (raw)
In-Reply-To: <20240911000715.554184-1-amitsd@google.com>
This commit adds a new property "pd-timers" to enable setting of
platform/board specific pd timer values for timers that have a range of
acceptable values.
Cc: Badhri Jagan Sridharan <badhri@google.com>
Cc: linux-usb@vger.kernel.org
Cc: devicetree@vger.kernel.org
Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
---
.../bindings/connector/usb-connector.yaml | 23 +++++++++++++++++++
include/dt-bindings/usb/pd.h | 8 +++++++
2 files changed, 31 insertions(+)
diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
index fb216ce68bb3..9be4ed12f13c 100644
--- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
+++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
@@ -253,6 +253,16 @@ properties:
additionalProperties: false
+ pd-timers:
+ description: An array of u32 integers, where an even index (i) is the timer (referenced in
+ dt-bindings/usb/pd.h) and the odd index (i+1) is the timer value in ms (refer
+ "Table 6-68 Time Values" of "USB Power Delivery Specification Revision 3.0, Version 1.2 " for
+ the appropriate value). For certain timers the PD spec defines a range rather than a fixed
+ value. The timers may need to be tuned based on the platform. This dt property allows the user
+ to assign specific values based on the platform. If these values are not explicitly defined,
+ TCPM will use a valid default value for such timers.
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+
dependencies:
sink-vdos-v1: [ sink-vdos ]
sink-vdos: [ sink-vdos-v1 ]
@@ -478,3 +488,16 @@ examples:
};
};
};
+
+ # USB-C connector with PD timers
+ - |
+ #include <dt-bindings/usb/pd.h>
+ usb {
+ connector {
+ compatible = "usb-c-connector";
+ label = "USB-C";
+ pd-timers =
+ <PD_TIMER_SINK_WAIT_CAP 600>,
+ <PD_TIMER_CC_DEBOUNCE 170>;
+ };
+ };
diff --git a/include/dt-bindings/usb/pd.h b/include/dt-bindings/usb/pd.h
index e6526b138174..6c58c30f3f39 100644
--- a/include/dt-bindings/usb/pd.h
+++ b/include/dt-bindings/usb/pd.h
@@ -465,4 +465,12 @@
| ((vbm) & 0x3) << 15 | (curr) << 14 | ((vbi) & 0x3f) << 7 \
| ((gi) & 0x3f) << 1 | (ct))
+/* PD Timer definitions */
+/* tTypeCSinkWaitCap (Table 6-68 Time Values, USB PD3.1 Spec) */
+#define PD_TIMER_SINK_WAIT_CAP 0
+/* tPSSourceOff (Table 6-68 Time Values, USB PD3.1 Spec) */
+#define PD_TIMER_PS_SOURCE_OFF 1
+/* tCCDebounce (Table 4-33 CC Timing, USB Type-C Cable & Connector Spec Rel2.2) */
+#define PD_TIMER_CC_DEBOUNCE 2
+
#endif /* __DT_POWER_DELIVERY_H */
--
2.46.0.598.g6f2099f65c-goog
next parent reply other threads:[~2024-09-11 0:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240911000715.554184-1-amitsd@google.com>
2024-09-11 0:07 ` Amit Sunil Dhamne [this message]
2024-09-12 10:05 ` [RFC 1/2] dt-bindings: connector: Add property to set pd timer values Dmitry Baryshkov
2024-09-12 23:26 ` Amit Sunil Dhamne
2024-09-13 4:34 ` Dmitry Baryshkov
2024-09-16 16:33 ` Rob Herring
2024-09-16 23:52 ` Amit Sunil Dhamne
2024-09-16 16:05 ` Krzysztof Kozlowski
2024-09-16 16:05 ` Krzysztof Kozlowski
2024-09-17 1:59 ` Amit Sunil Dhamne
2024-09-27 7:48 ` Krzysztof Kozlowski
2024-10-07 19:45 ` Amit Sunil Dhamne
2024-09-11 0:07 ` [RFC 2/2] usb: typec: tcpm: Add support for pd-timers DT property Amit Sunil Dhamne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240911000715.554184-2-amitsd@google.com \
--to=amitsd@google.com \
--cc=badhri@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rdbabiera@google.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).