Re: [PATCH 05/22] dt-bindings: arm: apple: Add A7 devices

Nick Chan
2024-09-11T18:24:28Z

On 12/9/2024 02:13, Conor Dooley wrote:
> On Wed, Sep 11, 2024 at 04:40:55PM +0800, Nick Chan wrote:
>> This adds the following apple,s5l8960x platforms:
>>
>> - iPhone 5s
>> - iPad Air (1)
>> - iPad Mini 2
>> - iPad Mini 3
>>
>> Signed-off-by: Nick Chan <towinchenmi@gmail.com>
>> ---
>> .../devicetree/bindings/arm/apple.yaml | 26 ++++++++++++++++++-
>> 1 file changed, 25 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/apple.yaml b/Documentation/devicetree/bindings/arm/apple.yaml
>> index 883fd67e3752..3c81008f0e96 100644
>> --- a/Documentation/devicetree/bindings/arm/apple.yaml
>> +++ b/Documentation/devicetree/bindings/arm/apple.yaml
>> @@ -12,7 +12,14 @@ maintainers:
>> description: |
>> ARM platforms using SoCs designed by Apple Inc., branded "Apple Silicon".
>>
>> - This currently includes devices based on the "M1" SoC:
>> + This currently includes devices based on the "A7" SoC:
>> +
>> + - iPhone 5s
>> + - iPad Air (1)
>> + - iPad Mini 2
>> + - iPad Mini 3
>> +
>> + Devices based on the "M1" SoC:
>>
>> - Mac mini (M1, 2020)
>> - MacBook Pro (13-inch, M1, 2020)
>> @@ -65,6 +72,23 @@ properties:
>> const: "/"
>> compatible:
>> oneOf:
>> + - description: Apple A7 SoC based platforms
>> + items:
>> + - enum:
>> + - apple,j71 # iPad Air (Wi-Fi)
>> + - apple,j72 # iPad Air (Cellular)
>> + - apple,j73 # iPad Air (Cellular, China)
>> + - apple,j85 # iPad mini 2 (Wi-Fi)
>> + - apple,j85m # iPad mini 3 (Wi-Fi)
>> + - apple,j86 # iPad mini 2 (Cellular)
>> + - apple,j86m # iPad mini 3 (Cellular)
>> + - apple,j87 # Apple iPad Mini 2 (Cellular, China)
>> + - apple,j87m # Apple iPad Mini 3 (Cellular, China)
>> + - apple,n51 # iPhone 5s (GSM)
>> + - apple,n53 # iPhone 5s (LTE)
>> + - const: apple,s5l8960x
>
> Is the "x" here a wildcard?
No. This is part of the SoC ID. This is the legacy naming from when Apple
used Samsung SoCs for iPhones and iPods, and every SoC would have an ID
beginning with "s5l", and ending with a "x". Apple A7 is last SoC to use
this legacy naming scheme.

>
>> + - const: apple,arm-platform
>> +
>> - description: Apple M1 SoC based platforms
>> items:
>> - enum:
>> --
>> 2.46.0
>>

Nick Chan