From: Rob Herring <robh@kernel.org>
To: Vasileios Amoiridis <vassilisamir@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
saravanak@google.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] of/irq: Use helper to define resources
Date: Thu, 12 Sep 2024 14:57:53 -0500 [thread overview]
Message-ID: <20240912195753.GA555349-robh@kernel.org> (raw)
In-Reply-To: <20240911173438.GA5015@vamoiridPC>
On Wed, Sep 11, 2024 at 07:34:38PM +0200, Vasileios Amoiridis wrote:
> On Wed, Sep 11, 2024 at 07:15:33PM +0300, Andy Shevchenko wrote:
> > On Wed, Sep 11, 2024 at 06:02:53PM +0200, Vasileios Amoiridis wrote:
> > > Resources definition can become simpler and more organised by using the
> > > dedicated helpers.
> >
> > ...
> >
> > > - r->start = r->end = irq;
> > > - r->flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
> > > - r->name = name ? name : of_node_full_name(dev);
> > > + *r = DEFINE_RES_IRQ_NAMED(irq, name ? name : of_node_full_name(dev));
> >
> > Hmm... It seems you haven't replied to me why you avoid using Elvis here,
> > while at it.
> >
> > Also for both patches you probably want
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > > + r->flags |= irq_get_trigger_type(irq);
> >
> > --
> > With Best Regards,
> > Andy Shevchenko
> >
> >
>
>
> Hi Andy,
>
> Thanks for your message once again!!
>
> I honestly didn't know this operator, I just found out about it.
> Looks like it fits here, I can definitely use it.
>
> I am going to leave it for a while to see if Krzysztof or Rob have
> any other comments and then I can send as you proposed.
No comments from me, please send with the updates.
Rob
prev parent reply other threads:[~2024-09-12 19:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 16:02 [PATCH v3 0/2] Use functionality of irq_get_trigger_type() and DEFINE_* Vasileios Amoiridis
2024-09-11 16:02 ` [PATCH v3 1/2] of/irq: Make use of irq_get_trigger_type() Vasileios Amoiridis
2024-09-11 16:02 ` [PATCH v3 2/2] of/irq: Use helper to define resources Vasileios Amoiridis
2024-09-11 16:15 ` Andy Shevchenko
2024-09-11 17:34 ` Vasileios Amoiridis
2024-09-12 19:57 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240912195753.GA555349-robh@kernel.org \
--to=robh@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saravanak@google.com \
--cc=vassilisamir@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).