[PATCH v4 0/2] Use functionality of irq_get_trigger_type() and

[PATCH v4 0/2] Use functionality of irq_get_trigger_type() and

[Vasileios Amoiridis]

The series is compile tested.

Changes in v4:
	- Use Elvis operator in patch no.2

---
v3: https://lore.kernel.org/linux-devicetree/20240911160253.37221-1-vassilisamir@gmail.com/

Changes in v3:
	- Fix syntax error in patch no.2

---
v2: https://lore.kernel.org/linux-devicetree/20240904160239.121301-1-vassilisamir@gmail.com/

Changes in v2:
        - Split patches to subsystems
        - Use DEFINE_* helpers to define resources

---
v1: https://lore.kernel.org/all/20240902225534.130383-1-vassilisamir@gmail.com/

28/11/2024Vasileios Amoiridis (2):
  of/irq: Make use of irq_get_trigger_type()
  of/irq: Use helper to define resources

 drivers/of/irq.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)


base-commit: 32ffa5373540a8d1c06619f52d019c6cdc948bb4
-- 
2.25.1

[PATCH v4 1/2] of/irq: Make use of irq_get_trigger_type()

[Vasileios Amoiridis]

Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
simple irq_get_trigger_type(irq).

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
 drivers/of/irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 36351ad6115e..5d27b20634d3 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -430,7 +430,7 @@ int of_irq_to_resource(struct device_node *dev, int index, struct resource *r)
 					      &name);
 
 		r->start = r->end = irq;
-		r->flags = IORESOURCE_IRQ | irqd_get_trigger_type(irq_get_irq_data(irq));
+		r->flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
 		r->name = name ? name : of_node_full_name(dev);
 	}
 

base-commit: 32ffa5373540a8d1c06619f52d019c6cdc948bb4
-- 
2.25.1

[PATCH v4 2/2] of/irq: Use helper to define resources

[Vasileios Amoiridis]

Resources definition can become simpler and more organised by using the
dedicated helpers.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
 drivers/of/irq.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 5d27b20634d3..a494f56a0d0e 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -429,9 +429,8 @@ int of_irq_to_resource(struct device_node *dev, int index, struct resource *r)
 		of_property_read_string_index(dev, "interrupt-names", index,
 					      &name);
 
-		r->start = r->end = irq;
-		r->flags = IORESOURCE_IRQ | irq_get_trigger_type(irq);
-		r->name = name ? name : of_node_full_name(dev);
+		*r = DEFINE_RES_IRQ_NAMED(irq, name ?: of_node_full_name(dev));
+		r->flags |= irq_get_trigger_type(irq);
 	}
 
 	return irq;
-- 
2.25.1

Re: [PATCH v4 0/2] Use functionality of irq_get_trigger_type() and

[Andy Shevchenko]

On Fri, Sep 13, 2024 at 12:16:03AM +0200, Vasileios Amoiridis wrote:
> The series is compile tested.

LGTM, FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v4 0/2] Use functionality of irq_get_trigger_type() and

[Rob Herring (Arm)]

On Fri, 13 Sep 2024 00:16:03 +0200, Vasileios Amoiridis wrote:
> The series is compile tested.
> 
> Changes in v4:
> 	- Use Elvis operator in patch no.2
> 
> ---
> v3: https://lore.kernel.org/linux-devicetree/20240911160253.37221-1-vassilisamir@gmail.com/
> 
> Changes in v3:
> 	- Fix syntax error in patch no.2
> 
> ---
> v2: https://lore.kernel.org/linux-devicetree/20240904160239.121301-1-vassilisamir@gmail.com/
> 
> Changes in v2:
>         - Split patches to subsystems
>         - Use DEFINE_* helpers to define resources
> 
> ---
> v1: https://lore.kernel.org/all/20240902225534.130383-1-vassilisamir@gmail.com/
> 
> 28/11/2024Vasileios Amoiridis (2):
>   of/irq: Make use of irq_get_trigger_type()
>   of/irq: Use helper to define resources
> 
>  drivers/of/irq.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> 
> base-commit: 32ffa5373540a8d1c06619f52d019c6cdc948bb4
> --
> 2.25.1
> 
> 
> 

Applied, thanks!