devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dzmitry Sankouski <dsankouski@gmail.com>
To: "Sebastian Reichel" <sre@kernel.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Jessica Zhang" <quic_jesszhan@quicinc.com>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Lee Jones" <lee@kernel.org>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Pavel Machek" <pavel@ucw.cz>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Uwe Kleine-König" <ukleinek@kernel.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Chanwoo Choi" <cw00.choi@samsung.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	cros-qcom-dts-watchers@chromium.org,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"Simona Vetter" <simona.vetter@ffwll.ch>,
	"Konrad Dybcio" <konradybcio@kernel.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	 dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	 linux-input@vger.kernel.org, linux-leds@vger.kernel.org,
	 linux-pwm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	 Dzmitry Sankouski <dsankouski@gmail.com>
Subject: [PATCH v4 02/27] clk: qcom: clk-rcg2: name refactoring
Date: Fri, 13 Sep 2024 18:07:45 +0300	[thread overview]
Message-ID: <20240913-starqltechn_integration_upstream-v4-2-2d2efd5c5877@gmail.com> (raw)
In-Reply-To: <20240913-starqltechn_integration_upstream-v4-0-2d2efd5c5877@gmail.com>

clk-rcg2.c uses 2 variable names for pre divisor register value:
pre_div and hid_div.

Replace hid_div with pre_div. Update calc_rate docs to reflect, that
pre_div is not pure divisor, but a register value, and requires conversion.

Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
 drivers/clk/qcom/clk-rcg2.c | 51 ++++++++++++++++++++++++++-------------------
 1 file changed, 29 insertions(+), 22 deletions(-)

diff --git a/drivers/clk/qcom/clk-rcg2.c b/drivers/clk/qcom/clk-rcg2.c
index bf26c5448f00..df491540ef39 100644
--- a/drivers/clk/qcom/clk-rcg2.c
+++ b/drivers/clk/qcom/clk-rcg2.c
@@ -153,13 +153,20 @@ static int clk_rcg2_set_parent(struct clk_hw *hw, u8 index)
  *
  *          parent_rate     m
  *   rate = ----------- x  ---
- *            hid_div       n
+ *          pre_div_pure    n
+ *
+ * @param rate - Parent rate.
+ * @param m - Multiplier.
+ * @param n - Divisor.
+ * @param mode - Use zero to ignore m/n calculation.
+ * @param pre_div - Pre divisor register value. Pure pre divisor value
+ *                  related to pre_div as pre_div_pure = (pre_div + 1) / 2
  */
 static unsigned long
-calc_rate(unsigned long rate, u32 m, u32 n, u32 mode, u32 hid_div)
+calc_rate(unsigned long rate, u32 m, u32 n, u32 mode, u32 pre_div)
 {
-	if (hid_div)
-		rate = mult_frac(rate, 2, hid_div + 1);
+	if (pre_div)
+		rate = mult_frac(rate, 2, pre_div + 1);
 
 	if (mode)
 		rate = mult_frac(rate, m, n);
@@ -171,7 +178,7 @@ static unsigned long
 __clk_rcg2_recalc_rate(struct clk_hw *hw, unsigned long parent_rate, u32 cfg)
 {
 	struct clk_rcg2 *rcg = to_clk_rcg2(hw);
-	u32 hid_div, m = 0, n = 0, mode = 0, mask;
+	u32 pre_div, m = 0, n = 0, mode = 0, mask;
 
 	if (rcg->mnd_width) {
 		mask = BIT(rcg->mnd_width) - 1;
@@ -186,10 +193,10 @@ __clk_rcg2_recalc_rate(struct clk_hw *hw, unsigned long parent_rate, u32 cfg)
 	}
 
 	mask = BIT(rcg->hid_width) - 1;
-	hid_div = cfg >> CFG_SRC_DIV_SHIFT;
-	hid_div &= mask;
+	pre_div = cfg >> CFG_SRC_DIV_SHIFT;
+	pre_div &= mask;
 
-	return calc_rate(parent_rate, m, n, mode, hid_div);
+	return calc_rate(parent_rate, m, n, mode, pre_div);
 }
 
 static unsigned long
@@ -715,7 +722,7 @@ static int clk_edp_pixel_set_rate(struct clk_hw *hw, unsigned long rate,
 	s64 src_rate = parent_rate;
 	s64 request;
 	u32 mask = BIT(rcg->hid_width) - 1;
-	u32 hid_div;
+	u32 pre_div;
 
 	if (src_rate == 810000000)
 		frac = frac_table_810m;
@@ -731,8 +738,8 @@ static int clk_edp_pixel_set_rate(struct clk_hw *hw, unsigned long rate,
 			continue;
 
 		regmap_read(rcg->clkr.regmap, rcg->cmd_rcgr + CFG_REG,
-				&hid_div);
-		f.pre_div = hid_div;
+				&pre_div);
+		f.pre_div = pre_div;
 		f.pre_div >>= CFG_SRC_DIV_SHIFT;
 		f.pre_div &= mask;
 		f.m = frac->num;
@@ -760,7 +767,7 @@ static int clk_edp_pixel_determine_rate(struct clk_hw *hw,
 	int delta = 100000;
 	s64 request;
 	u32 mask = BIT(rcg->hid_width) - 1;
-	u32 hid_div;
+	u32 pre_div;
 	int index = qcom_find_src_index(hw, rcg->parent_map, f->src);
 
 	/* Force the correct parent */
@@ -781,13 +788,13 @@ static int clk_edp_pixel_determine_rate(struct clk_hw *hw,
 			continue;
 
 		regmap_read(rcg->clkr.regmap, rcg->cmd_rcgr + CFG_REG,
-				&hid_div);
-		hid_div >>= CFG_SRC_DIV_SHIFT;
-		hid_div &= mask;
+				&pre_div);
+		pre_div >>= CFG_SRC_DIV_SHIFT;
+		pre_div &= mask;
 
 		req->rate = calc_rate(req->best_parent_rate,
 				      frac->num, frac->den,
-				      !!frac->den, hid_div);
+				      !!frac->den, pre_div);
 		return 0;
 	}
 
@@ -974,7 +981,7 @@ static int clk_pixel_set_rate(struct clk_hw *hw, unsigned long rate,
 	unsigned long request;
 	int delta = 100000;
 	u32 mask = BIT(rcg->hid_width) - 1;
-	u32 hid_div, cfg;
+	u32 pre_div, cfg;
 	int i, num_parents = clk_hw_get_num_parents(hw);
 
 	regmap_read(rcg->clkr.regmap, rcg->cmd_rcgr + CFG_REG, &cfg);
@@ -995,8 +1002,8 @@ static int clk_pixel_set_rate(struct clk_hw *hw, unsigned long rate,
 			continue;
 
 		regmap_read(rcg->clkr.regmap, rcg->cmd_rcgr + CFG_REG,
-				&hid_div);
-		f.pre_div = hid_div;
+				&pre_div);
+		f.pre_div = pre_div;
 		f.pre_div >>= CFG_SRC_DIV_SHIFT;
 		f.pre_div &= mask;
 		f.m = frac->num;
@@ -1564,7 +1571,7 @@ static int clk_rcg2_dp_set_rate(struct clk_hw *hw, unsigned long rate,
 	struct clk_rcg2 *rcg = to_clk_rcg2(hw);
 	struct freq_tbl f = { 0 };
 	u32 mask = BIT(rcg->hid_width) - 1;
-	u32 hid_div, cfg;
+	u32 pre_div, cfg;
 	int i, num_parents = clk_hw_get_num_parents(hw);
 	unsigned long num, den;
 
@@ -1576,7 +1583,7 @@ static int clk_rcg2_dp_set_rate(struct clk_hw *hw, unsigned long rate,
 		return -EINVAL;
 
 	regmap_read(rcg->clkr.regmap, rcg->cmd_rcgr + CFG_REG, &cfg);
-	hid_div = cfg;
+	pre_div = cfg;
 	cfg &= CFG_SRC_SEL_MASK;
 	cfg >>= CFG_SRC_SEL_SHIFT;
 
@@ -1587,7 +1594,7 @@ static int clk_rcg2_dp_set_rate(struct clk_hw *hw, unsigned long rate,
 		}
 	}
 
-	f.pre_div = hid_div;
+	f.pre_div = pre_div;
 	f.pre_div >>= CFG_SRC_DIV_SHIFT;
 	f.pre_div &= mask;
 

-- 
2.39.2


  parent reply	other threads:[~2024-09-13 15:08 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-13 15:07 [PATCH v4 00/27] This is continued work on Samsung S9(SM-9600) starqltechn Dzmitry Sankouski
2024-09-13 15:07 ` [PATCH v4 01/27] power: supply: add undervoltage health status property Dzmitry Sankouski
2024-09-14  8:38   ` Sebastian Reichel
2024-09-13 15:07 ` Dzmitry Sankouski [this message]
2024-09-13 18:56   ` [PATCH v4 02/27] clk: qcom: clk-rcg2: name refactoring Stephen Boyd
2024-09-13 15:07 ` [PATCH v4 03/27] gcc-sdm845: Add general purpose clock ops Dzmitry Sankouski
2024-09-14  4:51   ` kernel test robot
2024-09-14  6:56   ` kernel test robot
2024-09-13 15:07 ` [PATCH v4 04/27] dt-bindings: panel: add Samsung s6e3ha8 Dzmitry Sankouski
2024-09-16 20:08   ` Krzysztof Kozlowski
2024-09-13 15:07 ` [PATCH v4 05/27] dt-bindings: mfd: add maxim,max77705 Dzmitry Sankouski
2024-09-13 16:37   ` Rob Herring (Arm)
2024-09-13 21:55   ` Rob Herring
2024-09-13 15:07 ` [PATCH v4 06/27] dt-bindings: mfd: add samsung,s2dos05 Dzmitry Sankouski
2024-09-16  9:13   ` Krzysztof Kozlowski
2024-09-19 12:50     ` Dzmitry Sankouski
2024-09-13 15:07 ` [PATCH v4 07/27] drm/panel: Add support for S6E3HA8 panel driver Dzmitry Sankouski
2024-09-21 20:34   ` Dmitry Baryshkov
2024-09-13 15:07 ` [PATCH v4 08/27] mfd: max77693: remove unused declarations Dzmitry Sankouski
2024-09-16  9:09   ` Krzysztof Kozlowski
2024-09-18 12:53     ` Dzmitry Sankouski
2024-09-19  7:00       ` Krzysztof Kozlowski
2024-09-19  8:40         ` Dzmitry Sankouski
2024-09-19 10:07           ` Krzysztof Kozlowski
2024-09-13 15:07 ` [PATCH v4 09/27] mfd: Add new driver for MAX77705 PMIC Dzmitry Sankouski
2024-09-13 15:07 ` [PATCH v4 10/27] input: max77693: add max77705 haptic support Dzmitry Sankouski
2024-09-13 15:07 ` [PATCH v4 11/27] power: supply: max77705: Add charger driver for Maxim 77705 Dzmitry Sankouski
2024-09-14  5:12   ` kernel test robot
2024-09-13 15:07 ` [PATCH v4 12/27] power: supply: max77705: Add fuel gauge " Dzmitry Sankouski
2024-09-13 15:07 ` [PATCH v4 13/27] leds: max77705: Add LEDs support Dzmitry Sankouski
2024-09-13 15:07 ` [PATCH v4 14/27] mfd: sec-core: add s2dos05 support Dzmitry Sankouski
2024-09-16  9:09   ` Krzysztof Kozlowski
2024-09-13 15:07 ` [PATCH v4 15/27] regulator: add s2dos05 regulator support Dzmitry Sankouski
2024-09-16  9:21   ` Krzysztof Kozlowski
2024-09-19 14:28     ` Dzmitry Sankouski
2024-09-23  9:07       ` Krzysztof Kozlowski
2024-09-13 15:07 ` [PATCH v4 16/27] arm64: dts: qcom: sdm845: enable gmu Dzmitry Sankouski
2024-09-13 19:02   ` Steev Klimaszewski
2024-09-13 15:08 ` [PATCH v4 17/27] arm64: dts: qcom: starqltechn: remove wifi Dzmitry Sankouski
2024-09-13 15:08 ` [PATCH v4 18/27] arm64: dts: qcom: starqltechn: fix usb regulator mistake Dzmitry Sankouski
2024-09-13 15:08 ` [PATCH v4 19/27] arm64: dts: qcom: starqltechn: refactor node order Dzmitry Sankouski
2024-09-13 15:08 ` [PATCH v4 20/27] arm64: dts: qcom: starqltechn: remove excess reserved gpios Dzmitry Sankouski
2024-09-13 15:08 ` [PATCH v4 21/27] arm64: dts: qcom: starqltechn: add gpio keys Dzmitry Sankouski
2024-09-13 15:08 ` [PATCH v4 22/27] arm64: dts: qcom: starqltechn: add max77705 PMIC Dzmitry Sankouski
2024-09-16  9:17   ` Krzysztof Kozlowski
2024-09-13 15:08 ` [PATCH v4 23/27] arm64: dts: qcom: starqltechn: add display PMIC Dzmitry Sankouski
2024-09-16  9:15   ` Krzysztof Kozlowski
2024-09-19 13:17     ` Dzmitry Sankouski
2024-09-19 14:00       ` Krzysztof Kozlowski
2024-09-13 15:08 ` [PATCH v4 24/27] arm64: dts: qcom: starqltechn: add touchscreen support Dzmitry Sankouski
2024-09-13 15:08 ` [PATCH v4 25/27] arm64: dts: qcom: starqltechn: add initial sound support Dzmitry Sankouski
2024-09-13 15:08 ` [PATCH v4 26/27] arm64: dts: qcom: starqltechn: add graphics support Dzmitry Sankouski
2024-09-13 15:08 ` [PATCH v4 27/27] arm64: dts: qcom: starqltechn: add modem support Dzmitry Sankouski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240913-starqltechn_integration_upstream-v4-2-2d2efd5c5877@gmail.com \
    --to=dsankouski@gmail.com \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lee@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=neil.armstrong@linaro.org \
    --cc=pavel@ucw.cz \
    --cc=quic_jesszhan@quicinc.com \
    --cc=robh@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=sboyd@kernel.org \
    --cc=simona.vetter@ffwll.ch \
    --cc=simona@ffwll.ch \
    --cc=sre@kernel.org \
    --cc=tzimmermann@suse.de \
    --cc=ukleinek@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).