From: Conor Dooley <conor@kernel.org>
To: Emil Gedenryd <emil.gedenryd@axis.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Andreas Dannenberg <dannenberg@ti.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, kernel@axis.com
Subject: Re: [PATCH v2 2/3] dt-bindings: iio: light: opt3001: add compatible for opt3002
Date: Fri, 13 Sep 2024 19:07:17 +0100 [thread overview]
Message-ID: <20240913-stimulate-swell-3964c45e6e81@spud> (raw)
In-Reply-To: <20240913-add_opt3002-v2-2-69e04f840360@axis.com>
[-- Attachment #1: Type: text/plain, Size: 1105 bytes --]
On Fri, Sep 13, 2024 at 11:57:03AM +0200, Emil Gedenryd wrote:
> OPT3002 is a Light-to-Digital Sensor by TI with support for wide-range
> spectrum light.
>
> Add the compatible string of opt3002.
You should mention what makes the 02 and 01 devices different here, and
with that done,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
>
> Signed-off-by: Emil Gedenryd <emil.gedenryd@axis.com>
> ---
> Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml b/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml
> index 441e9343fc97..67ca8d08256a 100644
> --- a/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/ti,opt3001.yaml
> @@ -15,7 +15,9 @@ description: |
>
> properties:
> compatible:
> - const: ti,opt3001
> + enum:
> + - ti,opt3001
> + - ti,opt3002
>
> reg:
> maxItems: 1
>
> --
> 2.39.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-09-13 18:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 9:57 [PATCH v2 0/3] iio: light: opt3001: add support for TI's opt3002 light sensor Emil Gedenryd
2024-09-13 9:57 ` [PATCH v2 1/3] iio: light: opt3001: add missing full-scale range value Emil Gedenryd
2024-09-14 16:06 ` Jonathan Cameron
2024-09-16 7:02 ` Emil Gedenryd
2024-09-13 9:57 ` [PATCH v2 2/3] dt-bindings: iio: light: opt3001: add compatible for opt3002 Emil Gedenryd
2024-09-13 18:07 ` Conor Dooley [this message]
2024-09-16 7:01 ` Emil Gedenryd
2024-09-13 9:57 ` [PATCH v2 3/3] iio: light: opt3001: add support for TI's opt3002 light sensor Emil Gedenryd
2024-09-14 16:19 ` Jonathan Cameron
2024-09-16 7:17 ` Emil Gedenryd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240913-stimulate-swell-3964c45e6e81@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dannenberg@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=emil.gedenryd@axis.com \
--cc=jic23@kernel.org \
--cc=kernel@axis.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).