devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>,
	 Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Rishi Gupta <gupt21@gmail.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	 Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	 Javier Carrasco <javier.carrasco.cruz@gmail.com>
Subject: [PATCH 2/7] dt-bindings: iio: light: veml6030: add veml6035
Date: Fri, 13 Sep 2024 15:18:57 +0200	[thread overview]
Message-ID: <20240913-veml6035-v1-2-0b09c0c90418@gmail.com> (raw)
In-Reply-To: <20240913-veml6035-v1-0-0b09c0c90418@gmail.com>

The veml6035 is a similar ambient light sensor to the veml6030, and
from the bindings point of view, it shares the same properties. Its
only difference in that respect is a different I2C address.

Estend the existing bindings to support the veml6035 ALS.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 .../bindings/iio/light/vishay,veml6030.yaml        | 40 +++++++++++++++++-----
 1 file changed, 31 insertions(+), 9 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml b/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
index 7f4995557570..f88e043d7ede 100644
--- a/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
+++ b/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml
@@ -4,14 +4,14 @@
 $id: http://devicetree.org/schemas/iio/light/vishay,veml6030.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: VEML6030 Ambient Light Sensor (ALS)
+title: VEML6030 and VEML6035 Ambient Light Sensors (ALS)
 
 maintainers:
   - Rishi Gupta <gupt21@gmail.com>
 
 description: |
-  Bindings for the ambient light sensor veml6030 from Vishay
-  Semiconductors over an i2c interface.
+  Bindings for the ambient light sensors veml6030 and veml6035 from
+  Vishay Semiconductors over an i2c interface.
 
   Irrespective of whether interrupt is used or not, application
   can get the ALS and White channel reading from IIO raw interface.
@@ -19,20 +19,18 @@ description: |
   If the interrupts are used, application will receive an IIO event
   whenever configured threshold is crossed.
 
-  Specifications about the sensor can be found at:
+  Specifications about the sensors can be found at:
     https://www.vishay.com/docs/84366/veml6030.pdf
+    https://www.vishay.com/docs/84889/veml6035.pdf
 
 properties:
   compatible:
     enum:
       - vishay,veml6030
+      - vishay,veml6035
 
   reg:
-    description:
-      I2C address of the device.
-    enum:
-      - 0x10 # ADDR pin pulled down
-      - 0x48 # ADDR pin pulled up
+    maxItems: 1
 
   interrupts:
     description:
@@ -45,6 +43,30 @@ required:
   - compatible
   - reg
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          enum:
+            - vishay,veml6030
+    then:
+      properties:
+        reg:
+          enum:
+            - 0x10  # ADDR pin pulled down
+            - 0x48  # ADDR pin pulled up
+
+  - if:
+      properties:
+        compatible:
+          enum:
+            - vishay,veml6035
+    then:
+      properties:
+        reg:
+          enum:
+            - 0x29
+
 additionalProperties: false
 
 examples:

-- 
2.43.0


  parent reply	other threads:[~2024-09-13 13:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-13 13:18 [PATCH 0/7] iio: light: veml6030: fix issues and add support for veml6035 Javier Carrasco
2024-09-13 13:18 ` [PATCH 1/7] dt-bindings: iio: light: veml6030: rename to add manufacturer Javier Carrasco
2024-09-13 16:53   ` Conor Dooley
2024-09-14 14:52     ` Jonathan Cameron
2024-09-13 13:18 ` Javier Carrasco [this message]
2024-09-13 16:55   ` [PATCH 2/7] dt-bindings: iio: light: veml6030: add veml6035 Conor Dooley
2024-09-13 13:18 ` [PATCH 3/7] iio: light: veml6030: fix IIO device retrieval from embedded device Javier Carrasco
2024-09-14 14:51   ` Jonathan Cameron
2024-09-13 13:18 ` [PATCH 4/7] iio: light: veml6030: make use of regmap_set_bits() Javier Carrasco
2024-09-14 14:54   ` Jonathan Cameron
2024-09-13 13:19 ` [PATCH 5/7] iio: light: veml6030: update sensor resolution Javier Carrasco
2024-09-14 14:57   ` Jonathan Cameron
2024-09-15  8:31     ` Javier Carrasco
2024-09-28 14:38       ` Jonathan Cameron
2024-09-13 13:19 ` [PATCH 6/7] iio: light: veml6030: add set up delay after any power on sequence Javier Carrasco
2024-09-14 14:59   ` Jonathan Cameron
2024-09-13 13:19 ` [PATCH 7/7] iio: light: veml6030: add support for veml6035 Javier Carrasco
2024-09-14 16:03   ` Jonathan Cameron
2024-09-16  6:19     ` Javier Carrasco
2024-09-28 14:40       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240913-veml6035-v1-2-0b09c0c90418@gmail.com \
    --to=javier.carrasco.cruz@gmail.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gupt21@gmail.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).