From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Rishi Gupta <gupt21@gmail.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Javier Carrasco <javier.carrasco.cruz@gmail.com>,
stable@vger.kernel.org
Subject: [PATCH 3/7] iio: light: veml6030: fix IIO device retrieval from embedded device
Date: Fri, 13 Sep 2024 15:18:58 +0200 [thread overview]
Message-ID: <20240913-veml6035-v1-3-0b09c0c90418@gmail.com> (raw)
In-Reply-To: <20240913-veml6035-v1-0-0b09c0c90418@gmail.com>
The dev pointer that is received as an argument in the
in_illuminance_period_available_show function references the device
embedded in the IIO device, not in the i2c client.
dev_to_iio_dev() must be used to accessthe right data. The current
implementation leads to a segmentation fault on every attempt to read
the attribute because indio_dev gets a NULL assignment.
This bug has been present since the first appearance of the driver,
apparently since the last version (V6) before getting applied. A
constant attribute was used until then, and the last modifications might
have not been tested again.
Cc: stable@vger.kernel.org
Fixes: 7b779f573c48 ("iio: light: add driver for veml6030 ambient light sensor")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
drivers/iio/light/veml6030.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iio/light/veml6030.c b/drivers/iio/light/veml6030.c
index 2e86d310952e..df2ba3078b91 100644
--- a/drivers/iio/light/veml6030.c
+++ b/drivers/iio/light/veml6030.c
@@ -99,9 +99,8 @@ static const char * const period_values[] = {
static ssize_t in_illuminance_period_available_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
+ struct veml6030_data *data = iio_priv(dev_to_iio_dev(dev));
int ret, reg, x;
- struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
- struct veml6030_data *data = iio_priv(indio_dev);
ret = regmap_read(data->regmap, VEML6030_REG_ALS_CONF, ®);
if (ret) {
--
2.43.0
next prev parent reply other threads:[~2024-09-13 13:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 13:18 [PATCH 0/7] iio: light: veml6030: fix issues and add support for veml6035 Javier Carrasco
2024-09-13 13:18 ` [PATCH 1/7] dt-bindings: iio: light: veml6030: rename to add manufacturer Javier Carrasco
2024-09-13 16:53 ` Conor Dooley
2024-09-14 14:52 ` Jonathan Cameron
2024-09-13 13:18 ` [PATCH 2/7] dt-bindings: iio: light: veml6030: add veml6035 Javier Carrasco
2024-09-13 16:55 ` Conor Dooley
2024-09-13 13:18 ` Javier Carrasco [this message]
2024-09-14 14:51 ` [PATCH 3/7] iio: light: veml6030: fix IIO device retrieval from embedded device Jonathan Cameron
2024-09-13 13:18 ` [PATCH 4/7] iio: light: veml6030: make use of regmap_set_bits() Javier Carrasco
2024-09-14 14:54 ` Jonathan Cameron
2024-09-13 13:19 ` [PATCH 5/7] iio: light: veml6030: update sensor resolution Javier Carrasco
2024-09-14 14:57 ` Jonathan Cameron
2024-09-15 8:31 ` Javier Carrasco
2024-09-28 14:38 ` Jonathan Cameron
2024-09-13 13:19 ` [PATCH 6/7] iio: light: veml6030: add set up delay after any power on sequence Javier Carrasco
2024-09-14 14:59 ` Jonathan Cameron
2024-09-13 13:19 ` [PATCH 7/7] iio: light: veml6030: add support for veml6035 Javier Carrasco
2024-09-14 16:03 ` Jonathan Cameron
2024-09-16 6:19 ` Javier Carrasco
2024-09-28 14:40 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240913-veml6035-v1-3-0b09c0c90418@gmail.com \
--to=javier.carrasco.cruz@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gupt21@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).