Re: [PATCH] dt-bindings: iio: dac: adi,ad56xx: Fix duplicate compatible strings

Rob Herring
2024-09-16T15:22:34Z

On Sat, Sep 14, 2024 at 9:18 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Tue, 10 Sep 2024 18:44:39 -0500
> "Rob Herring (Arm)" <robh@kernel.org> wrote:
>
> > adi,ad5686.yaml and adi,ad5696.yaml duplicate all the I2C device
> > compatible strings with the exception of "adi,ad5337r". Since
> > adi,ad5686.yaml references spi-peripheral-props.yaml, drop the I2C
> > devices from it making it only SPI devices. Update the titles to make
> > the distinction clear.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> Is this an urgent thing, or can it wait for the merge window after next?
> For now I've queued it up for then in my testing branch but can yank it
> out and send it as a fix after rc1 if that is useful.

Sooner would be better. It's now a warning in dtschema main branch.
The issue is not so much the duplication, but that which schema gets
applied is not deterministic.

Rob