From: Jonathan Cameron <jic23@kernel.org>
To: Vasileios Amoiridis <vassilisamir@gmail.com>
Cc: lars@metafoo.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andriy.shevchenko@linux.intel.com,
ang.iglesiasg@gmail.com, linus.walleij@linaro.org,
biju.das.jz@bp.renesas.com, javier.carrasco.cruz@gmail.com,
semen.protsenko@linaro.org, 579lpy@gmail.com, ak@it-klinger.de,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, christophe.jaillet@wanadoo.fr
Subject: Re: [PATCH v7 0/4] pressure: bmp280: Minor cleanup and interrupt support
Date: Sat, 14 Sep 2024 15:36:17 +0100 [thread overview]
Message-ID: <20240914153617.3f816e5a@jic23-huawei> (raw)
In-Reply-To: <20240914002900.45158-1-vassilisamir@gmail.com>
On Sat, 14 Sep 2024 02:28:56 +0200
Vasileios Amoiridis <vassilisamir@gmail.com> wrote:
> Depends on this: https://lore.kernel.org/linux-iio/20240823172017.9028-1-vassilisamir@gmail.com
>
This looks fine, but given outstanding comments on that patch I can't
take it quite yet.
Jonathan
> Changes in v7:
>
> [PATCH 1/4]:
> - Use 5ms instead of 5000us in comment
> - Use USEC_PER_MSEC
> - Move parenthesis to make checkpatch.pl --strict happy
>
> [PATCH 2/4]:
> - Remove interrupt description since enforcement was added.
>
> Added also review tags for patches 1,3 and ack tag for patch 2.
>
> ---
> v6: https://lore.kernel.org/linux-iio/20240912233234.45519-1-vassilisamir@gmail.com
> v5: https://lore.kernel.org/linux-iio/20240902184222.24874-1-vassilisamir@gmail.com
> v4: https://lore.kernel.org/linux-iio/20240828205128.92145-1-vassilisamir@gmail.com
> v3: https://lore.kernel.org/linux-iio/20240823181714.64545-1-vassilisamir@gmail.com
> v2: https://lore.kernel.org/linux-iio/20240725231039.614536-1-vassilisamir@gmail.com
> v1: https://lore.kernel.org/linux-iio/20240711211558.106327-1-vassilisamir@gmail.com
>
> Vasileios Amoiridis (4):
> iio: pressure: bmp280: Use sleep and forced mode for oneshot captures
> dt-bindings: iio: pressure: bmp085: Add interrupts for BMP3xx and
> BMP5xx devices
> iio: pressure: bmp280: Add data ready trigger support
> iio: pressure: bmp280: Move bmp085 interrupt to new configuration
>
> .../bindings/iio/pressure/bmp085.yaml | 22 +-
> drivers/iio/pressure/bmp280-core.c | 580 ++++++++++++++++--
> drivers/iio/pressure/bmp280-i2c.c | 4 +-
> drivers/iio/pressure/bmp280-spi.c | 4 +-
> drivers/iio/pressure/bmp280.h | 43 ++
> 5 files changed, 612 insertions(+), 41 deletions(-)
>
>
> base-commit: fec496684388685647652ab4213454fbabdab099
> prerequisite-patch-id: e4f81f31f4fbb2aa872c0c74ed4511893eee0c9a
next prev parent reply other threads:[~2024-09-14 14:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-14 0:28 [PATCH v7 0/4] pressure: bmp280: Minor cleanup and interrupt support Vasileios Amoiridis
2024-09-14 0:28 ` [PATCH v7 1/4] iio: pressure: bmp280: Use sleep and forced mode for oneshot captures Vasileios Amoiridis
2024-09-14 0:28 ` [PATCH v7 2/4] dt-bindings: iio: pressure: bmp085: Add interrupts for BMP3xx and BMP5xx devices Vasileios Amoiridis
2024-09-14 0:28 ` [PATCH v7 3/4] iio: pressure: bmp280: Add data ready trigger support Vasileios Amoiridis
2024-09-14 0:29 ` [PATCH v7 4/4] iio: pressure: bmp280: Move bmp085 interrupt to new configuration Vasileios Amoiridis
2024-09-14 14:36 ` Jonathan Cameron [this message]
2024-09-18 19:37 ` [PATCH v7 0/4] pressure: bmp280: Minor cleanup and interrupt support Vasileios Amoiridis
2024-09-28 15:00 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240914153617.3f816e5a@jic23-huawei \
--to=jic23@kernel.org \
--cc=579lpy@gmail.com \
--cc=ak@it-klinger.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ang.iglesiasg@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=vassilisamir@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox