From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <aardelean@baylibre.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, krzk+dt@kernel.org, robh@kernel.org,
lars@metafoo.de, michael.hennerich@analog.com,
gstols@baylibre.com, dlechner@baylibre.com
Subject: Re: [PATCH v6 0/8] iio: adc: ad7606: add support for AD7606C-{16,18} parts
Date: Sat, 14 Sep 2024 15:45:18 +0100 [thread overview]
Message-ID: <20240914154518.3adfbeca@jic23-huawei> (raw)
In-Reply-To: <20240913135744.152669-1-aardelean@baylibre.com>
On Fri, 13 Sep 2024 16:57:35 +0300
Alexandru Ardelean <aardelean@baylibre.com> wrote:
> The AD7606C-16 and AD7606C-18 are pretty similar with the AD7606B.
> The main difference between AD7606C-16 & AD7606C-18 is the precision in
> bits (16 vs 18).
> Because of that, some scales need to be defined for the 18-bit variants, as
> they need to be computed against 2**18 (vs 2**16 for the 16 bit-variants).
>
> Because the AD7606C-16,18 also supports bipolar & differential channels,
> for SW-mode, the default range of 10 V or ±10V should be set at probe.
> On reset, the default range (in the registers) is set to value 0x3 which
> corresponds to '±10 V single-ended range', regardless of bipolar or
> differential configuration.
>
> Aside from the scale/ranges, the AD7606C-16 is similar to the AD7606B.
>
> This changeset, does a bit of rework to the existing ad7606 driver and then
> adds support for the AD7606C-16 & AD7606C-18 parts.
Other than the issue the bot found this looks good to me.
Will let it sit on list a little while though for others to reviews,
Jonathan
prev parent reply other threads:[~2024-09-14 14:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 13:57 [PATCH v6 0/8] iio: adc: ad7606: add support for AD7606C-{16,18} parts Alexandru Ardelean
2024-09-13 13:57 ` [PATCH v6 1/8] iio: adc: ad7606: add 'bits' parameter to channels macros Alexandru Ardelean
2024-09-13 13:57 ` [PATCH v6 2/8] iio: adc: ad7606: move 'val' pointer to ad7606_scan_direct() Alexandru Ardelean
2024-09-13 13:57 ` [PATCH v6 3/8] iio: adc: ad7606: move scale_setup as function pointer on chip-info Alexandru Ardelean
2024-09-13 13:57 ` [PATCH v6 4/8] iio: adc: ad7606: wrap channel ranges & scales into struct Alexandru Ardelean
2024-09-13 13:57 ` [PATCH v6 5/8] iio: adc: ad7606: rework available attributes for SW channels Alexandru Ardelean
2024-09-13 13:57 ` [PATCH v6 6/8] dt-bindings: iio: adc: document diff-channels corner case for some ADCs Alexandru Ardelean
2024-09-13 13:57 ` [PATCH v6 7/8] dt-bindings: iio: adc: add docs for AD7606C-{16,18} parts Alexandru Ardelean
2024-09-13 13:57 ` [PATCH v6 8/8] iio: adc: ad7606: add support " Alexandru Ardelean
2024-09-13 20:30 ` kernel test robot
2024-09-14 14:41 ` Jonathan Cameron
2024-09-16 6:38 ` Alexandru Ardelean
2024-09-13 21:22 ` kernel test robot
2024-09-14 14:45 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240914154518.3adfbeca@jic23-huawei \
--to=jic23@kernel.org \
--cc=aardelean@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=gstols@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).