* [PATCH v4 1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561
2024-08-22 10:52 [PATCH v4 0/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip Ilya Orazov
@ 2024-08-22 10:52 ` Ilya Orazov
2024-08-29 18:13 ` Vinod Koul
0 siblings, 1 reply; 5+ messages in thread
From: Ilya Orazov @ 2024-08-22 10:52 UTC (permalink / raw)
To: Marc Kleine-Budde, Vincent Mailhol, Vinod Koul,
Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Aswath Govindraju
Cc: linux-can, linux-phy, devicetree, Ilya Orazov, Conor Dooley
Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode.
It is pin-compatible with TI TCAN1042 and has a compatible programming
model, therefore use ti,tcan1042 as fallback compatible.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Ilya Orazov <ilordash02@gmail.com>
---
.../devicetree/bindings/phy/ti,tcan104x-can.yaml | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
index 79dad3e89aa6..4a8c3829d85d 100644
--- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
+++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
@@ -14,10 +14,15 @@ properties:
pattern: "^can-phy"
compatible:
- enum:
- - nxp,tjr1443
- - ti,tcan1042
- - ti,tcan1043
+ oneOf:
+ - items:
+ - enum:
+ - microchip,ata6561
+ - const: ti,tcan1042
+ - enum:
+ - ti,tcan1042
+ - ti,tcan1043
+ - nxp,tjr1443
'#phy-cells':
const: 0
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v4 1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561
2024-08-22 10:52 ` [PATCH v4 1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561 Ilya Orazov
@ 2024-08-29 18:13 ` Vinod Koul
2024-08-30 8:36 ` Ilya Orazov
0 siblings, 1 reply; 5+ messages in thread
From: Vinod Koul @ 2024-08-29 18:13 UTC (permalink / raw)
To: Ilya Orazov
Cc: Marc Kleine-Budde, Vincent Mailhol, Kishon Vijay Abraham I,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Aswath Govindraju,
linux-can, linux-phy, devicetree, Conor Dooley
On 22-08-24, 13:52, Ilya Orazov wrote:
> Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode.
> It is pin-compatible with TI TCAN1042 and has a compatible programming
> model, therefore use ti,tcan1042 as fallback compatible.
>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Ilya Orazov <ilordash02@gmail.com>
> ---
> .../devicetree/bindings/phy/ti,tcan104x-can.yaml | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> index 79dad3e89aa6..4a8c3829d85d 100644
> --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> @@ -14,10 +14,15 @@ properties:
> pattern: "^can-phy"
>
> compatible:
> - enum:
> - - nxp,tjr1443
> - - ti,tcan1042
> - - ti,tcan1043
> + oneOf:
> + - items:
> + - enum:
> + - microchip,ata6561
> + - const: ti,tcan1042
> + - enum:
> + - ti,tcan1042
> + - ti,tcan1043
> + - nxp,tjr1443
No driver/dt for new compatibles?
>
> '#phy-cells':
> const: 0
> --
> 2.34.1
--
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4 1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561
2024-08-29 18:13 ` Vinod Koul
@ 2024-08-30 8:36 ` Ilya Orazov
0 siblings, 0 replies; 5+ messages in thread
From: Ilya Orazov @ 2024-08-30 8:36 UTC (permalink / raw)
To: Vinod Koul
Cc: Marc Kleine-Budde, Vincent Mailhol, Kishon Vijay Abraham I,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Aswath Govindraju,
linux-can, linux-phy, devicetree, Conor Dooley
On Thu, 29 Aug 2024 at 21:13, Vinod Koul <vkoul@kernel.org> wrote:
>
> On 22-08-24, 13:52, Ilya Orazov wrote:
> > Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode.
> > It is pin-compatible with TI TCAN1042 and has a compatible programming
> > model, therefore use ti,tcan1042 as fallback compatible.
> >
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > Signed-off-by: Ilya Orazov <ilordash02@gmail.com>
> > ---
> > .../devicetree/bindings/phy/ti,tcan104x-can.yaml | 13 +++++++++----
> > 1 file changed, 9 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> > index 79dad3e89aa6..4a8c3829d85d 100644
> > --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> > +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> > @@ -14,10 +14,15 @@ properties:
> > pattern: "^can-phy"
> >
> > compatible:
> > - enum:
> > - - nxp,tjr1443
> > - - ti,tcan1042
> > - - ti,tcan1043
> > + oneOf:
> > + - items:
> > + - enum:
> > + - microchip,ata6561
> > + - const: ti,tcan1042
> > + - enum:
> > + - ti,tcan1042
> > + - ti,tcan1043
> > + - nxp,tjr1443
>
> No driver/dt for new compatibles?
There is phy-can-transceiver.c driver that can be used also for
ata6561. I used this PHY in my own DTS. It is a popular chip, so I
decided to add ATA6561 to the kernel, as I believe it would be
beneficial.
>
> >
> > '#phy-cells':
> > const: 0
> > --
> > 2.34.1
>
> --
> ~Vinod
--
Best regards,
Ilya Orazov
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v4 0/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip
@ 2024-09-15 14:13 Ilya Orazov
2024-09-15 14:13 ` [PATCH v4 1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561 Ilya Orazov
0 siblings, 1 reply; 5+ messages in thread
From: Ilya Orazov @ 2024-09-15 14:13 UTC (permalink / raw)
To: Marc Kleine-Budde, Vincent Mailhol, Vinod Koul,
Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Aswath Govindraju
Cc: linux-can, linux-phy, devicetree, Ilya Orazov
Hi,
In this v4, I addressed Krzysztof's comments and incorporated the changelog
and tag received from Conor.
v3:
https://lore.kernel.org/r/20240808191735.1483572-1-ilordash02@gmail.com/
v2:
https://lore.kernel.org/r/20240807180210.1334724-1-ilordash02@gmail.com/
v1:
https://lore.kernel.org/r/20240718210322.37492-1-ilordash02@gmail.com/
First of all, I want to apologize for the silly mistakes in my patch
preparation. I wasn’t aware of the need to include the changelog and
received tags in new versions. This is my first patch in the kernel,
and I am very excited about it. I am eager to gain experience in working
on FOSS.
I greatly appreciate all your feedback, and I will do my best to address
and fix any issues.
Ilya Orazov (1):
dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561
.../devicetree/bindings/phy/ti,tcan104x-can.yaml | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
base-commit: 872cf28b8df9c5c3a1e71a88ee750df7c2513971
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v4 1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561
2024-09-15 14:13 [PATCH v4 0/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip Ilya Orazov
@ 2024-09-15 14:13 ` Ilya Orazov
0 siblings, 0 replies; 5+ messages in thread
From: Ilya Orazov @ 2024-09-15 14:13 UTC (permalink / raw)
To: Marc Kleine-Budde, Vincent Mailhol, Vinod Koul,
Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Aswath Govindraju
Cc: linux-can, linux-phy, devicetree, Ilya Orazov, Conor Dooley
Microchip ATA6561 is High-Speed CAN Transceiver with Standby Mode.
It is pin-compatible with TI TCAN1042 and has a compatible programming
model, therefore use ti,tcan1042 as fallback compatible.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Ilya Orazov <ilordash02@gmail.com>
---
.../devicetree/bindings/phy/ti,tcan104x-can.yaml | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
index 79dad3e89aa6..4a8c3829d85d 100644
--- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
+++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
@@ -14,10 +14,15 @@ properties:
pattern: "^can-phy"
compatible:
- enum:
- - nxp,tjr1443
- - ti,tcan1042
- - ti,tcan1043
+ oneOf:
+ - items:
+ - enum:
+ - microchip,ata6561
+ - const: ti,tcan1042
+ - enum:
+ - ti,tcan1042
+ - ti,tcan1043
+ - nxp,tjr1443
'#phy-cells':
const: 0
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-09-15 14:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-15 14:13 [PATCH v4 0/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip Ilya Orazov
2024-09-15 14:13 ` [PATCH v4 1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561 Ilya Orazov
-- strict thread matches above, loose matches on Subject: below --
2024-08-22 10:52 [PATCH v4 0/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip Ilya Orazov
2024-08-22 10:52 ` [PATCH v4 1/1] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6561 Ilya Orazov
2024-08-29 18:13 ` Vinod Koul
2024-08-30 8:36 ` Ilya Orazov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).