From: Emil Gedenryd <emil.gedenryd@axis.com>
To: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Andreas Dannenberg <dannenberg@ti.com>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>,
Emil Gedenryd <emil.gedenryd@axis.com>, <kernel@axis.com>
Subject: [PATCH v3 1/3] iio: light: opt3001: add missing full-scale range value
Date: Mon, 16 Sep 2024 16:56:37 +0200 [thread overview]
Message-ID: <20240916-add_opt3002-v3-1-984b190cd68c@axis.com> (raw)
In-Reply-To: <20240916-add_opt3002-v3-0-984b190cd68c@axis.com>
The opt3001 driver uses predetermined full-scale range values to
determine what exponent to use for event trigger threshold values.
The problem is that one of the values specified in the datasheet is
missing from the implementation. This causes larger values to be
scaled down to an incorrect exponent, effectively reducing the
maximum settable threshold value by a factor of 2.
Add missing full-scale range array value.
Fixes: 94a9b7b1809f ("iio: light: add support for TI's opt3001 light sensor")
Signed-off-by: Emil Gedenryd <emil.gedenryd@axis.com>
---
drivers/iio/light/opt3001.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/iio/light/opt3001.c b/drivers/iio/light/opt3001.c
index 887c4b776a86..176e54bb48c3 100644
--- a/drivers/iio/light/opt3001.c
+++ b/drivers/iio/light/opt3001.c
@@ -138,6 +138,10 @@ static const struct opt3001_scale opt3001_scales[] = {
.val = 20966,
.val2 = 400000,
},
+ {
+ .val = 41932,
+ .val2 = 800000,
+ },
{
.val = 83865,
.val2 = 600000,
--
2.39.2
next prev parent reply other threads:[~2024-09-16 14:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 14:56 [PATCH v3 0/3] iio: light: opt3001: add support for TI's opt3002 light sensor Emil Gedenryd
2024-09-16 14:56 ` Emil Gedenryd [this message]
2024-09-28 15:57 ` [PATCH v3 1/3] iio: light: opt3001: add missing full-scale range value Jonathan Cameron
2024-09-30 7:54 ` Emil Gedenryd
2024-09-16 14:56 ` [PATCH v3 2/3] dt-bindings: iio: light: opt3001: add compatible for opt3002 Emil Gedenryd
2024-09-16 15:24 ` Conor Dooley
2024-09-17 7:06 ` Emil Gedenryd
2024-09-16 14:56 ` [PATCH v3 3/3] iio: light: opt3001: add support for TI's opt3002 light sensor Emil Gedenryd
2024-09-28 16:05 ` Jonathan Cameron
2024-09-30 7:53 ` Emil Gedenryd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240916-add_opt3002-v3-1-984b190cd68c@axis.com \
--to=emil.gedenryd@axis.com \
--cc=conor+dt@kernel.org \
--cc=dannenberg@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kernel@axis.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).