[PATCH 0/2] Add touchscreen and TMP451 tempsensor nodes to Google Pixel C (tegra210-smaug) Device Tree

[PATCH 0/2] Add touchscreen and TMP451 tempsensor nodes to Google Pixel C (tegra210-smaug) Device Tree

[Jasper Korten via B4 Relay]

Information to get these working was gained from downstream DTS.
Link: https://android.googlesource.com/kernel/tegra/+/refs/heads/android-tegra-dragon-3.18-oreo-m8/arch/arm64/boot/dts/tegra/tegra210-smaug.dtsi

Both were missing upstream and easy to add:
- It uses a RMI4 HID-over-I2C compatible touchscreen.
- TMP451 is located close to eMMC according to iFixit's teardown.
  Link: https://www.ifixit.com/Teardown/Google+Pixel+C+Teardown/62277#s290806

This is the first time I've ever submitted patches upstream myself.
If there's anything I've missed or could do better in a new rev,
please let me know!

Signed-off-by: Jasper Korten <jja2000@gmail.com>
---
Jasper Korten (2):
      arm64: dts: nvidia: tegra210-smaug: Add touchscreen node
      arm64: dts: nvidia: tegra210-smaug: Add TMP451 temperature sensor node

 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
---
base-commit: da3ea35007d0af457a0afc87e84fddaebc4e0b63
change-id: 20240915-touch-temp-c64b68961aee

Best regards,
-- 
Jasper Korten <jja2000@gmail.com>

[PATCH 1/2] arm64: dts: nvidia: tegra210-smaug: Add touchscreen node

[Jasper Korten via B4 Relay]

From: Jasper Korten <jja2000@gmail.com>

The Google Pixel C contains a RMI4 HID over I2C touchscreen.
Add a DT node for the touchscreen.

Information gathered from downstream tree.
Link: https://android.googlesource.com/kernel/tegra/+/refs/heads/android-tegra-dragon-3.18-oreo-m8/arch/arm64/boot/dts/tegra/tegra210-smaug.dtsi#542

Signed-off-by: Jasper Korten <jja2000@gmail.com>
---
 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
index 2e5b6b2c1f56..6f77540fd397 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
@@ -1362,6 +1362,19 @@ bluetooth {
 		};
 	};
 
+	i2c@7000c000 {
+		status = "okay";
+		clock-frequency = <1000000>;
+
+		touchscreen: i2c-hid-dev@20 {
+				compatible = "hid-over-i2c";
+				reg = <0x20>;
+				hid-descr-addr = <0x0020>;
+				interrupt-parent = <&gpio>;
+				interrupts = <TEGRA_GPIO(X, 1) IRQ_TYPE_EDGE_FALLING>;
+		};
+	};
+
 	i2c@7000c400 {
 		status = "okay";
 		clock-frequency = <1000000>;

-- 
2.46.0

[PATCH 2/2] arm64: dts: nvidia: tegra210-smaug: Add TMP451 temperature sensor node

[Jasper Korten via B4 Relay]

From: Jasper Korten <jja2000@gmail.com>

The Google Pixel C contains a TI TMP451 temperature sensor.
Add a DT node for temperature sensor.

Information gathered from downstream tree.
Link: https://android.googlesource.com/kernel/tegra/+/refs/heads/android-tegra-dragon-3.18-oreo-m8/arch/arm64/boot/dts/tegra/tegra210-smaug.dtsi#1000

Signed-off-by: Jasper Korten <jja2000@gmail.com>
---
 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
index 6f77540fd397..c724cb4d5ad8 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
@@ -1732,6 +1732,15 @@ audio-codec@2d {
 			#gpio-cells = <2>;
 			status = "okay";
 		};
+
+		tmp451: temperature-sensor@4c {
+			compatible = "ti,tmp451";
+			reg = <0x4c>;
+			interrupt-parent = <&gpio>;
+			interrupts = <TEGRA_GPIO(X, 4) IRQ_TYPE_LEVEL_LOW>;
+			vcc-supply = <&pp1800>;
+			#thermal-sensor-cells = <1>;
+		};
 	};
 
 	pmc@7000e400 {

-- 
2.46.0

Re: [PATCH 0/2] Add touchscreen and TMP451 tempsensor nodes to Google Pixel C (tegra210-smaug) Device Tree

[Diogo Ivo]

On Mon, Sep 16, 2024 at 12:48:12AM GMT, Jasper Korten via B4 Relay wrote:
> Information to get these working was gained from downstream DTS.
> Link: https://android.googlesource.com/kernel/tegra/+/refs/heads/android-tegra-dragon-3.18-oreo-m8/arch/arm64/boot/dts/tegra/tegra210-smaug.dtsi
> 
> Both were missing upstream and easy to add:
> - It uses a RMI4 HID-over-I2C compatible touchscreen.
> - TMP451 is located close to eMMC according to iFixit's teardown.
>   Link: https://www.ifixit.com/Teardown/Google+Pixel+C+Teardown/62277#s290806
> 
> This is the first time I've ever submitted patches upstream myself.
> If there's anything I've missed or could do better in a new rev,
> please let me know!
> 
> Signed-off-by: Jasper Korten <jja2000@gmail.com>

For both patches:

Tested-by: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>

Thanks!

Re: [PATCH 0/2] Add touchscreen and TMP451 tempsensor nodes to Google Pixel C (tegra210-smaug) Device Tree

[Thierry Reding]

From: Thierry Reding <treding@nvidia.com>


On Mon, 16 Sep 2024 00:48:12 +0200, Jasper Korten wrote:
> Information to get these working was gained from downstream DTS.
> Link: https://android.googlesource.com/kernel/tegra/+/refs/heads/android-tegra-dragon-3.18-oreo-m8/arch/arm64/boot/dts/tegra/tegra210-smaug.dtsi
> 
> Both were missing upstream and easy to add:
> - It uses a RMI4 HID-over-I2C compatible touchscreen.
> - TMP451 is located close to eMMC according to iFixit's teardown.
>   Link: https://www.ifixit.com/Teardown/Google+Pixel+C+Teardown/62277#s290806
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: nvidia: tegra210-smaug: Add touchscreen node
      commit: c8d63aa0f14adce3d01a3b776b5ea6a33620891d
[2/2] arm64: dts: nvidia: tegra210-smaug: Add TMP451 temperature sensor node
      commit: b219fe91d3140cddb53538c169f7cb2f6f05e75a

Best regards,
-- 
Thierry Reding <treding@nvidia.com>