Re: [PATCH] arm64: dts: allwinner: h5: NanoPi NEO Plus2: Add disable-wp to mmc0

[Andre Przywara <andre.przywara@arm.com>]

On Tue, 17 Sep 2024 17:51:11 +0200
Kryštof Černý <cleverline1mc@gmail.com> wrote:

Hi Kryštof,

(putting back the lists, please keep the discussion public, for everyone's
benefit and for having this archived)

> 16. září 2024 16:08:09 SELČ, Andre Przywara <andre.przywara@arm.com> napsal:
> >On Sat, 14 Sep 2024 12:07:00 +0200
> >Kryštof Černý <cleverline1mc@gmail.com> wrote:
> >  
> >> The board does not have wp pin/switch for micro SD card (mmc0).  
> >
> >That is true, but for *every* microSD card. So I wonder if we should add
> >this property to all of the boards? I believe none of the arm64 boards have
> >full size SD card slots?  
> 
> I believe this would be a correct thing to do for micro SD cards, few boards do have this property set already, but most don't. However, I am not 100% certain (I have had a lot of SBCs, in my hands, but definitely not all of them), so I added it for this board only. So do you think it should be added for other boards too, or every user should add it for their SBC on their own?

Yes, I would like you to add this for the other arm64 boards, too.
I appreciate your concerns about not knowing, but we can help out here.
Maybe you can quickly go over the wiki and check each board's picture for
having a microSD slot, just to be on the safe side. But I am pretty sure
that full-size SD slots were only used on the first generation (A10)
boards, and any arm64 board always uses micro-SD slots. I would double
check this on my side during review.

If we would wait for individual board owners to submit patches, we would
wait forever. So thank you for spotting this, and sending a fix, but it
would reduce churn and improve the situation for everyone if you would
cover the other boards as well.

Thanks!
Andre