From: Rob Herring <robh@kernel.org>
To: Mao Jinlong <quic_jinlmao@quicinc.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@arm.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: arm: coresight: Update the pattern of ete node name
Date: Wed, 18 Sep 2024 10:58:45 -0500 [thread overview]
Message-ID: <20240918155845.GA1629400-robh@kernel.org> (raw)
In-Reply-To: <20240913092430.31569-2-quic_jinlmao@quicinc.com>
On Fri, Sep 13, 2024 at 02:24:28AM -0700, Mao Jinlong wrote:
> The device full name is embedded trace extension. There is no good fit
> in generic names list for the embedded trace extension. ETE is abbreviation
> of embedded trace extension and the number is the CPU number that ete is
> associated.
It looks like you've just changed things for all the existing users
which would not be okay. However, it looks like there aren't any in
tree, so the change is fine, but you need to mention this.
>
> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
> ---
> .../bindings/arm/arm,embedded-trace-extension.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
> index f725e6940993..0a88e14e7db3 100644
> --- a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
> +++ b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
> @@ -23,7 +23,7 @@ description: |
>
> properties:
> $nodename:
> - pattern: "^ete([0-9a-f]+)$"
> + pattern: "^ete-[0-9]+$"
> compatible:
> items:
> - const: arm,embedded-trace-extension
> @@ -55,13 +55,13 @@ examples:
>
> # An ETE node without legacy CoreSight connections
> - |
> - ete0 {
> + ete-0 {
> compatible = "arm,embedded-trace-extension";
> cpu = <&cpu_0>;
> };
> # An ETE node with legacy CoreSight connections
> - |
> - ete1 {
> + ete-1 {
> compatible = "arm,embedded-trace-extension";
> cpu = <&cpu_1>;
>
> --
> 2.46.0
>
next prev parent reply other threads:[~2024-09-18 15:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 9:24 [PATCH v4 0/2] arm64: dts: qcom: sm8450: Add coresight nodes Mao Jinlong
2024-09-13 9:24 ` [PATCH v4 1/2] dt-bindings: arm: coresight: Update the pattern of ete node name Mao Jinlong
2024-09-16 9:02 ` Krzysztof Kozlowski
2024-09-18 15:58 ` Rob Herring [this message]
2024-09-13 9:24 ` [PATCH v4 2/2] arm64: dts: qcom: sm8450: Add coresight nodes Mao Jinlong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240918155845.GA1629400-robh@kernel.org \
--to=robh@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@arm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=quic_jinlmao@quicinc.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).