From: Laurentiu Mihalcea <laurentiumihalcea111@gmail.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Daniel Baluta <daniel.baluta@nxp.com>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
Iuliana Prodan <iuliana.prodan@nxp.com>
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/5] dt-bindings: dsp: fix power domain count
Date: Wed, 18 Sep 2024 14:21:13 -0400 [thread overview]
Message-ID: <20240918182117.86221-2-laurentiumihalcea111@gmail.com> (raw)
In-Reply-To: <20240918182117.86221-1-laurentiumihalcea111@gmail.com>
From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Per the current binding, QM/QXP DSPs are supposed
to have 4 power domains, while the rest just 1.
For QM/QXP, the 4 power domains are: DSP, DSP_RAM,
MU13A, MU13B.
First off, drop MU13A from the count. This is attached
to the platform device of lsio_mu13. This decreases the
count to 3.
Secondly, drop DSP and DSP_RAM from the count for QXP.
These are attached to the platform devices of the lpcgs
(used as clock providers for the DSP).
With this in mind, the number of required power domains for
QXP is 1 (MU13B), while for QM it's 3 (MU13B, DSP, DSP_RAM).
Additionally, two extra power domains may be required in the
case of QM/QXP DSPs. These are IRQSTR_DSP and MU2A. For the nodes
using the "-hifi4" compatibles these PDs are optional, while for
nodes using the "-dsp" compatibles these are mandatory.
These changes reflect all of this information.
Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
---
.../devicetree/bindings/dsp/fsl,dsp.yaml | 62 +++++++++++++++----
1 file changed, 49 insertions(+), 13 deletions(-)
diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
index 9af40da5688e..e2f016af1048 100644
--- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
+++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
@@ -51,8 +51,6 @@ properties:
description:
List of phandle and PM domain specifier as documented in
Documentation/devicetree/bindings/power/power_domain.txt
- minItems: 1
- maxItems: 4
mboxes:
description:
@@ -97,16 +95,55 @@ allOf:
properties:
compatible:
contains:
- enum:
- - fsl,imx8qxp-dsp
- - fsl,imx8qm-dsp
- - fsl,imx8qxp-hifi4
- - fsl,imx8qm-hifi4
+ const: fsl,imx8qxp-hifi4
then:
properties:
power-domains:
- minItems: 4
- else:
+ maxItems: 3
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: fsl,imx8qxp-dsp
+ then:
+ properties:
+ power-domains:
+ minItems: 3
+ maxItems: 3
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: fsl,imx8qm-dsp
+ then:
+ properties:
+ power-domains:
+ minItems: 5
+ maxItems: 5
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: fsl,imx8qm-hifi4
+ then:
+ properties:
+ power-domains:
+ minItems: 3
+ maxItems: 5
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - fsl,imx8mp-dsp
+ - fsl,imx8mp-hifi4
+ - fsl,imx8ulp-dsp
+ - fsl,imx8ulp-hifi4
+ then:
properties:
power-domains:
maxItems: 1
@@ -157,10 +194,9 @@ examples:
<&adma_lpcg IMX_ADMA_LPCG_OCRAM_IPG_CLK>,
<&adma_lpcg IMX_ADMA_LPCG_DSP_CORE_CLK>;
clock-names = "ipg", "ocram", "core";
- power-domains = <&pd IMX_SC_R_MU_13A>,
- <&pd IMX_SC_R_MU_13B>,
- <&pd IMX_SC_R_DSP>,
- <&pd IMX_SC_R_DSP_RAM>;
+ power-domains = <&pd IMX_SC_R_MU_13B>,
+ <&pd IMX_SC_R_IRQSTR_DSP>,
+ <&pd IMX_SC_R_MU_2A>;
mbox-names = "txdb0", "txdb1", "rxdb0", "rxdb1";
mboxes = <&lsio_mu13 2 0>, <&lsio_mu13 2 1>, <&lsio_mu13 3 0>, <&lsio_mu13 3 1>;
memory-region = <&dsp_reserved>;
--
2.34.1
next prev parent reply other threads:[~2024-09-18 18:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 18:21 [PATCH 0/5] configure imx8 dsp DT node for rproc usage Laurentiu Mihalcea
2024-09-18 18:21 ` Laurentiu Mihalcea [this message]
2024-09-18 18:49 ` [PATCH 1/5] dt-bindings: dsp: fix power domain count Frank Li
2024-09-22 23:03 ` Laurentiu Mihalcea
2024-09-18 19:36 ` Rob Herring (Arm)
2024-09-18 20:37 ` Rob Herring
2024-09-18 18:21 ` [PATCH 2/5] arm64: dts: imx8qxp: configure dsp node for rproc usage Laurentiu Mihalcea
2024-09-18 19:02 ` Frank Li
2024-09-24 11:01 ` Daniel Baluta
2024-09-18 18:21 ` [PATCH 3/5] arm64: dts: imx8qm: drop dsp node from audio_subsys bus Laurentiu Mihalcea
2024-09-18 18:54 ` Frank Li
2024-09-18 18:21 ` [PATCH 4/5] arm64: dts: imx8qm: add node for VPU dsp Laurentiu Mihalcea
2024-09-18 18:57 ` Frank Li
2024-09-22 23:19 ` Laurentiu Mihalcea
2024-09-18 18:21 ` [PATCH 5/5] arm64: dts: imx8qm: enable dsp node for rproc usage Laurentiu Mihalcea
2024-09-18 19:00 ` Frank Li
2024-09-22 23:15 ` Laurentiu Mihalcea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240918182117.86221-2-laurentiumihalcea111@gmail.com \
--to=laurentiumihalcea111@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=iuliana.prodan@nxp.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).