Devicetree
 help / color / mirror / Atom feed
From: Dhruva Gole <d-gole@ti.com>
To: Andrew Davis <afd@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	<linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>
Subject: Re: [PATCH V4 5/6] arm64: dts: ti: k3-am62: use opp_efuse_table for opp-table syscon
Date: Fri, 20 Sep 2024 16:07:59 +0530	[thread overview]
Message-ID: <20240920103759.vypnmro6imsn52ge@lcpd911> (raw)
In-Reply-To: <5a54f481-efaa-4719-ac38-b328a6c67762@ti.com>

On Sep 19, 2024 at 11:40:31 -0500, Andrew Davis wrote:
> On 9/19/24 3:28 AM, Dhruva Gole wrote:
> > Add another entry in the wkup_conf for the syscon node, and then use
> > that for the syscon in opp-table.
> > 
> > Marking entire wkup_conf as "syscon", "simple-mfd" is wrong and needs to
> > be addressed similar to how other child-nodes in wkup_conf are implemented
> > in the same file.
> > 
> > Signed-off-by: Dhruva Gole <d-gole@ti.com>
> > ---
> > 
> > **DEPENDS ON:** PATCH 6/6: cpufreq: ti-cpufreq: Update the efuse/rev offsets
> > 
> > Link to v1: https://lore.kernel.org/all/20240902093222.2828345-2-d-gole@ti.com/
> > No changes, just combined it as part of Bryan's AM62A and AM62P series
> > and sending it all together.
> > 
> > ---
> >   arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 7 ++++++-
> >   arch/arm64/boot/dts/ti/k3-am625.dtsi       | 2 +-
> >   2 files changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
> > index e0afafd532a5..b2b65e31c7cf 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi
> > @@ -10,7 +10,7 @@
> >   &cbass_wakeup {
> >   	wkup_conf: syscon@43000000 {
> >   		bootph-all;
> > -		compatible = "syscon", "simple-mfd";
> > +		compatible = "simple-bus";
> 
> This can be done in a separate patch after this one. You'll also
> want to change the syscon@43000000 to bus@43000000, and drop the
> "reg = <>;" line at the same time.
> 
> Andrew
> 

Sure Andrew, thanks for pointing this out. I will do this in a separate
patch.

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated

  reply	other threads:[~2024-09-20 10:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-19  8:28 [PATCH V4 0/6] ti: k3-am62{a,p}x-sk: add opp frequencies Dhruva Gole
2024-09-19  8:28 ` [PATCH V4 1/6] arm64: dts: ti: k3-am62a: " Dhruva Gole
2024-09-19  8:28 ` [PATCH V4 2/6] arm64: dts: ti: k3-am62a7-sk: add 1.4ghz opp entry Dhruva Gole
2024-09-19  8:28 ` [PATCH V4 3/6] arm64: dts: ti: k3-am62p: add opp frequencies Dhruva Gole
2024-09-19  8:28 ` [PATCH V4 4/6] arm64: dts: ti: k3-am62p5-sk: add 1.4ghz opp entry Dhruva Gole
2024-09-19  8:28 ` [PATCH V4 5/6] arm64: dts: ti: k3-am62: use opp_efuse_table for opp-table syscon Dhruva Gole
2024-09-19 16:40   ` Andrew Davis
2024-09-20 10:37     ` Dhruva Gole [this message]
2024-09-19  8:28 ` [PATCH V4 6/6] cpufreq: ti-cpufreq: Update efuse/rev offsets in AM62 family Dhruva Gole
2024-10-01  6:29   ` Viresh Kumar
2024-10-01  7:52     ` Dhruva Gole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240920103759.vypnmro6imsn52ge@lcpd911 \
    --to=d-gole@ti.com \
    --cc=afd@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox