From: Igor Prusov <ivprusov@salutedevices.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, "Rob Herring" <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Philipp Zabel <p.zabel@pengutronix.de>, <prusovigor@gmail.com>,
<kernel@salutedevices.com>, <linux-sound@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/6] ASoC: dt-bindings: Add bindings for NeoFidelity NTP8835
Date: Fri, 20 Sep 2024 20:42:33 +0300 [thread overview]
Message-ID: <20240920174233.hisfcfb6pgtqzyfp@pc> (raw)
In-Reply-To: <4cb531b8-5ea1-437f-bdb0-a49f7799af47@kernel.org>
On Wed, Jul 10, 2024 at 12:24:33PM +0200, Krzysztof Kozlowski wrote:
> On 09/07/2024 19:28, Igor Prusov wrote:
> > Add dt-bindings for NeoFidelity NTP8835C/NTP8835C Amplifiers
> >
> > Signed-off-by: Igor Prusov <ivprusov@salutedevices.com>
> > ---
> > .../bindings/sound/neofidelity,ntp8835.yaml | 65 +++++++++++++++++++
>
> No need for new schema. Just put it - after testing - into previous
> bindings file.
I am going to add some clocks in next version and there are some
differences between amplifiers. 8835 uses separate master clock, 8918 is
clocked by BCLK. Is it still better to use same schema with anyOf, or
keep them in different files?
>
> Best regards,
> Krzysztof
>
--
Best Regards,
Igor Prusov
next prev parent reply other threads:[~2024-09-20 17:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 17:28 [PATCH 0/6] ASoC: Add NTP8918 and NTP8835 codecs support Igor Prusov
2024-07-09 17:28 ` [PATCH 1/6] dt-bindings: vendor-prefixes: Add NeoFidelity, Inc Igor Prusov
2024-07-10 10:21 ` Krzysztof Kozlowski
2024-07-09 17:28 ` [PATCH 2/6] ASoC: codecs: Add NeoFidelity Firmware helpers Igor Prusov
2024-07-09 17:28 ` [PATCH 3/6] ASoC: dt-bindings: Add bindings for NeoFidelity NTP8918 Igor Prusov
2024-07-09 21:22 ` Rob Herring (Arm)
2024-07-10 10:23 ` Krzysztof Kozlowski
2024-07-09 17:28 ` [PATCH 4/6] ASoC: codecs: Add NeoFidelity NTP8918 codec Igor Prusov
2024-07-11 3:04 ` kernel test robot
2024-07-12 21:18 ` kernel test robot
2024-07-09 17:28 ` [PATCH 5/6] ASoC: dt-bindings: Add bindings for NeoFidelity NTP8835 Igor Prusov
2024-07-09 21:22 ` Rob Herring (Arm)
2024-07-10 10:24 ` Krzysztof Kozlowski
2024-09-20 17:42 ` Igor Prusov [this message]
2024-09-21 18:05 ` Krzysztof Kozlowski
2024-07-09 17:28 ` [PATCH 6/6] ASoC: codecs: Add NeoFidelity NTP8835 codec Igor Prusov
2024-07-10 10:31 ` Krzysztof Kozlowski
2024-09-20 17:33 ` Igor Prusov
2024-09-21 18:09 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240920174233.hisfcfb6pgtqzyfp@pc \
--to=ivprusov@salutedevices.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@salutedevices.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=perex@perex.cz \
--cc=prusovigor@gmail.com \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).