From: Rob Herring <robh@kernel.org>
To: Amit Sunil Dhamne <amitsd@google.com>
Cc: gregkh@linuxfoundation.org, dmitry.baryshkov@linaro.org,
heikki.krogerus@linux.intel.com, badhri@google.com,
kyletso@google.com, rdbabiera@google.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [RFC v2 1/2] dt-bindings: connector: Add properties to define time values
Date: Fri, 20 Sep 2024 19:56:16 -0500 [thread overview]
Message-ID: <20240921005616.GA185456-robh@kernel.org> (raw)
In-Reply-To: <20240919075120.328469-2-amitsd@google.com>
On Thu, Sep 19, 2024 at 12:51:13AM -0700, Amit Sunil Dhamne wrote:
> This commit adds the following properties:
> * sink-wait-cap-time-ms
> * ps-source-off-time-ms
> * cc-debounce-time-ms
>
> This is to enable setting of platform/board specific timer values as
> these timers have a range of acceptable values.
What's acceptable? Put that in constraints for the properties.
>
> Signed-off-by: Amit Sunil Dhamne <amitsd@google.com>
> ---
> .../bindings/connector/usb-connector.yaml | 32 ++++++++++++++++++-
> 1 file changed, 31 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> index fb216ce68bb3..5efa4ea3c41c 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> @@ -253,6 +253,33 @@ properties:
>
> additionalProperties: false
>
> + sink-wait-cap-time-ms:
> + description: Represents the max time in ms that USB Type-C port (in sink
> + role) should wait for the port partner (source role) to send source caps.
> + SinkWaitCap timer starts when port in sink role attaches to the source.
> + This timer will stop when sink receives PD source cap advertisement before
> + timeout in which case it'll move to capability negotiation stage. A
> + timeout leads to a hard reset message by the port. If no value is set for
> + this property then the driver assumes a default value of PD_T_SINK_WAIT_CAP
> + (defined in include/linux/usb/pd.h).
Express default as "default: N". Sorry, defines don't work here.
next prev parent reply other threads:[~2024-09-21 0:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 7:51 [RFC v2 0/2] Add support for time DT property in TCPM Amit Sunil Dhamne
2024-09-19 7:51 ` [RFC v2 1/2] dt-bindings: connector: Add properties to define time values Amit Sunil Dhamne
2024-09-21 0:56 ` Rob Herring [this message]
2024-09-19 7:51 ` [RFC v2 2/2] usb: typec: tcpm: Add support for parsing time dt properties Amit Sunil Dhamne
2024-09-19 8:56 ` Dmitry Baryshkov
2024-09-19 22:08 ` Amit Sunil Dhamne
2024-09-19 13:32 ` Heikki Krogerus
2024-09-19 22:15 ` Amit Sunil Dhamne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240921005616.GA185456-robh@kernel.org \
--to=robh@kernel.org \
--cc=amitsd@google.com \
--cc=badhri@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rdbabiera@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).