From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Rishi Gupta <gupt21@gmail.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Javier Carrasco <javier.carrasco.cruz@gmail.com>
Subject: [PATCH v2 07/10] iio: light: veml6030: drop processed info for white channel
Date: Mon, 23 Sep 2024 00:17:55 +0200 [thread overview]
Message-ID: <20240923-veml6035-v2-7-58c72a0df31c@gmail.com> (raw)
In-Reply-To: <20240923-veml6035-v2-0-58c72a0df31c@gmail.com>
The resolution of the WHITE channel is not provided by the manufacturer,
neither in the datasheet nor in the application note (even their
proprietary application only processes the ALS channel, giving raw
values for WHITE).
The current implementation assumes that both resolutions are identical,
which is extremely unlikely, especially for photodiodes with different
spectral responses.
Drop the processed information as it is meaningless.
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
drivers/iio/light/veml6030.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/iio/light/veml6030.c b/drivers/iio/light/veml6030.c
index a3190fab3add..861bdf2edd4d 100644
--- a/drivers/iio/light/veml6030.c
+++ b/drivers/iio/light/veml6030.c
@@ -209,8 +209,7 @@ static const struct iio_chan_spec veml6030_channels[] = {
.channel = CH_WHITE,
.modified = 1,
.channel2 = IIO_MOD_LIGHT_BOTH,
- .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
- BIT(IIO_CHAN_INFO_PROCESSED),
+ .info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
.info_mask_shared_by_all = BIT(IIO_CHAN_INFO_INT_TIME) |
BIT(IIO_CHAN_INFO_SCALE),
.info_mask_shared_by_all_available = BIT(IIO_CHAN_INFO_INT_TIME) |
@@ -549,11 +548,6 @@ static int veml6030_read_raw(struct iio_dev *indio_dev,
dev_err(dev, "can't read white data %d\n", ret);
return ret;
}
- if (mask == IIO_CHAN_INFO_PROCESSED) {
- *val = (reg * data->cur_resolution) / 10000;
- *val2 = (reg * data->cur_resolution) % 10000;
- return IIO_VAL_INT_PLUS_MICRO;
- }
*val = reg;
return IIO_VAL_INT;
default:
--
2.43.0
next prev parent reply other threads:[~2024-09-22 22:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-22 22:17 [PATCH v2 00/10] iio: light: veml6030: fix issues and add support for veml6035 Javier Carrasco
2024-09-22 22:17 ` [PATCH v2 01/10] iio: light: veml6030: fix ALS sensor resolution Javier Carrasco
2024-09-28 16:12 ` Jonathan Cameron
2024-09-22 22:17 ` [PATCH v2 02/10] iio: light: veml6030: add set up delay after any power on sequence Javier Carrasco
2024-09-28 16:13 ` Jonathan Cameron
2024-09-22 22:17 ` [PATCH v2 03/10] iio: light: veml6030: use dev_err_probe() Javier Carrasco
2024-09-22 22:17 ` [PATCH v2 04/10] dt-bindings: iio: light: veml6030: add vdd-supply property Javier Carrasco
2024-09-24 10:06 ` Krzysztof Kozlowski
2024-09-27 18:02 ` Javier Carrasco
2024-09-22 22:17 ` [PATCH v2 05/10] iio: light: veml6030: add support for a regulator Javier Carrasco
2024-09-22 22:17 ` [PATCH v2 06/10] iio: light: veml6030: use read_avail() for available attributes Javier Carrasco
2024-09-28 16:19 ` Jonathan Cameron
2024-09-29 18:45 ` Javier Carrasco
2024-09-30 8:45 ` Jonathan Cameron
2024-09-22 22:17 ` Javier Carrasco [this message]
2024-09-28 16:20 ` [PATCH v2 07/10] iio: light: veml6030: drop processed info for white channel Jonathan Cameron
2024-09-22 22:17 ` [PATCH v2 08/10] iio: light: veml6030: power off device in probe error paths Javier Carrasco
2024-09-28 16:22 ` Jonathan Cameron
2024-09-22 22:17 ` [PATCH v2 09/10] dt-bindings: iio: light: veml6030: add veml6035 Javier Carrasco
2024-09-22 22:17 ` [PATCH v2 10/10] iio: light: veml6030: add support for veml6035 Javier Carrasco
2024-09-28 16:25 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240923-veml6035-v2-7-58c72a0df31c@gmail.com \
--to=javier.carrasco.cruz@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gupt21@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).