From: Conor Dooley <conor@kernel.org>
To: "Rafał Miłecki" <rafal@milecki.pl>
Cc: Sandie Cao <sandie.cao@deepcomputing.io>,
Emil Renner Berthing <kernel@esmil.dk>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Heiko Stuebner <heiko.stuebner@cherry.de>,
Neil Armstrong <neil.armstrong@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Michael Zhu <michael.zhu@starfivetech.com>,
Drew Fustini <drew@beagleboard.org>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dhs@frame.work, ams@frame.work,
gregkh@linuxfoundation.org, yuning.liang@deepcomputing.io,
huiming.qiu@deepcomputing.io
Subject: Re: [patch v2 3/3] riscv: dts: starfive: add framework dts
Date: Tue, 24 Sep 2024 17:26:18 +0100 [thread overview]
Message-ID: <20240924-ended-tactics-b2e779875a76@spud> (raw)
In-Reply-To: <75d4f0395187f7950e0450a91fbe087d@milecki.pl>
[-- Attachment #1: Type: text/plain, Size: 982 bytes --]
On Tue, Sep 24, 2024 at 11:55:44AM +0200, Rafał Miłecki wrote:
> On 2024-09-24 10:06, Sandie Cao wrote:
> > diff --git a/arch/riscv/boot/dts/starfive/jh7110-framework.dts
> > b/arch/riscv/boot/dts/starfive/jh7110-framework.dts
> > new file mode 100644
> > index 000000000000..ff12c24ebab3
> > --- /dev/null
> > +++ b/arch/riscv/boot/dts/starfive/jh7110-framework.dts
> > @@ -0,0 +1,34 @@
> > +// SPDX-License-Identifier: GPL-2.0 OR MIT
> > +/*
> > + * Copyright (C) 2022 StarFive Technology Co., Ltd.
> > + * Copyright (C) 2022 Emil Renner Berthing <kernel@esmil.dk>
> > + */
> > +
> > +/dts-v1/;
> > +#include "jh7110-common.dtsi"
> > +
> > +/ {
> > + model = "Framework FRANME0000";
> > + compatible = "deepcomputing,fm7110", "starfive,jh7110";
> > +};
>
> Nitpicking: property "compatible" should go first.
>
> See Documentation/devicetree/bindings/dts-coding-style.rst
I think "model" usually goes before compatible, I wouldn't change it
here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-09-24 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 8:06 [patch v2 3/3] riscv: dts: starfive: add framework dts Sandie Cao
2024-09-24 8:24 ` Krzysztof Kozlowski
[not found] ` <407ce3d77416bb2522b7906b0df3d5adf02c27ee.5065befe.6789.4275.a840.52c113c23eb9@feishu.cn>
2024-09-24 18:40 ` Krzysztof Kozlowski
2024-09-24 9:55 ` Rafał Miłecki
2024-09-24 16:26 ` Conor Dooley [this message]
2024-09-25 1:56 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240924-ended-tactics-b2e779875a76@spud \
--to=conor@kernel.org \
--cc=ams@frame.work \
--cc=aou@eecs.berkeley.edu \
--cc=devicetree@vger.kernel.org \
--cc=dhs@frame.work \
--cc=drew@beagleboard.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.stuebner@cherry.de \
--cc=huiming.qiu@deepcomputing.io \
--cc=kernel@esmil.dk \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=michael.zhu@starfivetech.com \
--cc=neil.armstrong@linaro.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=sandie.cao@deepcomputing.io \
--cc=yuning.liang@deepcomputing.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox