* [PATCH 1/2] dt-bindings: arm: mediatek: Add MT8186 Chinchou/Chinchou360 Chromebooks
@ 2024-09-25 8:03 Albert Jakieła
2024-09-25 8:03 ` [PATCH 2/2] arm64: dts: mediate: Introduce " Albert Jakieła
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Albert Jakieła @ 2024-09-25 8:03 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, matthias.bgg, angelogioacchino.delregno,
wenst, rafal, hsinyi, nfraprado, macpaul.lin, sean.wang
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
Albert Jakieła
Add entries for MT8186 based Chinchou/Chinchou360 Chromebooks.
These two are clamshell or convertible with touchscreen, stylus
and extra buttons.
Signed-off-by: Albert Jakieła <jakiela@google.com>
---
.../devicetree/bindings/arm/mediatek.yaml | 23 +++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index 1d4bb50fcd8d..110149f5d748 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -239,6 +239,29 @@ properties:
- enum:
- mediatek,mt8183-pumpkin
- const: mediatek,mt8183
+ - description: Google Chinchou360 (Asus Chromebook CZ11 Flip CZ1104F)
+ items:
+ - const: google,chinchou-sku16
+ - const: google,chinchou-sku18
+ - const: google,chinchou-sku19
+ - const: google,chinchou-sku21
+ - const: google,chinchou-sku2147483647
+ - const: mediatek,mt8186
+ - description: Google Chinchou (Asus Chromebook CZ12 Flip CZ1204C)
+ items:
+ - const: google,chinchou-sku0
+ - const: google,chinchou-sku1
+ - const: google,chinchou-sku2
+ - const: google,chinchou-sku3
+ - const: google,chinchou-sku4
+ - const: google,chinchou-sku5
+ - const: google,chinchou-sku6
+ - const: google,chinchou-sku7
+ - const: google,chinchou-sku17
+ - const: google,chinchou-sku22
+ - const: google,chinchou-sku23
+ - const: google,chinchou
+ - const: mediatek,mt8186
- description: Google Magneton (Lenovo IdeaPad Slim 3 Chromebook (14M868))
items:
- const: google,steelix-sku393219
--
2.46.0.792.g87dc391469-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dts: mediate: Introduce MT8186 Chinchou/Chinchou360 Chromebooks
2024-09-25 8:03 [PATCH 1/2] dt-bindings: arm: mediatek: Add MT8186 Chinchou/Chinchou360 Chromebooks Albert Jakieła
@ 2024-09-25 8:03 ` Albert Jakieła
2024-09-26 9:27 ` AngeloGioacchino Del Regno
2024-09-25 14:17 ` [PATCH 1/2] dt-bindings: arm: mediatek: Add " Krzysztof Kozlowski
2024-09-25 14:36 ` Rob Herring (Arm)
2 siblings, 1 reply; 6+ messages in thread
From: Albert Jakieła @ 2024-09-25 8:03 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt, matthias.bgg, angelogioacchino.delregno,
wenst, rafal, hsinyi, nfraprado, macpaul.lin, sean.wang
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
Albert Jakieła
The MT8186 Chinchou/Chinchou360, also known as the Asus Chromebook
CZ12/CZ11 Flip, is a clamshell or convertible device with touchscreen,
stylus and extra buttons.
Signed-off-by: Albert Jakieła <jakiela@google.com>
---
arch/arm64/boot/dts/mediatek/Makefile | 3 +
.../mediatek/mt8186-corsola-chinchou-sku0.dts | 18 +
.../mediatek/mt8186-corsola-chinchou-sku1.dts | 34 ++
.../mt8186-corsola-chinchou-sku16.dts | 28 ++
.../dts/mediatek/mt8186-corsola-chinchou.dtsi | 445 ++++++++++++++++++
5 files changed, 528 insertions(+)
create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts
create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts
create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dts
create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi
diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
index 8fd7b2bb7a15..0db7770e8907 100644
--- a/arch/arm64/boot/dts/mediatek/Makefile
+++ b/arch/arm64/boot/dts/mediatek/Makefile
@@ -55,6 +55,9 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-kodama-sku32.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku0.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku176.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-pumpkin.dtb
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-chinchou-sku0.dtb
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-chinchou-sku1.dtb
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-chinchou-sku16.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393216.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393217.dtb
dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393218.dtb
diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts
new file mode 100644
index 000000000000..29dd92318da1
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts
@@ -0,0 +1,18 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2023 Google LLC
+ */
+
+/dts-v1/;
+#include "mt8186-corsola-chinchou.dtsi"
+
+/ {
+ model = "Google chinchou sku0 board";
+ compatible = "google,chinchou-sku0", "google,chinchou-sku2",
+ "google,chinchou-sku4", "google,chinchou-sku5",
+ "google,chinchou", "mediatek,mt8186";
+};
+
+&gpio_keys {
+ status = "disabled";
+};
diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts
new file mode 100644
index 000000000000..8ba31f81d9ad
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts
@@ -0,0 +1,34 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2023 Google LLC
+ */
+
+/dts-v1/;
+#include "mt8186-corsola-chinchou.dtsi"
+
+/ {
+ model = "Google chinchou sku1/sku17 board";
+ compatible = "google,chinchou-sku1", "google,chinchou-sku17",
+ "google,chinchou-sku3", "google,chinchou-sku6",
+ "google,chinchou-sku7", "google,chinchou-sku20",
+ "google,chinchou-sku22", "google,chinchou-sku23",
+ "mediatek,mt8186";
+};
+
+&i2c1 {
+ i2c-scl-internal-delay-ns = <10000>;
+
+ touchscreen: touchscreen@41 {
+ compatible = "ilitek,ili2901";
+ reg = <0x41>;
+ interrupts-extended = <&pio 12 IRQ_TYPE_LEVEL_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&touchscreen_pins>;
+ reset-gpios = <&pio 60 GPIO_ACTIVE_LOW>;
+ vccio-supply = <&pp1800_tchscr_report_disable>;
+ };
+};
+
+&gpio_keys {
+ status = "disabled";
+};
diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dts
new file mode 100644
index 000000000000..d3378d7ad096
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dts
@@ -0,0 +1,28 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2023 Google LLC
+ */
+
+/dts-v1/;
+#include "mt8186-corsola-chinchou.dtsi"
+
+/ {
+ model = "Google chinchou sku16/sku2147483647 board";
+ compatible = "google,chinchou-sku16", "google,chinchou-sku18",
+ "google,chinchou-sku19", "google,chinchou-sku21",
+ "google,chinchou-sku2147483647", "mediatek,mt8186";
+};
+
+&i2c1 {
+ i2c-scl-internal-delay-ns = <10000>;
+
+ touchscreen: touchscreen@41 {
+ compatible = "ilitek,ili2901";
+ reg = <0x41>;
+ interrupts-extended = <&pio 12 IRQ_TYPE_LEVEL_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&touchscreen_pins>;
+ reset-gpios = <&pio 60 GPIO_ACTIVE_LOW>;
+ vccio-supply = <&pp1800_tchscr_report_disable>;
+ };
+};
diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi
new file mode 100644
index 000000000000..c77cc43f8442
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi
@@ -0,0 +1,445 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2023 Google LLC
+ */
+
+/dts-v1/;
+#include "mt8186-corsola.dtsi"
+
+/ {
+ tboard_thermistor1: thermal-sensor1 {
+ compatible = "generic-adc-thermal";
+ #thermal-sensor-cells = <0>;
+ io-channels = <&auxadc 0>;
+ io-channel-names = "sensor-channel";
+ temperature-lookup-table = < (-5000) 1491
+ 0 1413
+ 5000 1324
+ 10000 1225
+ 15000 1120
+ 20000 1012
+ 25000 900
+ 30000 797
+ 35000 698
+ 40000 607
+ 45000 525
+ 50000 451
+ 55000 386
+ 60000 330
+ 65000 282
+ 70000 241
+ 75000 206
+ 80000 176
+ 85000 151
+ 90000 129
+ 95000 111
+ 100000 96
+ 105000 83
+ 110000 72
+ 115000 62
+ 120000 54
+ 125000 47>;
+ };
+
+ tboard_thermistor2: thermal-sensor2 {
+ compatible = "generic-adc-thermal";
+ #thermal-sensor-cells = <0>;
+ io-channels = <&auxadc 1>;
+ io-channel-names = "sensor-channel";
+ temperature-lookup-table = < (-5000) 1491
+ 0 1413
+ 5000 1324
+ 10000 1225
+ 15000 1120
+ 20000 1012
+ 25000 900
+ 30000 797
+ 35000 698
+ 40000 607
+ 45000 525
+ 50000 451
+ 55000 386
+ 60000 330
+ 65000 282
+ 70000 241
+ 75000 206
+ 80000 176
+ 85000 151
+ 90000 129
+ 95000 111
+ 100000 96
+ 105000 83
+ 110000 72
+ 115000 62
+ 120000 54
+ 125000 47>;
+ };
+
+ pp1800_tchscr_report_disable: regulator-pp1800-tchscr-report-disable {
+ compatible = "regulator-fixed";
+ regulator-name = "pp1800_tchscr_report_disable";
+ pinctrl-names = "default";
+ enable-active-low;
+ regulator-boot-on;
+ pinctrl-0 = <&touch_pin_report>;
+ gpio = <&pio 37 GPIO_ACTIVE_LOW>;
+ };
+
+ pp1000_edpbrdg: regulator-pp1000-edpbrdg {
+ compatible = "regulator-fixed";
+ regulator-name = "pp1000_edpbrdg";
+ pinctrl-names = "default";
+ pinctrl-0 = <&en_pp1000_edpbrdg>;
+ enable-active-high;
+ regulator-boot-on;
+ gpio = <&pio 29 GPIO_ACTIVE_HIGH>;
+ vin-supply = <&pp3300_z2>;
+ };
+
+ pp1800_edpbrdg_dx: regulator-pp1800-edpbrdg-dx {
+ compatible = "regulator-fixed";
+ regulator-name = "pp1800_edpbrdg_dx";
+ pinctrl-names = "default";
+ pinctrl-0 = <&en_pp1800_edpbrdg>;
+ enable-active-high;
+ regulator-boot-on;
+ gpio = <&pio 30 GPIO_ACTIVE_HIGH>;
+ vin-supply = <&mt6366_vio18_reg>;
+ };
+
+ pp3300_edp_dx: regulator-pp3300-edp-dx {
+ compatible = "regulator-fixed";
+ regulator-name = "pp3300_edp_dx";
+ pinctrl-names = "default";
+ pinctrl-0 = <&en_pp3300_edpbrdg>;
+ enable-active-high;
+ regulator-boot-on;
+ gpio = <&pio 31 GPIO_ACTIVE_HIGH>;
+ vin-supply = <&pp3300_z2>;
+ };
+};
+
+&rt5682s {
+ status = "disabled";
+};
+
+&rt1019p {
+ status = "disabled";
+};
+
+&dsi_out {
+ remote-endpoint = <&anx7625_in>;
+};
+
+&i2c0 {
+ clock-frequency = <400000>;
+
+ anx_bridge: anx7625@58 {
+ compatible = "analogix,anx7625";
+ reg = <0x58>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&anx7625_pins>;
+ panel_flags = <1>;
+ enable-gpios = <&pio 96 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&pio 98 GPIO_ACTIVE_HIGH>;
+ vdd10-supply = <&pp1000_edpbrdg>;
+ vdd18-supply = <&pp1800_edpbrdg_dx>;
+ vdd33-supply = <&pp3300_edp_dx>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ analogix,lane0-swing = /bits/ 8 <0x70 0x30>;
+ analogix,lane1-swing = /bits/ 8 <0x70 0x30>;
+
+ port@0 {
+ reg = <0>;
+
+ anx7625_in: endpoint {
+ remote-endpoint = <&dsi_out>;
+ data-lanes = <0 1 2 3>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ anx7625_out: endpoint {
+ remote-endpoint = <&panel_in>;
+ };
+ };
+
+ aux-bus {
+ panel: panel {
+ compatible = "edp-panel";
+ power-supply = <&pp3300_disp_x>;
+ backlight = <&backlight_lcd0>;
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&anx7625_out>;
+ };
+ };
+ };
+ };
+ };
+};
+
+&i2c2 {
+ trackpad@15 {
+ compatible = "hid-over-i2c";
+ post-power-on-delay-ms = <10>;
+ hid-descr-addr = <0x0001>;
+ vdd-supply = <&pp3300_s3>;
+ };
+};
+
+&i2c5 {
+ clock-frequency = <400000>;
+
+ rt5650: rt5650@1a {
+ compatible = "realtek,rt5650";
+ reg = <0x1a>;
+ avdd-supply = <&mt6366_vio18_reg>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&rt1019p_pins_default>;
+ cbj-sleeve-gpio = <&pio 150 GPIO_ACTIVE_HIGH>;
+ interrupt-parent = <&pio>;
+ interrupts = <17 IRQ_TYPE_EDGE_BOTH>;
+ #sound-dai-cells = <0>;
+ realtek,dmic1-data-pin = <2>;
+ realtek,jd-mode = <2>;
+ };
+};
+
+&mmc1_pins_default {
+ pins-clk {
+ drive-strength = <MTK_DRIVE_8mA>;
+ };
+
+ pins-cmd-dat {
+ drive-strength = <MTK_DRIVE_8mA>;
+ };
+};
+
+&mmc1_pins_uhs {
+ pins-clk {
+ drive-strength = <MTK_DRIVE_8mA>;
+ };
+
+ pins-cmd-dat {
+ drive-strength = <MTK_DRIVE_8mA>;
+ };
+};
+
+&sound {
+ status = "okay";
+
+ compatible = "mediatek,mt8186-mt6366-rt5650-sound";
+ mediatek,adsp = <&adsp>;
+
+ audio-routing =
+ "Headphone", "HPOL",
+ "Headphone", "HPOR",
+ "HDMI1", "TX";
+
+ hs-playback-dai-link {
+ codec {
+ sound-dai = <&rt5650>;
+ };
+ };
+
+ hs-capture-dai-link {
+ codec {
+ sound-dai = <&rt5650>;
+ };
+ };
+
+ spk-share-dai-link {
+ };
+
+ spk-hdmi-playback-dai-link {
+ codec {
+ sound-dai = <&it6505dptx>;
+ };
+ };
+};
+
+&wifi_enable_pin {
+ pins-wifi-enable {
+ pinmux = <PINMUX_GPIO51__FUNC_GPIO51>;
+ };
+};
+
+&wifi_pwrseq {
+ reset-gpios = <&pio 51 GPIO_ACTIVE_LOW>;
+};
+
+&keyboard_controller {
+ keypad,num-columns = <15>;
+
+ function-row-physmap = <
+ MATRIX_KEY(0x00, 0x02, 0) /* T1 */
+ MATRIX_KEY(0x03, 0x02, 0) /* T2 */
+ MATRIX_KEY(0x02, 0x02, 0) /* T3 */
+ MATRIX_KEY(0x01, 0x02, 0) /* T4 */
+ MATRIX_KEY(0x03, 0x04, 0) /* T5 */
+ MATRIX_KEY(0x02, 0x04, 0) /* T6 */
+ MATRIX_KEY(0x01, 0x04, 0) /* T7 */
+ MATRIX_KEY(0x02, 0x09, 0) /* T8 */
+ MATRIX_KEY(0x01, 0x09, 0) /* T9 */
+ MATRIX_KEY(0x00, 0x04, 0) /* T10 */
+ MATRIX_KEY(0x00, 0x01, 0) /* T11 */
+ MATRIX_KEY(0x01, 0x05, 0) /* T12 */
+ >;
+
+ linux,keymap = <
+ CROS_STD_MAIN_KEYMAP
+ MATRIX_KEY(0x00, 0x02, KEY_BACK) /* T1 */
+ MATRIX_KEY(0x03, 0x02, KEY_REFRESH) /* T2 */
+ MATRIX_KEY(0x02, 0x02, KEY_ZOOM) /* T3 */
+ MATRIX_KEY(0x01, 0x02, KEY_SCALE) /* T4 */
+ MATRIX_KEY(0x03, 0x04, KEY_SYSRQ) /* T5 */
+ MATRIX_KEY(0x02, 0x04, KEY_BRIGHTNESSDOWN) /* T6 */
+ MATRIX_KEY(0x01, 0x04, KEY_BRIGHTNESSUP) /* T7 */
+ MATRIX_KEY(0x02, 0x09, KEY_MUTE) /* T8 */
+ MATRIX_KEY(0x01, 0x09, KEY_VOLUMEDOWN) /* T9 */
+ MATRIX_KEY(0x00, 0x04, KEY_VOLUMEUP) /* T10 */
+ MATRIX_KEY(0x00, 0x01, KEY_MICMUTE) /* T11 */
+ MATRIX_KEY(0x01, 0x05, KEY_CONTROLPANEL) /* T12 */
+ MATRIX_KEY(0x03, 0x05, KEY_PREVIOUSSONG) /* T13 */
+ MATRIX_KEY(0x00, 0x09, KEY_PLAYPAUSE) /* T14 */
+ MATRIX_KEY(0x00, 0x0b, KEY_NEXTSONG) /* T15 */
+ MATRIX_KEY(0x03, 0x00, KEY_LEFTMETA) /* Search*/
+ MATRIX_KEY(0x01, 0x0e, KEY_LEFTCTRL) /* Left Control*/
+ MATRIX_KEY(0x06, 0x0d, KEY_LEFTALT) /* Left ALT*/
+ MATRIX_KEY(0x03, 0x0e, KEY_RIGHTCTRL) /* Right Control*/
+ MATRIX_KEY(0x06, 0x0a, KEY_BACKSLASH) /* BACKSLASH*/
+ >;
+};
+
+&thermal_zones {
+ cpu-ntc {
+ polling-delay = <1000>; /* milliseconds */
+ polling-delay-passive = <0>; /* milliseconds */
+ thermal-sensors = <&tboard_thermistor1>;
+ };
+
+ pmic-ntc {
+ polling-delay = <1000>; /* milliseconds */
+ polling-delay-passive = <50>; /* milliseconds */
+ thermal-sensors = <&tboard_thermistor2>;
+ sustainable-power = <1500>;
+
+ trips {
+ pmic_temp_alert0: trip-point@0 {
+ temperature = <50000>;
+ hysteresis = <2000>;
+ type = "passive";
+ };
+
+ pmic_temp_alert1: target@1 {
+ temperature = <60000>;
+ hysteresis = <2000>;
+ type = "passive";
+ };
+
+ pmic_ntc_crit: pmic-ntc-crit@0 {
+ temperature = <80000>;
+ hysteresis = <2000>;
+ type = "critical";
+ };
+ };
+
+ cooling-maps {
+ map0 {
+ trip = <&pmic_temp_alert1>;
+ cooling-device = <&cpu0
+ THERMAL_NO_LIMIT
+ THERMAL_NO_LIMIT>,
+ <&cpu1
+ THERMAL_NO_LIMIT
+ THERMAL_NO_LIMIT>,
+ <&cpu2
+ THERMAL_NO_LIMIT
+ THERMAL_NO_LIMIT>,
+ <&cpu3
+ THERMAL_NO_LIMIT
+ THERMAL_NO_LIMIT>,
+ <&cpu4
+ THERMAL_NO_LIMIT
+ THERMAL_NO_LIMIT>,
+ <&cpu5
+ THERMAL_NO_LIMIT
+ THERMAL_NO_LIMIT>;
+ contribution = <4096>;
+ };
+
+ map1 {
+ trip = <&pmic_temp_alert1>;
+ cooling-device = <&cpu6
+ THERMAL_NO_LIMIT
+ THERMAL_NO_LIMIT>,
+ <&cpu7
+ THERMAL_NO_LIMIT
+ THERMAL_NO_LIMIT>;
+ contribution = <1024>;
+ };
+ };
+ };
+};
+
+&pio {
+ touch_pin_report: pin-report {
+ pinmux = <PINMUX_GPIO37__FUNC_GPIO37>;
+ output-low;
+ };
+
+ anx7625_pins: anx7625-pins {
+ pins1 {
+ pinmux = <PINMUX_GPIO96__FUNC_GPIO96>,
+ <PINMUX_GPIO98__FUNC_GPIO98>;
+ output-low;
+ };
+
+ pins2 {
+ pinmux = <PINMUX_GPIO9__FUNC_GPIO9>;
+ input-enable;
+ bias-pull-up;
+ };
+ };
+
+ en_pp1000_edpbrdg: pp1000-edpbrdg-en-pins {
+ pins-vreg-en {
+ pinmux = <PINMUX_GPIO29__FUNC_GPIO29>;
+ output-low;
+ };
+ };
+
+ en_pp1800_edpbrdg: pp1800-edpbrdg-en-pins {
+ pins-vreg-en {
+ pinmux = <PINMUX_GPIO30__FUNC_GPIO30>;
+ output-low;
+ };
+ };
+
+ en_pp3300_edpbrdg: pp3300-edpbrdg-en-pins {
+ pins-vreg-en {
+ pinmux = <PINMUX_GPIO31__FUNC_GPIO31>;
+ output-low;
+ };
+ };
+};
+
+&i2c_tunnel {
+ /delete-node/ sbs-battery@b;
+
+ battery: sbs-battery@f {
+ compatible = "sbs,sbs-battery";
+ reg = <0xf>;
+ sbs,i2c-retry-count = <2>;
+ sbs,poll-retry-count = <1>;
+ };
+};
+
+&pen_insert {
+ wakeup-event-action = <EV_ACT_ANY>;
+};
--
2.46.0.792.g87dc391469-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: mediatek: Add MT8186 Chinchou/Chinchou360 Chromebooks
2024-09-25 8:03 [PATCH 1/2] dt-bindings: arm: mediatek: Add MT8186 Chinchou/Chinchou360 Chromebooks Albert Jakieła
2024-09-25 8:03 ` [PATCH 2/2] arm64: dts: mediate: Introduce " Albert Jakieła
@ 2024-09-25 14:17 ` Krzysztof Kozlowski
2024-09-25 14:36 ` Rob Herring (Arm)
2 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-09-25 14:17 UTC (permalink / raw)
To: Albert Jakieła, robh, krzk+dt, conor+dt, matthias.bgg,
angelogioacchino.delregno, wenst, rafal, hsinyi, nfraprado,
macpaul.lin, sean.wang
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek
On 25/09/2024 10:03, Albert Jakieła wrote:
> Add entries for MT8186 based Chinchou/Chinchou360 Chromebooks.
> These two are clamshell or convertible with touchscreen, stylus
> and extra buttons.
>
> Signed-off-by: Albert Jakieła <jakiela@google.com>
> ---
> .../devicetree/bindings/arm/mediatek.yaml | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 1d4bb50fcd8d..110149f5d748 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -239,6 +239,29 @@ properties:
> - enum:
> - mediatek,mt8183-pumpkin
> - const: mediatek,mt8183
> + - description: Google Chinchou360 (Asus Chromebook CZ11 Flip CZ1104F)
> + items:
> + - const: google,chinchou-sku16
> + - const: google,chinchou-sku18
> + - const: google,chinchou-sku19
> + - const: google,chinchou-sku21
> + - const: google,chinchou-sku2147483647
Wasn't sku-maxint removed? I recall same discussion recently... If yes,
then please use same rules for all future Chromebook submissions.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: mediatek: Add MT8186 Chinchou/Chinchou360 Chromebooks
2024-09-25 8:03 [PATCH 1/2] dt-bindings: arm: mediatek: Add MT8186 Chinchou/Chinchou360 Chromebooks Albert Jakieła
2024-09-25 8:03 ` [PATCH 2/2] arm64: dts: mediate: Introduce " Albert Jakieła
2024-09-25 14:17 ` [PATCH 1/2] dt-bindings: arm: mediatek: Add " Krzysztof Kozlowski
@ 2024-09-25 14:36 ` Rob Herring (Arm)
2 siblings, 0 replies; 6+ messages in thread
From: Rob Herring (Arm) @ 2024-09-25 14:36 UTC (permalink / raw)
To: Albert Jakieła
Cc: angelogioacchino.delregno, devicetree, nfraprado, wenst,
matthias.bgg, sean.wang, linux-mediatek, rafal, macpaul.lin,
hsinyi, linux-kernel, krzk+dt, conor+dt, linux-arm-kernel
On Wed, 25 Sep 2024 08:03:52 +0000, Albert Jakieła wrote:
> Add entries for MT8186 based Chinchou/Chinchou360 Chromebooks.
> These two are clamshell or convertible with touchscreen, stylus
> and extra buttons.
>
> Signed-off-by: Albert Jakieła <jakiela@google.com>
> ---
> .../devicetree/bindings/arm/mediatek.yaml | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y mediatek/mt8186-corsola-chinchou-sku0.dtb mediatek/mt8186-corsola-chinchou-sku1.dtb mediatek/mt8186-corsola-chinchou-sku16.dtb' for 20240925080353.2362879-1-jakiela@google.com:
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: /: compatible: 'oneOf' conditional failed, one must be fixed:
['google,chinchou-sku0', 'google,chinchou-sku2', 'google,chinchou-sku4', 'google,chinchou-sku5', 'google,chinchou', 'mediatek,mt8186'] is too long
['google,chinchou-sku0', 'google,chinchou-sku2', 'google,chinchou-sku4', 'google,chinchou-sku5', 'google,chinchou', 'mediatek,mt8186'] is too short
'google,chinchou-sku0' is not one of ['mediatek,mt2701-evb']
'google,chinchou-sku0' is not one of ['mediatek,mt2712-evb']
'google,chinchou-sku0' is not one of ['mediatek,mt6580-evbp1']
'google,chinchou-sku0' is not one of ['prestigio,pmt5008-3g']
'google,chinchou-sku0' is not one of ['fairphone,fp1', 'mundoreader,bq-aquaris5']
'google,chinchou-sku0' is not one of ['mediatek,mt6592-evb']
'google,chinchou-sku0' is not one of ['mediatek,mt6755-evb']
'google,chinchou-sku0' is not one of ['mediatek,mt6765-evb']
'google,chinchou-sku0' is not one of ['mediatek,mt6779-evb']
'google,chinchou-sku0' is not one of ['mediatek,mt6795-evb', 'sony,xperia-m5']
'google,chinchou-sku0' is not one of ['archermind,mt6797-x20-dev', 'mediatek,mt6797-evb']
'google,chinchou-sku0' is not one of ['bananapi,bpi-r64', 'mediatek,mt7622-rfb1']
'google,chinchou-sku0' is not one of ['mediatek,mt7623a-rfb-emmc', 'mediatek,mt7623a-rfb-nand', 'mediatek,mt7623n-rfb-emmc', 'bananapi,bpi-r2']
'google,chinchou-sku0' is not one of ['mediatek,mt7629-rfb']
'google,chinchou-sku0' is not one of ['cudy,wr3000-v1', 'openwrt,one', 'xiaomi,ax3000t']
'google,chinchou-sku0' is not one of ['acelink,ew-7886cax', 'bananapi,bpi-r3', 'bananapi,bpi-r3mini', 'mediatek,mt7986a-rfb']
'google,chinchou-sku0' is not one of ['mediatek,mt7986b-rfb']
'google,chinchou-sku0' is not one of ['bananapi,bpi-r4']
'google,chinchou-sku0' is not one of ['mediatek,mt8127-moose']
'google,chinchou-sku0' is not one of ['mediatek,mt8135-evbp1']
'google,chinchou-sku0' is not one of ['mediatek,mt8167-pumpkin']
'google,elm-rev8' was expected
'google,hana-rev6' was expected
'google,hana-rev7' was expected
'google,chinchou-sku0' is not one of ['mediatek,mt8173-evb']
'google,burnet' was expected
'google,cozmo' was expected
'google,damu' was expected
'google,chinchou-sku0' is not one of ['google,fennel-sku0', 'google,fennel-sku1', 'google,fennel-sku2', 'google,fennel-sku6', 'google,fennel-sku7']
'google,chinchou-sku0' is not one of ['google,juniper-sku16', 'google,juniper-sku17']
'google,kakadu-rev3' was expected
'google,kakadu-rev3-sku22' was expected
'google,kappa' was expected
'google,chinchou-sku0' is not one of ['google,katsu-sku32', 'google,katsu-sku38']
'google,chinchou-sku0' is not one of ['google,kodama-sku16', 'google,kodama-sku272', 'google,kodama-sku288', 'google,kodama-sku32']
'google,chinchou-sku0' is not one of ['google,krane-sku0', 'google,krane-sku176']
'google,chinchou-sku0' is not one of ['google,makomo-sku0', 'google,makomo-sku1']
'google,chinchou-sku0' is not one of ['google,pico-sku1', 'google,pico-sku2']
'google,chinchou-sku0' is not one of ['google,willow-sku0', 'google,willow-sku1']
'google,chinchou-sku0' is not one of ['mediatek,mt8183-evb']
'google,chinchou-sku0' is not one of ['mediatek,mt8183-pumpkin']
'google,chinchou-sku16' was expected
'google,steelix-sku393219' was expected
'google,steelix-sku393220' was expected
'google,steelix-sku393221' was expected
'google,steelix-sku196609' was expected
'google,chinchou-sku0' is not one of ['google,steelix-sku131072', 'google,steelix-sku131073']
'google,tentacruel-sku262147' was expected
'google,tentacruel-sku262151' was expected
'google,tentacruel-sku327681' was expected
'google,tentacruel-sku327683' was expected
'google,chinchou-sku0' is not one of ['google,voltorb-sku589824', 'google,voltorb-sku589825']
'google,chinchou-sku0' is not one of ['mediatek,mt8186-evb']
'google,chinchou-sku0' is not one of ['mediatek,mt8188-evb']
'google,hayato-rev1' was expected
'google,hayato-rev5-sku2' was expected
'google,spherion-rev3' was expected
'google,spherion-rev4' was expected
'google,chinchou-sku0' is not one of ['mediatek,mt8192-evb']
'google,chinchou-sku0' is not one of ['google,tomato-rev2', 'google,tomato-rev1']
'google,tomato-rev4' was expected
'google,dojo-sku7' was expected
'google,chinchou-sku0' is not one of ['mediatek,mt8195-demo', 'mediatek,mt8195-evb']
'google,chinchou-sku0' is not one of ['mediatek,mt8365-evk']
'google,chinchou-sku0' is not one of ['mediatek,mt8390-evk']
'google,chinchou-sku0' is not one of ['kontron,3-5-sbc-i1200', 'mediatek,mt8395-evk', 'radxa,nio-12l']
'google,chinchou-sku0' is not one of ['mediatek,mt8516-pumpkin']
'mediatek,mt2701' was expected
'mediatek,mt2712' was expected
'mediatek,mt6580' was expected
'mediatek,mt6582' was expected
'mediatek,mt6589' was expected
'mediatek,mt6592' was expected
'mediatek,mt6755' was expected
'mediatek,mt6765' was expected
'mediatek,mt6779' was expected
'mediatek,mt6795' was expected
'mediatek,mt6797' was expected
'mediatek,mt7622' was expected
'mediatek,mt7623' was expected
'mediatek,mt7629' was expected
'mediatek,mt7981b' was expected
'mediatek,mt7986a' was expected
'mediatek,mt7986b' was expected
'mediatek,mt7988a' was expected
'mediatek,mt8127' was expected
'mediatek,mt8135' was expected
'mediatek,mt8167' was expected
'google,elm-rev7' was expected
'google,hana-rev5' was expected
'mediatek,mt8173' was expected
'mediatek,mt8183' was expected
'google,fennel' was expected
'google,juniper' was expected
'google,kakadu-rev2' was expected
'google,kakadu-rev2-sku22' was expected
'google,katsu' was expected
'google,kodama' was expected
'google,krane' was expected
'google,makomo' was expected
'google,pico' was expected
'google,willow' was expected
'google,chinchou-sku18' was expected
'google,chinchou-sku1' was expected
'google,steelix-sku393216' was expected
'google,steelix-sku393217' was expected
'google,steelix-sku393218' was expected
'google,steelix-sku196608' was expected
'google,steelix' was expected
'google,tentacruel-sku262146' was expected
'google,tentacruel-sku262150' was expected
'google,tentacruel' was expected
'google,voltorb' was expected
'mediatek,mt8186' was expected
'mediatek,mt8188' was expected
'google,hayato' was expected
'google,hayato-sku2' was expected
'google,spherion-rev2' was expected
'google,spherion' was expected
'mediatek,mt8192' was expected
'google,tomato' was expected
'google,tomato-rev3' was expected
'google,dojo-sku5' was expected
'mediatek,mt8195' was expected
'mediatek,mt8365' was expected
'mediatek,mt8390' was expected
'mediatek,mt8395' was expected
'mediatek,mt8516' was expected
'google,elm-rev6' was expected
'google,hana-rev4' was expected
'google,kakadu' was expected
'google,chinchou-sku19' was expected
'google,chinchou-sku2' was expected
'google,tentacruel-sku262145' was expected
'google,tentacruel-sku262149' was expected
'google,spherion-rev1' was expected
'google,dojo-sku3' was expected
'google,elm-rev5' was expected
'google,hana-rev3' was expected
'google,chinchou-sku21' was expected
'google,chinchou-sku3' was expected
'google,tentacruel-sku262144' was expected
'google,tentacruel-sku262148' was expected
'google,spherion-rev0' was expected
'google,dojo-sku1' was expected
'google,elm-rev4' was expected
'google,hana' was expected
'google,chinchou-sku2147483647' was expected
'google,chinchou-sku4' was expected
'google,dojo' was expected
'google,elm-rev3' was expected
'google,chinchou-sku5' was expected
from schema $id: http://devicetree.org/schemas/arm/mediatek.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: /: compatible: 'oneOf' conditional failed, one must be fixed:
['google,chinchou-sku1', 'google,chinchou-sku17', 'google,chinchou-sku3', 'google,chinchou-sku6', 'google,chinchou-sku7', 'google,chinchou-sku20', 'google,chinchou-sku22', 'google,chinchou-sku23', 'mediatek,mt8186'] is too long
['google,chinchou-sku1', 'google,chinchou-sku17', 'google,chinchou-sku3', 'google,chinchou-sku6', 'google,chinchou-sku7', 'google,chinchou-sku20', 'google,chinchou-sku22', 'google,chinchou-sku23', 'mediatek,mt8186'] is too short
'google,chinchou-sku1' is not one of ['mediatek,mt2701-evb']
'google,chinchou-sku1' is not one of ['mediatek,mt2712-evb']
'google,chinchou-sku1' is not one of ['mediatek,mt6580-evbp1']
'google,chinchou-sku1' is not one of ['prestigio,pmt5008-3g']
'google,chinchou-sku1' is not one of ['fairphone,fp1', 'mundoreader,bq-aquaris5']
'google,chinchou-sku1' is not one of ['mediatek,mt6592-evb']
'google,chinchou-sku1' is not one of ['mediatek,mt6755-evb']
'google,chinchou-sku1' is not one of ['mediatek,mt6765-evb']
'google,chinchou-sku1' is not one of ['mediatek,mt6779-evb']
'google,chinchou-sku1' is not one of ['mediatek,mt6795-evb', 'sony,xperia-m5']
'google,chinchou-sku1' is not one of ['archermind,mt6797-x20-dev', 'mediatek,mt6797-evb']
'google,chinchou-sku1' is not one of ['bananapi,bpi-r64', 'mediatek,mt7622-rfb1']
'google,chinchou-sku1' is not one of ['mediatek,mt7623a-rfb-emmc', 'mediatek,mt7623a-rfb-nand', 'mediatek,mt7623n-rfb-emmc', 'bananapi,bpi-r2']
'google,chinchou-sku1' is not one of ['mediatek,mt7629-rfb']
'google,chinchou-sku1' is not one of ['cudy,wr3000-v1', 'openwrt,one', 'xiaomi,ax3000t']
'google,chinchou-sku1' is not one of ['acelink,ew-7886cax', 'bananapi,bpi-r3', 'bananapi,bpi-r3mini', 'mediatek,mt7986a-rfb']
'google,chinchou-sku1' is not one of ['mediatek,mt7986b-rfb']
'google,chinchou-sku1' is not one of ['bananapi,bpi-r4']
'google,chinchou-sku1' is not one of ['mediatek,mt8127-moose']
'google,chinchou-sku1' is not one of ['mediatek,mt8135-evbp1']
'google,chinchou-sku1' is not one of ['mediatek,mt8167-pumpkin']
'google,elm-rev8' was expected
'google,hana-rev6' was expected
'google,hana-rev7' was expected
'google,chinchou-sku1' is not one of ['mediatek,mt8173-evb']
'google,burnet' was expected
'google,cozmo' was expected
'google,damu' was expected
'google,chinchou-sku1' is not one of ['google,fennel-sku0', 'google,fennel-sku1', 'google,fennel-sku2', 'google,fennel-sku6', 'google,fennel-sku7']
'google,chinchou-sku1' is not one of ['google,juniper-sku16', 'google,juniper-sku17']
'google,kakadu-rev3' was expected
'google,kakadu-rev3-sku22' was expected
'google,kappa' was expected
'google,chinchou-sku1' is not one of ['google,katsu-sku32', 'google,katsu-sku38']
'google,chinchou-sku1' is not one of ['google,kodama-sku16', 'google,kodama-sku272', 'google,kodama-sku288', 'google,kodama-sku32']
'google,chinchou-sku1' is not one of ['google,krane-sku0', 'google,krane-sku176']
'google,chinchou-sku1' is not one of ['google,makomo-sku0', 'google,makomo-sku1']
'google,chinchou-sku1' is not one of ['google,pico-sku1', 'google,pico-sku2']
'google,chinchou-sku1' is not one of ['google,willow-sku0', 'google,willow-sku1']
'google,chinchou-sku1' is not one of ['mediatek,mt8183-evb']
'google,chinchou-sku1' is not one of ['mediatek,mt8183-pumpkin']
'google,chinchou-sku16' was expected
'google,chinchou-sku0' was expected
'google,steelix-sku393219' was expected
'google,steelix-sku393220' was expected
'google,steelix-sku393221' was expected
'google,steelix-sku196609' was expected
'google,chinchou-sku1' is not one of ['google,steelix-sku131072', 'google,steelix-sku131073']
'google,tentacruel-sku262147' was expected
'google,tentacruel-sku262151' was expected
'google,tentacruel-sku327681' was expected
'google,tentacruel-sku327683' was expected
'google,chinchou-sku1' is not one of ['google,voltorb-sku589824', 'google,voltorb-sku589825']
'google,chinchou-sku1' is not one of ['mediatek,mt8186-evb']
'google,chinchou-sku1' is not one of ['mediatek,mt8188-evb']
'google,hayato-rev1' was expected
'google,hayato-rev5-sku2' was expected
'google,spherion-rev3' was expected
'google,spherion-rev4' was expected
'google,chinchou-sku1' is not one of ['mediatek,mt8192-evb']
'google,chinchou-sku1' is not one of ['google,tomato-rev2', 'google,tomato-rev1']
'google,tomato-rev4' was expected
'google,dojo-sku7' was expected
'google,chinchou-sku1' is not one of ['mediatek,mt8195-demo', 'mediatek,mt8195-evb']
'google,chinchou-sku1' is not one of ['mediatek,mt8365-evk']
'google,chinchou-sku1' is not one of ['mediatek,mt8390-evk']
'google,chinchou-sku1' is not one of ['kontron,3-5-sbc-i1200', 'mediatek,mt8395-evk', 'radxa,nio-12l']
'google,chinchou-sku1' is not one of ['mediatek,mt8516-pumpkin']
'mediatek,mt2701' was expected
'mediatek,mt2712' was expected
'mediatek,mt6580' was expected
'mediatek,mt6582' was expected
'mediatek,mt6589' was expected
'mediatek,mt6592' was expected
'mediatek,mt6755' was expected
'mediatek,mt6765' was expected
'mediatek,mt6779' was expected
'mediatek,mt6795' was expected
'mediatek,mt6797' was expected
'mediatek,mt7622' was expected
'mediatek,mt7623' was expected
'mediatek,mt7629' was expected
'mediatek,mt7981b' was expected
'mediatek,mt7986a' was expected
'mediatek,mt7986b' was expected
'mediatek,mt7988a' was expected
'mediatek,mt8127' was expected
'mediatek,mt8135' was expected
'mediatek,mt8167' was expected
'google,elm-rev7' was expected
'google,hana-rev5' was expected
'mediatek,mt8173' was expected
'mediatek,mt8183' was expected
'google,fennel' was expected
'google,juniper' was expected
'google,kakadu-rev2' was expected
'google,kakadu-rev2-sku22' was expected
'google,katsu' was expected
'google,kodama' was expected
'google,krane' was expected
'google,makomo' was expected
'google,pico' was expected
'google,willow' was expected
'google,chinchou-sku18' was expected
'google,chinchou-sku1' was expected
'google,steelix-sku393216' was expected
'google,steelix-sku393217' was expected
'google,steelix-sku393218' was expected
'google,steelix-sku196608' was expected
'google,steelix' was expected
'google,tentacruel-sku262146' was expected
'google,tentacruel-sku262150' was expected
'google,tentacruel' was expected
'google,voltorb' was expected
'mediatek,mt8186' was expected
'mediatek,mt8188' was expected
'google,hayato' was expected
'google,hayato-sku2' was expected
'google,spherion-rev2' was expected
'google,spherion' was expected
'mediatek,mt8192' was expected
'google,tomato' was expected
'google,tomato-rev3' was expected
'google,dojo-sku5' was expected
'mediatek,mt8195' was expected
'mediatek,mt8365' was expected
'mediatek,mt8390' was expected
'mediatek,mt8395' was expected
'mediatek,mt8516' was expected
'google,elm-rev6' was expected
'google,hana-rev4' was expected
'google,kakadu' was expected
'google,chinchou-sku19' was expected
'google,chinchou-sku2' was expected
'google,tentacruel-sku262145' was expected
'google,tentacruel-sku262149' was expected
'google,spherion-rev1' was expected
'google,dojo-sku3' was expected
'google,elm-rev5' was expected
'google,hana-rev3' was expected
'google,chinchou-sku21' was expected
'google,chinchou-sku3' was expected
'google,tentacruel-sku262144' was expected
'google,tentacruel-sku262148' was expected
'google,spherion-rev0' was expected
'google,dojo-sku1' was expected
'google,elm-rev4' was expected
'google,hana' was expected
'google,chinchou-sku2147483647' was expected
'google,chinchou-sku4' was expected
'google,dojo' was expected
'google,elm-rev3' was expected
'google,chinchou-sku5' was expected
'google,elm' was expected
'google,chinchou-sku6' was expected
'google,chinchou-sku7' was expected
'google,chinchou-sku17' was expected
from schema $id: http://devicetree.org/schemas/arm/mediatek.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: /: failed to match any schema with compatible: ['google,chinchou-sku1', 'google,chinchou-sku17', 'google,chinchou-sku3', 'google,chinchou-sku6', 'google,chinchou-sku7', 'google,chinchou-sku20', 'google,chinchou-sku22', 'google,chinchou-sku23', 'mediatek,mt8186']
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: pinctrl@10005000: 'pin-report' does not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8186-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: pinctrl@10005000: 'pin-report' does not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8186-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: pinctrl@10005000: 'pin-report' does not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/pinctrl/mediatek,mt8186-pinctrl.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358']
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358']
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound']
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound']
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358']
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358']
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound']
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound']
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358']
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: /soc/pwrap@1000d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358']
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound']
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: /soc/pwrap@1000d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound']
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc']
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc']
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc']
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc']
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc']
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: /soc/pwrap@1000d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc']
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: anx7625@58: 'ports' is a required property
from schema $id: http://devicetree.org/schemas/display/bridge/analogix,anx7625.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: anx7625@58: '#address-cells', '#size-cells', 'panel_flags', 'port@0', 'port@1' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/display/bridge/analogix,anx7625.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: anx7625@58: 'ports' is a required property
from schema $id: http://devicetree.org/schemas/display/bridge/analogix,anx7625.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: anx7625@58: '#address-cells', '#size-cells', 'panel_flags', 'port@0', 'port@1' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/display/bridge/analogix,anx7625.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: anx7625@58: 'ports' is a required property
from schema $id: http://devicetree.org/schemas/display/bridge/analogix,anx7625.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: anx7625@58: '#address-cells', '#size-cells', 'panel_flags', 'port@0', 'port@1' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/display/bridge/analogix,anx7625.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: trackpad@15: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/input/hid-over-i2c.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: dp-bridge@5c: 'extcon' is a required property
from schema $id: http://devicetree.org/schemas/display/bridge/ite,it6505.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: touchscreen@41: 'vcc33-supply' is a required property
from schema $id: http://devicetree.org/schemas/input/ilitek,ili2901.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: touchscreen@41: 'vcc33-supply' is a required property
from schema $id: http://devicetree.org/schemas/input/ilitek,ili2901.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: trackpad@15: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/input/hid-over-i2c.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: trackpad@15: 'vcc-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/input/hid-over-i2c.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: dp-bridge@5c: 'extcon' is a required property
from schema $id: http://devicetree.org/schemas/display/bridge/ite,it6505.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: rt5650@1a: 'cpvdd-supply' is a required property
from schema $id: http://devicetree.org/schemas/sound/realtek,rt5645.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: rt5650@1a: Unevaluated properties are not allowed ('cbj-sleeve-gpio' was unexpected)
from schema $id: http://devicetree.org/schemas/sound/realtek,rt5645.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: dp-bridge@5c: 'extcon' is a required property
from schema $id: http://devicetree.org/schemas/display/bridge/ite,it6505.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: rt5650@1a: 'cpvdd-supply' is a required property
from schema $id: http://devicetree.org/schemas/sound/realtek,rt5645.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: rt5650@1a: Unevaluated properties are not allowed ('cbj-sleeve-gpio' was unexpected)
from schema $id: http://devicetree.org/schemas/sound/realtek,rt5645.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: rt5650@1a: 'cpvdd-supply' is a required property
from schema $id: http://devicetree.org/schemas/sound/realtek,rt5645.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: rt5650@1a: Unevaluated properties are not allowed ('cbj-sleeve-gpio' was unexpected)
from schema $id: http://devicetree.org/schemas/sound/realtek,rt5645.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: thermal-zones: 'cpu-ntc', 'pmic-ntc' do not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\-]{1,10}-thermal$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: thermal-zones: 'cpu-ntc', 'pmic-ntc' do not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\-]{1,10}-thermal$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: thermal-zones: 'cpu-ntc', 'pmic-ntc' do not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\-]{1,10}-thermal$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/thermal/thermal-zones.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: sound: 'model' is a required property
from schema $id: http://devicetree.org/schemas/sound/mt8186-mt6366-rt1019-rt5682s.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: sound: 'model' is a required property
from schema $id: http://devicetree.org/schemas/sound/mt8186-mt6366-rt1019-rt5682s.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: sound: 'model' is a required property
from schema $id: http://devicetree.org/schemas/sound/mt8186-mt6366-rt1019-rt5682s.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dtb: regulator-pp1800-tchscr-report-disable: Unevaluated properties are not allowed ('enable-active-low' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/fixed-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dtb: regulator-pp1800-tchscr-report-disable: Unevaluated properties are not allowed ('enable-active-low' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/fixed-regulator.yaml#
arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dtb: regulator-pp1800-tchscr-report-disable: Unevaluated properties are not allowed ('enable-active-low' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/fixed-regulator.yaml#
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm64: dts: mediate: Introduce MT8186 Chinchou/Chinchou360 Chromebooks
2024-09-25 8:03 ` [PATCH 2/2] arm64: dts: mediate: Introduce " Albert Jakieła
@ 2024-09-26 9:27 ` AngeloGioacchino Del Regno
2024-09-26 23:02 ` Hsin-Yi Wang
0 siblings, 1 reply; 6+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-09-26 9:27 UTC (permalink / raw)
To: Albert Jakieła, robh, krzk+dt, conor+dt, matthias.bgg, wenst,
rafal, hsinyi, nfraprado, macpaul.lin, sean.wang
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek
Il 25/09/24 10:03, Albert Jakieła ha scritto:
> The MT8186 Chinchou/Chinchou360, also known as the Asus Chromebook
> CZ12/CZ11 Flip, is a clamshell or convertible device with touchscreen,
> stylus and extra buttons.
>
> Signed-off-by: Albert Jakieła <jakiela@google.com>
> ---
> arch/arm64/boot/dts/mediatek/Makefile | 3 +
> .../mediatek/mt8186-corsola-chinchou-sku0.dts | 18 +
> .../mediatek/mt8186-corsola-chinchou-sku1.dts | 34 ++
> .../mt8186-corsola-chinchou-sku16.dts | 28 ++
> .../dts/mediatek/mt8186-corsola-chinchou.dtsi | 445 ++++++++++++++++++
> 5 files changed, 528 insertions(+)
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dts
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi
>
> diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
> index 8fd7b2bb7a15..0db7770e8907 100644
> --- a/arch/arm64/boot/dts/mediatek/Makefile
> +++ b/arch/arm64/boot/dts/mediatek/Makefile
> @@ -55,6 +55,9 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-kodama-sku32.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku0.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku176.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-pumpkin.dtb
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-chinchou-sku0.dtb
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-chinchou-sku1.dtb
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-chinchou-sku16.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393216.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393217.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393218.dtb
> diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts
> new file mode 100644
> index 000000000000..29dd92318da1
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts
> @@ -0,0 +1,18 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright 2023 Google LLC
> + */
> +
> +/dts-v1/;
> +#include "mt8186-corsola-chinchou.dtsi"
> +
> +/ {
> + model = "Google chinchou sku0 board";
> + compatible = "google,chinchou-sku0", "google,chinchou-sku2",
> + "google,chinchou-sku4", "google,chinchou-sku5",
> + "google,chinchou", "mediatek,mt8186";
> +};
> +
> +&gpio_keys {
> + status = "disabled";
> +};
> diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts
> new file mode 100644
> index 000000000000..8ba31f81d9ad
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts
> @@ -0,0 +1,34 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright 2023 Google LLC
> + */
> +
> +/dts-v1/;
> +#include "mt8186-corsola-chinchou.dtsi"
> +
> +/ {
> + model = "Google chinchou sku1/sku17 board";
> + compatible = "google,chinchou-sku1", "google,chinchou-sku17",
> + "google,chinchou-sku3", "google,chinchou-sku6",
> + "google,chinchou-sku7", "google,chinchou-sku20",
> + "google,chinchou-sku22", "google,chinchou-sku23",
> + "mediatek,mt8186";
> +};
> +
> +&i2c1 {
> + i2c-scl-internal-delay-ns = <10000>;
> +
> + touchscreen: touchscreen@41 {
> + compatible = "ilitek,ili2901";
> + reg = <0x41>;
> + interrupts-extended = <&pio 12 IRQ_TYPE_LEVEL_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&touchscreen_pins>;
> + reset-gpios = <&pio 60 GPIO_ACTIVE_LOW>;
> + vccio-supply = <&pp1800_tchscr_report_disable>;
> + };
> +};
> +
> +&gpio_keys {
> + status = "disabled";
> +};
> diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dts
> new file mode 100644
> index 000000000000..d3378d7ad096
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dts
> @@ -0,0 +1,28 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright 2023 Google LLC
> + */
> +
> +/dts-v1/;
> +#include "mt8186-corsola-chinchou.dtsi"
> +
> +/ {
> + model = "Google chinchou sku16/sku2147483647 board";
> + compatible = "google,chinchou-sku16", "google,chinchou-sku18",
> + "google,chinchou-sku19", "google,chinchou-sku21",
> + "google,chinchou-sku2147483647", "mediatek,mt8186";
> +};
> +
> +&i2c1 {
> + i2c-scl-internal-delay-ns = <10000>;
> +
> + touchscreen: touchscreen@41 {
> + compatible = "ilitek,ili2901";
> + reg = <0x41>;
> + interrupts-extended = <&pio 12 IRQ_TYPE_LEVEL_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&touchscreen_pins>;
> + reset-gpios = <&pio 60 GPIO_ACTIVE_LOW>;
> + vccio-supply = <&pp1800_tchscr_report_disable>;
> + };
> +};
> diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi
> new file mode 100644
> index 000000000000..c77cc43f8442
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi
..snip..
> +
> +&mmc1_pins_default {
> + pins-clk {
> + drive-strength = <MTK_DRIVE_8mA>;
Please stop using the meaningless MTK_DRIVE_(x)mA macro.
drive-strength = <8>; is enough :-)
Cheers,
Angelo
> + };
> +
> + pins-cmd-dat {
> + drive-strength = <MTK_DRIVE_8mA>;
> + };
> +};
> +
> +&mmc1_pins_uhs {
> + pins-clk {
> + drive-strength = <MTK_DRIVE_8mA>;
> + };
> +
> + pins-cmd-dat {
> + drive-strength = <MTK_DRIVE_8mA>;
> + };
> +};
> +
> +&sound {
> + status = "okay";
> +
> + compatible = "mediatek,mt8186-mt6366-rt5650-sound";
You don't need to change this compatible, as the only thing that changes in the
actual driver are the dapm_routes. I implemented support for that nice dai-link
(standard, kind of) graph so that we stop getting a thousand compatibles for no
reason other than routing :-)
This should work with (99.9% confident it will, but please test):
model = "mt8186_rt5650";
status = "okay";
> + mediatek,adsp = <&adsp>;
This property is already set in the node that you're inheriting from
mt8186-corsola.dtsi, please drop.
> +
> + audio-routing =
> + "Headphone", "HPOL",
> + "Headphone", "HPOR",
> + "HDMI1", "TX";
> +
> + hs-playback-dai-link {
> + codec {
> + sound-dai = <&rt5650>;
> + };
> + };
> +
> + hs-capture-dai-link {
> + codec {
> + sound-dai = <&rt5650>;
> + };
> + };
> +
> + spk-share-dai-link {
> + };
Empty nodes are meaningless (and you're inheriting this dai link from
mt8186-corsola.dtsi as well). Drop.
> +
> + spk-hdmi-playback-dai-link {
> + codec {
> + sound-dai = <&it6505dptx>;
> + };
> + };
> +};
> +
> +&wifi_enable_pin {
> + pins-wifi-enable {
> + pinmux = <PINMUX_GPIO51__FUNC_GPIO51>;
> + };
> +};
> +
> +&wifi_pwrseq {
> + reset-gpios = <&pio 51 GPIO_ACTIVE_LOW>;
> +};
> +
..snip..
> +
> +&pen_insert {
> + wakeup-event-action = <EV_ACT_ANY>;
Why is this set to EV_ACT_ANY on Chinchou but not on the other Corsola devices?
Is there any specific reason?
Cheers,
Angelo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm64: dts: mediate: Introduce MT8186 Chinchou/Chinchou360 Chromebooks
2024-09-26 9:27 ` AngeloGioacchino Del Regno
@ 2024-09-26 23:02 ` Hsin-Yi Wang
0 siblings, 0 replies; 6+ messages in thread
From: Hsin-Yi Wang @ 2024-09-26 23:02 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: Albert Jakieła, robh, krzk+dt, conor+dt, matthias.bgg, wenst,
rafal, nfraprado, macpaul.lin, sean.wang, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek
On Thu, Sep 26, 2024 at 2:27 AM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> Il 25/09/24 10:03, Albert Jakieła ha scritto:
> > The MT8186 Chinchou/Chinchou360, also known as the Asus Chromebook
> > CZ12/CZ11 Flip, is a clamshell or convertible device with touchscreen,
> > stylus and extra buttons.
> >
> > Signed-off-by: Albert Jakieła <jakiela@google.com>
> > ---
> > arch/arm64/boot/dts/mediatek/Makefile | 3 +
> > .../mediatek/mt8186-corsola-chinchou-sku0.dts | 18 +
> > .../mediatek/mt8186-corsola-chinchou-sku1.dts | 34 ++
> > .../mt8186-corsola-chinchou-sku16.dts | 28 ++
> > .../dts/mediatek/mt8186-corsola-chinchou.dtsi | 445 ++++++++++++++++++
> > 5 files changed, 528 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts
> > create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts
> > create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dts
> > create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
> > index 8fd7b2bb7a15..0db7770e8907 100644
> > --- a/arch/arm64/boot/dts/mediatek/Makefile
> > +++ b/arch/arm64/boot/dts/mediatek/Makefile
> > @@ -55,6 +55,9 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-kodama-sku32.dtb
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku0.dtb
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku176.dtb
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-pumpkin.dtb
> > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-chinchou-sku0.dtb
> > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-chinchou-sku1.dtb
> > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-chinchou-sku16.dtb
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393216.dtb
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393217.dtb
> > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393218.dtb
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts
> > new file mode 100644
> > index 000000000000..29dd92318da1
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts
> > @@ -0,0 +1,18 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > +/*
> > + * Copyright 2023 Google LLC
> > + */
> > +
> > +/dts-v1/;
> > +#include "mt8186-corsola-chinchou.dtsi"
> > +
> > +/ {
> > + model = "Google chinchou sku0 board";
> > + compatible = "google,chinchou-sku0", "google,chinchou-sku2",
> > + "google,chinchou-sku4", "google,chinchou-sku5",
> > + "google,chinchou", "mediatek,mt8186";
> > +};
> > +
> > +&gpio_keys {
> > + status = "disabled";
> > +};
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts
> > new file mode 100644
> > index 000000000000..8ba31f81d9ad
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts
> > @@ -0,0 +1,34 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > +/*
> > + * Copyright 2023 Google LLC
> > + */
> > +
> > +/dts-v1/;
> > +#include "mt8186-corsola-chinchou.dtsi"
> > +
> > +/ {
> > + model = "Google chinchou sku1/sku17 board";
> > + compatible = "google,chinchou-sku1", "google,chinchou-sku17",
> > + "google,chinchou-sku3", "google,chinchou-sku6",
> > + "google,chinchou-sku7", "google,chinchou-sku20",
> > + "google,chinchou-sku22", "google,chinchou-sku23",
> > + "mediatek,mt8186";
> > +};
> > +
> > +&i2c1 {
> > + i2c-scl-internal-delay-ns = <10000>;
> > +
> > + touchscreen: touchscreen@41 {
> > + compatible = "ilitek,ili2901";
> > + reg = <0x41>;
> > + interrupts-extended = <&pio 12 IRQ_TYPE_LEVEL_LOW>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&touchscreen_pins>;
> > + reset-gpios = <&pio 60 GPIO_ACTIVE_LOW>;
> > + vccio-supply = <&pp1800_tchscr_report_disable>;
> > + };
> > +};
> > +
> > +&gpio_keys {
> > + status = "disabled";
> > +};
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dts
> > new file mode 100644
> > index 000000000000..d3378d7ad096
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dts
> > @@ -0,0 +1,28 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > +/*
> > + * Copyright 2023 Google LLC
> > + */
> > +
> > +/dts-v1/;
> > +#include "mt8186-corsola-chinchou.dtsi"
> > +
> > +/ {
> > + model = "Google chinchou sku16/sku2147483647 board";
> > + compatible = "google,chinchou-sku16", "google,chinchou-sku18",
> > + "google,chinchou-sku19", "google,chinchou-sku21",
> > + "google,chinchou-sku2147483647", "mediatek,mt8186";
> > +};
> > +
> > +&i2c1 {
> > + i2c-scl-internal-delay-ns = <10000>;
> > +
> > + touchscreen: touchscreen@41 {
> > + compatible = "ilitek,ili2901";
> > + reg = <0x41>;
> > + interrupts-extended = <&pio 12 IRQ_TYPE_LEVEL_LOW>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&touchscreen_pins>;
> > + reset-gpios = <&pio 60 GPIO_ACTIVE_LOW>;
> > + vccio-supply = <&pp1800_tchscr_report_disable>;
> > + };
> > +};
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi
> > new file mode 100644
> > index 000000000000..c77cc43f8442
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi
>
> ..snip..
>
> > +
> > +&mmc1_pins_default {
> > + pins-clk {
> > + drive-strength = <MTK_DRIVE_8mA>;
>
> Please stop using the meaningless MTK_DRIVE_(x)mA macro.
>
> drive-strength = <8>; is enough :-)
>
> Cheers,
> Angelo
>
> > + };
> > +
> > + pins-cmd-dat {
> > + drive-strength = <MTK_DRIVE_8mA>;
> > + };
> > +};
> > +
> > +&mmc1_pins_uhs {
> > + pins-clk {
> > + drive-strength = <MTK_DRIVE_8mA>;
> > + };
> > +
> > + pins-cmd-dat {
> > + drive-strength = <MTK_DRIVE_8mA>;
> > + };
> > +};
> > +
> > +&sound {
> > + status = "okay";
> > +
> > + compatible = "mediatek,mt8186-mt6366-rt5650-sound";
>
> You don't need to change this compatible, as the only thing that changes in the
> actual driver are the dapm_routes. I implemented support for that nice dai-link
> (standard, kind of) graph so that we stop getting a thousand compatibles for no
> reason other than routing :-)
>
> This should work with (99.9% confident it will, but please test):
>
> model = "mt8186_rt5650";
> status = "okay";
>
> > + mediatek,adsp = <&adsp>;
>
> This property is already set in the node that you're inheriting from
> mt8186-corsola.dtsi, please drop.
>
> > +
> > + audio-routing =
> > + "Headphone", "HPOL",
> > + "Headphone", "HPOR",
> > + "HDMI1", "TX";
> > +
> > + hs-playback-dai-link {
> > + codec {
> > + sound-dai = <&rt5650>;
> > + };
> > + };
> > +
> > + hs-capture-dai-link {
> > + codec {
> > + sound-dai = <&rt5650>;
> > + };
> > + };
> > +
> > + spk-share-dai-link {
> > + };
>
> Empty nodes are meaningless (and you're inheriting this dai link from
> mt8186-corsola.dtsi as well). Drop.
>
> > +
> > + spk-hdmi-playback-dai-link {
> > + codec {
> > + sound-dai = <&it6505dptx>;
> > + };
> > + };
> > +};
> > +
> > +&wifi_enable_pin {
> > + pins-wifi-enable {
> > + pinmux = <PINMUX_GPIO51__FUNC_GPIO51>;
> > + };
> > +};
> > +
> > +&wifi_pwrseq {
> > + reset-gpios = <&pio 51 GPIO_ACTIVE_LOW>;
> > +};
> > +
>
> ..snip..
>
> > +
> > +&pen_insert {
> > + wakeup-event-action = <EV_ACT_ANY>;
>
> Why is this set to EV_ACT_ANY on Chinchou but not on the other Corsola devices?
> Is there any specific reason?
Default it's set to EV_ACT_DEASSERTED. Some OEMs want to wake up on
both assert and deassert.
>
> Cheers,
> Angelo
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-09-26 23:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-25 8:03 [PATCH 1/2] dt-bindings: arm: mediatek: Add MT8186 Chinchou/Chinchou360 Chromebooks Albert Jakieła
2024-09-25 8:03 ` [PATCH 2/2] arm64: dts: mediate: Introduce " Albert Jakieła
2024-09-26 9:27 ` AngeloGioacchino Del Regno
2024-09-26 23:02 ` Hsin-Yi Wang
2024-09-25 14:17 ` [PATCH 1/2] dt-bindings: arm: mediatek: Add " Krzysztof Kozlowski
2024-09-25 14:36 ` Rob Herring (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).