* [PATCH] dt-bindings: interrupt-controller: fsl,mu-msi: Drop "interrupt-controller" property
@ 2024-09-25 17:34 Rob Herring (Arm)
2024-09-25 18:19 ` Frank Li
2024-09-26 16:57 ` Conor Dooley
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2024-09-25 17:34 UTC (permalink / raw)
To: Thomas Gleixner, Krzysztof Kozlowski, Conor Dooley, Frank Li
Cc: linux-kernel, devicetree
The Freescale MU-MSI is an MSI provider, not an interrupt provider, so
drop the "interrupt-controller" property. This fixes dtc "interrupt_provider"
warning.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
If this is not correct, then #interrupt-cells needs to be added.
---
.../devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml | 4 ----
1 file changed, 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml
index 799ae5c3e32a..b5282c857f44 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml
@@ -62,8 +62,6 @@ properties:
- const: processor-a-side
- const: processor-b-side
- interrupt-controller: true
-
msi-controller: true
"#msi-cells":
@@ -73,7 +71,6 @@ required:
- compatible
- reg
- interrupts
- - interrupt-controller
- msi-controller
- "#msi-cells"
@@ -88,7 +85,6 @@ examples:
compatible = "fsl,imx6sx-mu-msi";
msi-controller;
#msi-cells = <0>;
- interrupt-controller;
reg = <0x5d270000 0x10000>, /* A side */
<0x5d300000 0x10000>; /* B side */
reg-names = "processor-a-side", "processor-b-side";
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: interrupt-controller: fsl,mu-msi: Drop "interrupt-controller" property
2024-09-25 17:34 [PATCH] dt-bindings: interrupt-controller: fsl,mu-msi: Drop "interrupt-controller" property Rob Herring (Arm)
@ 2024-09-25 18:19 ` Frank Li
2024-09-26 16:57 ` Conor Dooley
1 sibling, 0 replies; 3+ messages in thread
From: Frank Li @ 2024-09-25 18:19 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Thomas Gleixner, Krzysztof Kozlowski, Conor Dooley, linux-kernel,
devicetree
On Wed, Sep 25, 2024 at 12:34:38PM -0500, Rob Herring (Arm) wrote:
> The Freescale MU-MSI is an MSI provider, not an interrupt provider, so
> drop the "interrupt-controller" property. This fixes dtc "interrupt_provider"
> warning.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> ---
> If this is not correct, then #interrupt-cells needs to be added.
> ---
> .../devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml
> index 799ae5c3e32a..b5282c857f44 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,mu-msi.yaml
> @@ -62,8 +62,6 @@ properties:
> - const: processor-a-side
> - const: processor-b-side
>
> - interrupt-controller: true
> -
> msi-controller: true
>
> "#msi-cells":
> @@ -73,7 +71,6 @@ required:
> - compatible
> - reg
> - interrupts
> - - interrupt-controller
> - msi-controller
> - "#msi-cells"
>
> @@ -88,7 +85,6 @@ examples:
> compatible = "fsl,imx6sx-mu-msi";
> msi-controller;
> #msi-cells = <0>;
> - interrupt-controller;
> reg = <0x5d270000 0x10000>, /* A side */
> <0x5d300000 0x10000>; /* B side */
> reg-names = "processor-a-side", "processor-b-side";
> --
> 2.45.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: interrupt-controller: fsl,mu-msi: Drop "interrupt-controller" property
2024-09-25 17:34 [PATCH] dt-bindings: interrupt-controller: fsl,mu-msi: Drop "interrupt-controller" property Rob Herring (Arm)
2024-09-25 18:19 ` Frank Li
@ 2024-09-26 16:57 ` Conor Dooley
1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2024-09-26 16:57 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Thomas Gleixner, Krzysztof Kozlowski, Conor Dooley, Frank Li,
linux-kernel, devicetree
[-- Attachment #1: Type: text/plain, Size: 456 bytes --]
On Wed, Sep 25, 2024 at 12:34:38PM -0500, Rob Herring (Arm) wrote:
> The Freescale MU-MSI is an MSI provider, not an interrupt provider, so
> drop the "interrupt-controller" property. This fixes dtc "interrupt_provider"
> warning.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> If this is not correct, then #interrupt-cells needs to be added.
Seems it is correct, per Frank.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-26 16:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-25 17:34 [PATCH] dt-bindings: interrupt-controller: fsl,mu-msi: Drop "interrupt-controller" property Rob Herring (Arm)
2024-09-25 18:19 ` Frank Li
2024-09-26 16:57 ` Conor Dooley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox