Devicetree
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Wayne Chang <waynec@nvidia.com>,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: usb: cypress,cypd4226: Drop Tegra specific GPIO defines
Date: Thu, 26 Sep 2024 17:56:50 +0100	[thread overview]
Message-ID: <20240926-anybody-purify-f4befab2be4b@spud> (raw)
In-Reply-To: <20240925173449.1906586-1-robh@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1808 bytes --]

On Wed, Sep 25, 2024 at 12:34:48PM -0500, Rob Herring (Arm) wrote:
> The Tegra GPIO define is a problem for the magic code which extracts
> the examples and fixes up the interrupt provider. This was partially
> worked around by putting #interrupt-cells in the parent. However,
> that's incomplete and causes a warning when dtc "interrupt_provider"
> check is enabled. Just drop the Tegra specific define and simplify
> the example.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---

Right, there's no need to have a tegra specific thing here at all, its
just an example..
Acked-by: Conor Dooley <conor.dooley@microchip.com>


>  Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
> index 89fc9a434d05..0620d82508c1 100644
> --- a/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
> +++ b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
> @@ -61,18 +61,15 @@ additionalProperties: false
>  
>  examples:
>    - |
> -    #include <dt-bindings/gpio/tegra194-gpio.h>
>      #include <dt-bindings/interrupt-controller/arm-gic.h>
>      i2c {
>        #address-cells = <1>;
>        #size-cells = <0>;
> -      #interrupt-cells = <2>;
>  
>        typec@8 {
>          compatible = "cypress,cypd4226";
>          reg = <0x08>;
> -        interrupt-parent = <&gpio_aon>;
> -        interrupts = <TEGRA194_AON_GPIO(BB, 2) IRQ_TYPE_LEVEL_LOW>;
> +        interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
>          firmware-name = "nvidia,jetson-agx-xavier";
>          #address-cells = <1>;
>          #size-cells = <0>;
> -- 
> 2.45.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2024-09-26 16:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-25 17:34 [PATCH] dt-bindings: usb: cypress,cypd4226: Drop Tegra specific GPIO defines Rob Herring (Arm)
2024-09-26 16:56 ` Conor Dooley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240926-anybody-purify-f4befab2be4b@spud \
    --to=conor@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=waynec@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox