From: Conor Dooley <conor@kernel.org>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Nikita Shubin <nikita.shubin@maquefel.me>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: gpio: ep9301: Add missing "#interrupt-cells" to examples
Date: Thu, 26 Sep 2024 17:55:46 +0100 [thread overview]
Message-ID: <20240926-skintight-certified-298afaf44981@spud> (raw)
In-Reply-To: <20240925173510.1907048-1-robh@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1869 bytes --]
On Wed, Sep 25, 2024 at 12:35:10PM -0500, Rob Herring (Arm) wrote:
> From: Rob Herring <robh@kernel.org>
>
> Enabling dtc interrupt_provider check reveals the examples are missing
> the "#interrupt-cells" property as it is a dependency of
> "interrupt-controller".
>
> Some of the indentation is off, so fix that too.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml b/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml
> index daadfb4926c3..3a1079d6ee20 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-ep9301.yaml
> @@ -73,9 +73,10 @@ examples:
> reg-names = "data", "dir", "intr";
> gpio-controller;
> #gpio-cells = <2>;
> - interrupt-controller;
> - interrupt-parent = <&vic1>;
> - interrupts = <27>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + interrupt-parent = <&vic1>;
> + interrupts = <27>;
> };
>
> gpio@80840004 {
> @@ -87,6 +88,7 @@ examples:
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> + #interrupt-cells = <2>;
> interrupt-parent = <&vic1>;
> interrupts = <27>;
> };
> @@ -127,6 +129,7 @@ examples:
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> + #interrupt-cells = <2>;
> interrupts-extended = <&vic0 19>, <&vic0 20>,
> <&vic0 21>, <&vic0 22>,
> <&vic1 15>, <&vic1 16>,
> --
> 2.45.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2024-09-26 16:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 17:35 [PATCH] dt-bindings: gpio: ep9301: Add missing "#interrupt-cells" to examples Rob Herring (Arm)
2024-09-26 6:44 ` Nikita Shubin
2024-09-26 16:55 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240926-skintight-certified-298afaf44981@spud \
--to=conor@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita.shubin@maquefel.me \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox