devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] ARM: dts: renesas: fix BSC nodes
@ 2024-09-26 10:33 Wolfram Sang
  2024-09-26 10:33 ` [PATCH v2 1/2] ARM: dts: renesas: add proper node names to (L)BSC devices Wolfram Sang
  2024-09-26 10:33 ` [PATCH v2 2/2] ARM: dts: renesas: r8a7778: rename 'bsc' to 'lbsc' Wolfram Sang
  0 siblings, 2 replies; 6+ messages in thread
From: Wolfram Sang @ 2024-09-26 10:33 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Wolfram Sang, Conor Dooley, devicetree, Geert Uytterhoeven,
	Krzysztof Kozlowski, Magnus Damm, Rob Herring

While cleaning up the Genmai DTS, I stumbled upon further checks
regarding the (L)BSC. These patches fix them.

Change since v1:
 * drop the unit-address


Wolfram Sang (2):
  ARM: dts: renesas: add proper node names to (L)BSC devices
  ARM: dts: renesas: r8a7778: rename 'bsc' to 'lbsc'

 arch/arm/boot/dts/renesas/r7s72100.dtsi     | 2 +-
 arch/arm/boot/dts/renesas/r8a7778-bockw.dts | 2 +-
 arch/arm/boot/dts/renesas/r8a7778.dtsi      | 2 +-
 arch/arm/boot/dts/renesas/r8a7779.dtsi      | 2 +-
 arch/arm/boot/dts/renesas/r8a7792.dtsi      | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

-- 
2.45.2


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 1/2] ARM: dts: renesas: add proper node names to (L)BSC devices
  2024-09-26 10:33 [PATCH v2 0/2] ARM: dts: renesas: fix BSC nodes Wolfram Sang
@ 2024-09-26 10:33 ` Wolfram Sang
  2024-10-04 13:55   ` Geert Uytterhoeven
  2024-09-26 10:33 ` [PATCH v2 2/2] ARM: dts: renesas: r8a7778: rename 'bsc' to 'lbsc' Wolfram Sang
  1 sibling, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2024-09-26 10:33 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Wolfram Sang, Geert Uytterhoeven, Magnus Damm, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, devicetree

(L)BSC must have a "bus" node name [1] and no unit-address because
there is no reg-property. Fix these entries.

[1] lbsc: $nodename:0: 'lbsc' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$'

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/arm/boot/dts/renesas/r7s72100.dtsi | 2 +-
 arch/arm/boot/dts/renesas/r8a7778.dtsi  | 2 +-
 arch/arm/boot/dts/renesas/r8a7779.dtsi  | 2 +-
 arch/arm/boot/dts/renesas/r8a7792.dtsi  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/renesas/r7s72100.dtsi b/arch/arm/boot/dts/renesas/r7s72100.dtsi
index 07ffd9ec96cc..fa26e4a39fd7 100644
--- a/arch/arm/boot/dts/renesas/r7s72100.dtsi
+++ b/arch/arm/boot/dts/renesas/r7s72100.dtsi
@@ -36,7 +36,7 @@ b_clk: b {
 		clock-div = <3>;
 	};
 
-	bsc: bsc {
+	bsc: bus {
 		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
diff --git a/arch/arm/boot/dts/renesas/r8a7778.dtsi b/arch/arm/boot/dts/renesas/r8a7778.dtsi
index b80e832c9277..ab3e42bded8c 100644
--- a/arch/arm/boot/dts/renesas/r8a7778.dtsi
+++ b/arch/arm/boot/dts/renesas/r8a7778.dtsi
@@ -40,7 +40,7 @@ aliases {
 		spi2 = &hspi2;
 	};
 
-	bsc: bus@1c000000 {
+	bsc: bus {
 		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
diff --git a/arch/arm/boot/dts/renesas/r8a7779.dtsi b/arch/arm/boot/dts/renesas/r8a7779.dtsi
index 1944703cba4f..e437c22f452d 100644
--- a/arch/arm/boot/dts/renesas/r8a7779.dtsi
+++ b/arch/arm/boot/dts/renesas/r8a7779.dtsi
@@ -704,7 +704,7 @@ R8A7779_CLK_MMC1 R8A7779_CLK_MMC0
 		};
 	};
 
-	lbsc: lbsc {
+	lbsc: bus {
 		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
diff --git a/arch/arm/boot/dts/renesas/r8a7792.dtsi b/arch/arm/boot/dts/renesas/r8a7792.dtsi
index dd3bc32668b7..08cbe6c13cee 100644
--- a/arch/arm/boot/dts/renesas/r8a7792.dtsi
+++ b/arch/arm/boot/dts/renesas/r8a7792.dtsi
@@ -84,7 +84,7 @@ extal_clk: extal {
 		clock-frequency = <0>;
 	};
 
-	lbsc: lbsc {
+	lbsc: bus {
 		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 2/2] ARM: dts: renesas: r8a7778: rename 'bsc' to 'lbsc'
  2024-09-26 10:33 [PATCH v2 0/2] ARM: dts: renesas: fix BSC nodes Wolfram Sang
  2024-09-26 10:33 ` [PATCH v2 1/2] ARM: dts: renesas: add proper node names to (L)BSC devices Wolfram Sang
@ 2024-09-26 10:33 ` Wolfram Sang
  2024-10-04 13:57   ` Geert Uytterhoeven
  1 sibling, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2024-09-26 10:33 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Wolfram Sang, Geert Uytterhoeven, Magnus Damm, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, devicetree

R-Car Gen1 has an LBSC which has quite a different register set from the
former BSC. To match H1 with M1, rename the nodes to LBSC.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/arm/boot/dts/renesas/r8a7778-bockw.dts | 2 +-
 arch/arm/boot/dts/renesas/r8a7778.dtsi      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/renesas/r8a7778-bockw.dts b/arch/arm/boot/dts/renesas/r8a7778-bockw.dts
index a3f9d74e8877..d79095470a02 100644
--- a/arch/arm/boot/dts/renesas/r8a7778-bockw.dts
+++ b/arch/arm/boot/dts/renesas/r8a7778-bockw.dts
@@ -61,7 +61,7 @@ sndcodec: simple-audio-card,codec {
 	};
 };
 
-&bsc {
+&lbsc {
 	flash@0 {
 		compatible = "cfi-flash";
 		reg = <0x0 0x04000000>;
diff --git a/arch/arm/boot/dts/renesas/r8a7778.dtsi b/arch/arm/boot/dts/renesas/r8a7778.dtsi
index ab3e42bded8c..859dd29dfce3 100644
--- a/arch/arm/boot/dts/renesas/r8a7778.dtsi
+++ b/arch/arm/boot/dts/renesas/r8a7778.dtsi
@@ -40,7 +40,7 @@ aliases {
 		spi2 = &hspi2;
 	};
 
-	bsc: bus {
+	lbsc: bus {
 		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 1/2] ARM: dts: renesas: add proper node names to (L)BSC devices
  2024-09-26 10:33 ` [PATCH v2 1/2] ARM: dts: renesas: add proper node names to (L)BSC devices Wolfram Sang
@ 2024-10-04 13:55   ` Geert Uytterhoeven
  0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2024-10-04 13:55 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: linux-renesas-soc, Magnus Damm, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, devicetree

On Thu, Sep 26, 2024 at 12:33 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> (L)BSC must have a "bus" node name [1] and no unit-address because
> there is no reg-property. Fix these entries.
>
> [1] lbsc: $nodename:0: 'lbsc' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$'
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.13.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 2/2] ARM: dts: renesas: r8a7778: rename 'bsc' to 'lbsc'
  2024-09-26 10:33 ` [PATCH v2 2/2] ARM: dts: renesas: r8a7778: rename 'bsc' to 'lbsc' Wolfram Sang
@ 2024-10-04 13:57   ` Geert Uytterhoeven
  2024-10-05  7:55     ` Wolfram Sang
  0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2024-10-04 13:57 UTC (permalink / raw)
  To: Wolfram Sang
  Cc: linux-renesas-soc, Geert Uytterhoeven, Magnus Damm, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, devicetree

On Thu, Sep 26, 2024 at 12:33 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> R-Car Gen1 has an LBSC which has quite a different register set from the
> former BSC. To match H1 with M1, rename the nodes to LBSC.

M1 with H1?

>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.13.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 2/2] ARM: dts: renesas: r8a7778: rename 'bsc' to 'lbsc'
  2024-10-04 13:57   ` Geert Uytterhoeven
@ 2024-10-05  7:55     ` Wolfram Sang
  0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2024-10-05  7:55 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: linux-renesas-soc, Geert Uytterhoeven, Magnus Damm, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, devicetree

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

On Fri, Oct 04, 2024 at 03:57:01PM +0200, Geert Uytterhoeven wrote:
> On Thu, Sep 26, 2024 at 12:33 PM Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
> > R-Car Gen1 has an LBSC which has quite a different register set from the
> > former BSC. To match H1 with M1, rename the nodes to LBSC.
> 
> M1 with H1?

Yes. Argh, M1 numbering (7778) is before H1 (7779), grmbl...


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-10-05  7:55 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-26 10:33 [PATCH v2 0/2] ARM: dts: renesas: fix BSC nodes Wolfram Sang
2024-09-26 10:33 ` [PATCH v2 1/2] ARM: dts: renesas: add proper node names to (L)BSC devices Wolfram Sang
2024-10-04 13:55   ` Geert Uytterhoeven
2024-09-26 10:33 ` [PATCH v2 2/2] ARM: dts: renesas: r8a7778: rename 'bsc' to 'lbsc' Wolfram Sang
2024-10-04 13:57   ` Geert Uytterhoeven
2024-10-05  7:55     ` Wolfram Sang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).