* [PATCH v2] dt-bindings: power/supply: qcom,pmi8998-charger: Drop incorrect "#interrupt-cells" from example
@ 2024-09-26 21:37 Rob Herring (Arm)
2024-09-27 9:35 ` Krzysztof Kozlowski
2024-10-16 21:41 ` Sebastian Reichel
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2024-09-26 21:37 UTC (permalink / raw)
To: Sebastian Reichel, Krzysztof Kozlowski, Conor Dooley,
Caleb Connolly
Cc: linux-pm, devicetree, linux-kernel
Enabling dtc interrupt_provider check reveals the example is missing
the "interrupt-controller" property as it is a dependency of
"#interrupt-cells". However, the PMIC parent node is not an interrupt
controller at all, so the "#interrupt-cells" is erroneous.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
v2:
- Drop "#interrupt-cells" rather than add "interrupt-controller"
---
.../devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
index 277c47e048b6..a0f9d49ff8fb 100644
--- a/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
+++ b/Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
@@ -60,7 +60,6 @@ examples:
pmic {
#address-cells = <1>;
#size-cells = <0>;
- #interrupt-cells = <4>;
charger@1000 {
compatible = "qcom,pmi8998-charger";
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] dt-bindings: power/supply: qcom,pmi8998-charger: Drop incorrect "#interrupt-cells" from example
2024-09-26 21:37 [PATCH v2] dt-bindings: power/supply: qcom,pmi8998-charger: Drop incorrect "#interrupt-cells" from example Rob Herring (Arm)
@ 2024-09-27 9:35 ` Krzysztof Kozlowski
2024-10-16 21:41 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-09-27 9:35 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Sebastian Reichel, Krzysztof Kozlowski, Conor Dooley,
Caleb Connolly, linux-pm, devicetree, linux-kernel
On Thu, Sep 26, 2024 at 04:37:26PM -0500, Rob Herring (Arm) wrote:
> Enabling dtc interrupt_provider check reveals the example is missing
> the "interrupt-controller" property as it is a dependency of
> "#interrupt-cells". However, the PMIC parent node is not an interrupt
> controller at all, so the "#interrupt-cells" is erroneous.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> v2:
> - Drop "#interrupt-cells" rather than add "interrupt-controller"
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: power/supply: qcom,pmi8998-charger: Drop incorrect "#interrupt-cells" from example
2024-09-26 21:37 [PATCH v2] dt-bindings: power/supply: qcom,pmi8998-charger: Drop incorrect "#interrupt-cells" from example Rob Herring (Arm)
2024-09-27 9:35 ` Krzysztof Kozlowski
@ 2024-10-16 21:41 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2024-10-16 21:41 UTC (permalink / raw)
To: Sebastian Reichel, Krzysztof Kozlowski, Conor Dooley,
Caleb Connolly, Rob Herring (Arm)
Cc: linux-pm, devicetree, linux-kernel
On Thu, 26 Sep 2024 16:37:26 -0500, Rob Herring (Arm) wrote:
> Enabling dtc interrupt_provider check reveals the example is missing
> the "interrupt-controller" property as it is a dependency of
> "#interrupt-cells". However, the PMIC parent node is not an interrupt
> controller at all, so the "#interrupt-cells" is erroneous.
>
>
Applied, thanks!
[1/1] dt-bindings: power/supply: qcom,pmi8998-charger: Drop incorrect "#interrupt-cells" from example
commit: 5d121065a6993e5ab4ccc0c9629241f256d11ad0
Best regards,
--
Sebastian Reichel <sebastian.reichel@collabora.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-16 21:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-26 21:37 [PATCH v2] dt-bindings: power/supply: qcom,pmi8998-charger: Drop incorrect "#interrupt-cells" from example Rob Herring (Arm)
2024-09-27 9:35 ` Krzysztof Kozlowski
2024-10-16 21:41 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).