[PATCH 0/4] ARM: dts: renesas: use interrupts-extended for gpio-keys

[PATCH 0/4] ARM: dts: renesas: use interrupts-extended for gpio-keys

[Wolfram Sang]

Since inheriting interrupt-parents is discouraged, use
interrupts-extended to describe the keys in Renesas boards.

This is the only conversion I am interested in. You can have the rest,
Geert ;)


Wolfram Sang (4):
  ARM: dts: renesas: marzen: use interrupts-extended for gpio-keys
  ARM: dts: renesas: genmai: use interrupts-extended for gpio-keys
  ARM: dts: renesas: rskrza1: use interrupts-extended for gpio-keys
  ARM: dts: renesas: rza2mevb: use interrupts-extended for gpio-keys

 arch/arm/boot/dts/renesas/r7s72100-genmai.dts  | 3 +--
 arch/arm/boot/dts/renesas/r7s72100-rskrza1.dts | 9 +++------
 arch/arm/boot/dts/renesas/r7s9210-rza2mevb.dts | 3 +--
 arch/arm/boot/dts/renesas/r8a7779-marzen.dts   | 6 ++----
 4 files changed, 7 insertions(+), 14 deletions(-)

-- 
2.45.2

[PATCH 1/4] ARM: dts: renesas: marzen: use interrupts-extended for gpio-keys

[Wolfram Sang]

Using the inherited interrupt-parent is discouraged. Use
interrupts-extended to fully describe the interrupt.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/arm/boot/dts/renesas/r8a7779-marzen.dts | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/renesas/r8a7779-marzen.dts b/arch/arm/boot/dts/renesas/r8a7779-marzen.dts
index 9b13e8d1538b..b1715bf04d84 100644
--- a/arch/arm/boot/dts/renesas/r8a7779-marzen.dts
+++ b/arch/arm/boot/dts/renesas/r8a7779-marzen.dts
@@ -58,17 +58,15 @@ keypad-0 {
 		pinctrl-0 = <&keypad0_pins>;
 		pinctrl-names = "default";
 
-		interrupt-parent = <&gpio0>;
-
 		key-1 {
-			interrupts = <17 IRQ_TYPE_EDGE_FALLING>;
+			interrupts-extended = <&gpio0 17 IRQ_TYPE_EDGE_FALLING>;
 			linux,code = <KEY_1>;
 			label = "SW1-1";
 			wakeup-source;
 			debounce-interval = <20>;
 		};
 		key-2 {
-			interrupts = <18 IRQ_TYPE_EDGE_FALLING>;
+			interrupts-extended = <&gpio0 18 IRQ_TYPE_EDGE_FALLING>;
 			linux,code = <KEY_2>;
 			label = "SW1-2";
 			wakeup-source;
-- 
2.45.2

Re: [PATCH 1/4] ARM: dts: renesas: marzen: use interrupts-extended for gpio-keys

[Krzysztof Kozlowski]

On 27/09/2024 11:54, Wolfram Sang wrote:
> Using the inherited interrupt-parent is discouraged. Use
> interrupts-extended to fully describe the interrupt.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  arch/arm/boot/dts/renesas/r8a7779-marzen.dts | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

Re: [PATCH 1/4] ARM: dts: renesas: marzen: use interrupts-extended for gpio-keys

[Geert Uytterhoeven]

On Fri, Sep 27, 2024 at 11:54 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Using the inherited interrupt-parent is discouraged. Use
> interrupts-extended to fully describe the interrupt.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.13.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH 2/4] ARM: dts: renesas: genmai: use interrupts-extended for gpio-keys

[Wolfram Sang]

Use the more concise interrupts-extended property to fully describe the
interrupt.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/arm/boot/dts/renesas/r7s72100-genmai.dts | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/renesas/r7s72100-genmai.dts b/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
index d0b2b4ea1734..e3fb54616537 100644
--- a/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
+++ b/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
@@ -67,8 +67,7 @@ keyboard {
 
 		key-1 {
 			/* JP3 must be set to 1-2 (default) */
-			interrupt-parent = <&irqc>;
-			interrupts = <6 IRQ_TYPE_EDGE_BOTH>;
+			interrupts-extended = <&irqc 6 IRQ_TYPE_EDGE_BOTH>;
 			linux,code = <KEY_1>;
 			label = "SW6,SW7";
 			wakeup-source;
-- 
2.45.2

Re: [PATCH 2/4] ARM: dts: renesas: genmai: use interrupts-extended for gpio-keys

[Krzysztof Kozlowski]

On 27/09/2024 11:54, Wolfram Sang wrote:
> Use the more concise interrupts-extended property to fully describe the
> interrupt.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  arch/arm/boot/dts/renesas/r7s72100-genmai.dts | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

Re: [PATCH 2/4] ARM: dts: renesas: genmai: use interrupts-extended for gpio-keys

[Geert Uytterhoeven]

Hi Wolfram,

On Fri, Sep 27, 2024 at 11:54 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Use the more concise interrupts-extended property to fully describe the
> interrupt.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
> +++ b/arch/arm/boot/dts/renesas/r7s72100-genmai.dts
> @@ -67,8 +67,7 @@ keyboard {
>
>                 key-1 {
>                         /* JP3 must be set to 1-2 (default) */
> -                       interrupt-parent = <&irqc>;
> -                       interrupts = <6 IRQ_TYPE_EDGE_BOTH>;
> +                       interrupts-extended = <&irqc 6 IRQ_TYPE_EDGE_BOTH>;
>                         linux,code = <KEY_1>;
>                         label = "SW6,SW7";
>                         wakeup-source;

Given the changed code was introduced only very recently, I will fold this
into "ARM: dts: renesas: genmai: Define keyboard switch".

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH 3/4] ARM: dts: renesas: rskrza1: use interrupts-extended for gpio-keys

[Wolfram Sang]

Use the more concise interrupts-extended property to fully describe the
interrupt.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/arm/boot/dts/renesas/r7s72100-rskrza1.dts | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/renesas/r7s72100-rskrza1.dts b/arch/arm/boot/dts/renesas/r7s72100-rskrza1.dts
index b547216d4801..9ff3f04c1b02 100644
--- a/arch/arm/boot/dts/renesas/r7s72100-rskrza1.dts
+++ b/arch/arm/boot/dts/renesas/r7s72100-rskrza1.dts
@@ -78,24 +78,21 @@ keyboard {
 		pinctrl-0 = <&keyboard_pins>;
 
 		key-1 {
-			interrupt-parent = <&irqc>;
-			interrupts = <3 IRQ_TYPE_EDGE_BOTH>;
+			interrupts-extended = <&irqc 3 IRQ_TYPE_EDGE_BOTH>;
 			linux,code = <KEY_1>;
 			label = "SW1";
 			wakeup-source;
 		};
 
 		key-2 {
-			interrupt-parent = <&irqc>;
-			interrupts = <2 IRQ_TYPE_EDGE_BOTH>;
+			interrupts-extended = <&irqc 2 IRQ_TYPE_EDGE_BOTH>;
 			linux,code = <KEY_2>;
 			label = "SW2";
 			wakeup-source;
 		};
 
 		key-3 {
-			interrupt-parent = <&irqc>;
-			interrupts = <5 IRQ_TYPE_EDGE_BOTH>;
+			interrupts-extended = <&irqc 5 IRQ_TYPE_EDGE_BOTH>;
 			linux,code = <KEY_3>;
 			label = "SW3";
 			wakeup-source;
-- 
2.45.2

Re: [PATCH 3/4] ARM: dts: renesas: rskrza1: use interrupts-extended for gpio-keys

[Krzysztof Kozlowski]

On 27/09/2024 11:54, Wolfram Sang wrote:
> Use the more concise interrupts-extended property to fully describe the
> interrupt.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---

The code is correct, but are you sure this is not just a churn?

Best regards,
Krzysztof

Re: [PATCH 3/4] ARM: dts: renesas: rskrza1: use interrupts-extended for gpio-keys

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 135 bytes --]


> The code is correct, but are you sure this is not just a churn?

A little, but I prefer the consistency among Renesas boards here.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 3/4] ARM: dts: renesas: rskrza1: use interrupts-extended for gpio-keys

[Geert Uytterhoeven]

On Fri, Sep 27, 2024 at 11:54 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Use the more concise interrupts-extended property to fully describe the
> interrupt.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.13.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH 4/4] ARM: dts: renesas: rza2mevb: use interrupts-extended for gpio-keys

[Wolfram Sang]

Use the more concise interrupts-extended property to fully describe the
interrupt.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/arm/boot/dts/renesas/r7s9210-rza2mevb.dts | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/renesas/r7s9210-rza2mevb.dts b/arch/arm/boot/dts/renesas/r7s9210-rza2mevb.dts
index cd2324b8e8ff..f69a7fe56b6e 100644
--- a/arch/arm/boot/dts/renesas/r7s9210-rza2mevb.dts
+++ b/arch/arm/boot/dts/renesas/r7s9210-rza2mevb.dts
@@ -55,8 +55,7 @@ keyboard {
 		pinctrl-0 = <&keyboard_pins>;
 
 		key-3 {
-			interrupt-parent = <&irqc>;
-			interrupts = <0 IRQ_TYPE_EDGE_BOTH>;
+			interrupts-extended = <&irqc 0 IRQ_TYPE_EDGE_BOTH>;
 			linux,code = <KEY_3>;
 			label = "SW3";
 			wakeup-source;
-- 
2.45.2

Re: [PATCH 4/4] ARM: dts: renesas: rza2mevb: use interrupts-extended for gpio-keys

[Geert Uytterhoeven]

On Fri, Sep 27, 2024 at 11:54 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Use the more concise interrupts-extended property to fully describe the
> interrupt.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.13.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds