From: Jonathan Cameron <jic23@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Auchter <michael.auchter@ni.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: dac: adi,ad56xx: Fix duplicate compatible strings
Date: Sat, 28 Sep 2024 14:50:49 +0100 [thread overview]
Message-ID: <20240928145049.74dabfee@jic23-huawei> (raw)
In-Reply-To: <CAL_Jsq+oJ71ncJOLH_ozyKgO8N0Dq85nvXM00cpOE24wUprXjQ@mail.gmail.com>
On Mon, 16 Sep 2024 10:22:19 -0500
Rob Herring <robh@kernel.org> wrote:
> On Sat, Sep 14, 2024 at 9:18 AM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > On Tue, 10 Sep 2024 18:44:39 -0500
> > "Rob Herring (Arm)" <robh@kernel.org> wrote:
> >
> > > adi,ad5686.yaml and adi,ad5696.yaml duplicate all the I2C device
> > > compatible strings with the exception of "adi,ad5337r". Since
> > > adi,ad5686.yaml references spi-peripheral-props.yaml, drop the I2C
> > > devices from it making it only SPI devices. Update the titles to make
> > > the distinction clear.
> > >
> > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> > Is this an urgent thing, or can it wait for the merge window after next?
> > For now I've queued it up for then in my testing branch but can yank it
> > out and send it as a fix after rc1 if that is useful.
>
> Sooner would be better. It's now a warning in dtschema main branch.
> The issue is not so much the duplication, but that which schema gets
> applied is not deterministic.
Shifted it to my fixes-togreg branch. I'll do a pull request for that
fairly soon (once rc1 is out and it's had a little soak in next)
Thanks,
Jonathan
>
> Rob
prev parent reply other threads:[~2024-09-28 13:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 23:44 [PATCH] dt-bindings: iio: dac: adi,ad56xx: Fix duplicate compatible strings Rob Herring (Arm)
2024-09-11 7:15 ` Nuno Sá
2024-09-11 19:12 ` Conor Dooley
2024-09-14 14:18 ` Jonathan Cameron
2024-09-16 15:22 ` Rob Herring
2024-09-28 13:50 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240928145049.74dabfee@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.auchter@ni.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).