devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Rishi Gupta <gupt21@gmail.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH v2 01/10] iio: light: veml6030: fix ALS sensor resolution
Date: Sat, 28 Sep 2024 17:12:21 +0100	[thread overview]
Message-ID: <20240928171221.2b57638d@jic23-huawei> (raw)
In-Reply-To: <20240923-veml6035-v2-1-58c72a0df31c@gmail.com>

On Mon, 23 Sep 2024 00:17:49 +0200
Javier Carrasco <javier.carrasco.cruz@gmail.com> wrote:

> The driver still uses the sensor resolution provided in the datasheet
> until Rev. 1.6, 28-Apr-2022, which was updated with Rev 1.7,
> 28-Nov-2023. The original ambient light resolution has been updated from
> 0.0036 lx/ct to 0.0042 lx/ct, which is the value that can be found in
> the current device datasheet.
> 
> Update the default resolution for IT = 100 ms and GAIN = 1/8 from the
> original 4608 mlux/cnt to the current value from the "Resolution and
> maximum detection range" table (Application Note 84367, page 5), 5376
> mlux/cnt.
> 
> Cc: stable@vger.kernel.org
> Fixes: 7b779f573c48 ("iio: light: add driver for veml6030 ambient light sensor")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Applied this patch to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

> ---
>  drivers/iio/light/veml6030.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/veml6030.c b/drivers/iio/light/veml6030.c
> index 4c436c5e0787..a3dfe56b7eec 100644
> --- a/drivers/iio/light/veml6030.c
> +++ b/drivers/iio/light/veml6030.c
> @@ -780,7 +780,7 @@ static int veml6030_hw_init(struct iio_dev *indio_dev)
>  
>  	/* Cache currently active measurement parameters */
>  	data->cur_gain = 3;
> -	data->cur_resolution = 4608;
> +	data->cur_resolution = 5376;
>  	data->cur_integration_time = 3;
>  
>  	return ret;
> 


  reply	other threads:[~2024-09-28 16:12 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-22 22:17 [PATCH v2 00/10] iio: light: veml6030: fix issues and add support for veml6035 Javier Carrasco
2024-09-22 22:17 ` [PATCH v2 01/10] iio: light: veml6030: fix ALS sensor resolution Javier Carrasco
2024-09-28 16:12   ` Jonathan Cameron [this message]
2024-09-22 22:17 ` [PATCH v2 02/10] iio: light: veml6030: add set up delay after any power on sequence Javier Carrasco
2024-09-28 16:13   ` Jonathan Cameron
2024-09-22 22:17 ` [PATCH v2 03/10] iio: light: veml6030: use dev_err_probe() Javier Carrasco
2024-09-22 22:17 ` [PATCH v2 04/10] dt-bindings: iio: light: veml6030: add vdd-supply property Javier Carrasco
2024-09-24 10:06   ` Krzysztof Kozlowski
2024-09-27 18:02     ` Javier Carrasco
2024-09-22 22:17 ` [PATCH v2 05/10] iio: light: veml6030: add support for a regulator Javier Carrasco
2024-09-22 22:17 ` [PATCH v2 06/10] iio: light: veml6030: use read_avail() for available attributes Javier Carrasco
2024-09-28 16:19   ` Jonathan Cameron
2024-09-29 18:45     ` Javier Carrasco
2024-09-30  8:45       ` Jonathan Cameron
2024-09-22 22:17 ` [PATCH v2 07/10] iio: light: veml6030: drop processed info for white channel Javier Carrasco
2024-09-28 16:20   ` Jonathan Cameron
2024-09-22 22:17 ` [PATCH v2 08/10] iio: light: veml6030: power off device in probe error paths Javier Carrasco
2024-09-28 16:22   ` Jonathan Cameron
2024-09-22 22:17 ` [PATCH v2 09/10] dt-bindings: iio: light: veml6030: add veml6035 Javier Carrasco
2024-09-22 22:17 ` [PATCH v2 10/10] iio: light: veml6030: add support for veml6035 Javier Carrasco
2024-09-28 16:25   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240928171221.2b57638d@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gupt21@gmail.com \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).