From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Javier Carrasco <javier.carrasco.cruz@gmail.com>
Subject: [PATCH 7/7] iio: light: veml6070: use dev_err_probe in probe function
Date: Sun, 29 Sep 2024 22:38:52 +0200 [thread overview]
Message-ID: <20240929-veml6070-cleanup-v1-7-a9350341a646@gmail.com> (raw)
In-Reply-To: <20240929-veml6070-cleanup-v1-0-a9350341a646@gmail.com>
Drop the common 'dev_err() + return' combination in the probe function
and use 'return dev_err_probe()' instead.
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
drivers/iio/light/veml6070.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/light/veml6070.c b/drivers/iio/light/veml6070.c
index 8d02899028d8..6221d07aa840 100644
--- a/drivers/iio/light/veml6070.c
+++ b/drivers/iio/light/veml6070.c
@@ -168,10 +168,9 @@ static int veml6070_probe(struct i2c_client *client)
return ret;
data->client2 = i2c_new_dummy_device(client->adapter, VEML6070_ADDR_DATA_LSB);
- if (IS_ERR(data->client2)) {
- dev_err(&client->dev, "i2c device for second chip address failed\n");
- return PTR_ERR(data->client2);
- }
+ if (IS_ERR(data->client2))
+ return dev_err_probe(&client->dev, PTR_ERR(data->client2),
+ "i2c device for second chip address failed\n");
data->config = VEML6070_IT_10 | VEML6070_COMMAND_RSRVD |
VEML6070_COMMAND_SD;
--
2.43.0
next prev parent reply other threads:[~2024-09-29 20:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-29 20:38 [PATCH 0/7] iio: light: veml6070: update code to current IIO best practices Javier Carrasco
2024-09-29 20:38 ` [PATCH 1/7] iio: light: veml6070: add action for i2c_unregister_device Javier Carrasco
2024-09-29 20:38 ` [PATCH 2/7] iio: light: veml6070: use guard to handle mutex Javier Carrasco
2024-09-29 20:38 ` [PATCH 3/7] iio: light: veml6070: use device managed iio_device_register Javier Carrasco
2024-09-29 20:38 ` [PATCH 4/7] iio: light: veml6070: add support for a regulator Javier Carrasco
2024-09-29 20:38 ` [PATCH 5/7] dt-bindings: iio: light: vishay,veml6075: add vishay,veml6070 Javier Carrasco
2024-09-30 7:01 ` Krzysztof Kozlowski
2024-09-29 20:38 ` [PATCH 6/7] iio: light: veml6070: add devicetree support Javier Carrasco
2024-09-30 9:00 ` Jonathan Cameron
2024-09-29 20:38 ` Javier Carrasco [this message]
2024-09-30 9:00 ` [PATCH 0/7] iio: light: veml6070: update code to current IIO best practices Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240929-veml6070-cleanup-v1-7-a9350341a646@gmail.com \
--to=javier.carrasco.cruz@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox