From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AD37184539; Mon, 30 Sep 2024 09:19:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727687966; cv=none; b=fEYTWDKSltuAc1JDTDyzm5g9khG4kTuAnPMgU9PQHnhA5PJhagNbDmyCm1ZZZQq6znGa6Q2+eI8KMl14FXqrnA35BcpC54QcFgT1kOn1oAYX/7uiy3NvMb7rgIMbrAj3QWdw482Qd6+gB20PEdSpGaD5OPCmLE7Oz1dKlXtZ9wY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727687966; c=relaxed/simple; bh=lmWcA3krObUEcSgVI8XOtUqUtyX3hirROSDHuk05VoU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mU0FpkIHRbcWvDnBmxvFJJ+2QHwAOd4+Y3l/bHspLkj+TU9ZH8DrgnFW2+txsQB/ZUSB+ivBIc1bftM2+Y4wBsUmJoA2c2ZDpW6wAYAB1ifzLoiA7IwrgeXc1OXWNOTdUfbNqfSDFIuUVKCcyoANBsyIKefke/oNkKtcT7oMbZo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=aryuuA52; arc=none smtp.client-ip=217.70.183.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="aryuuA52" Received: by mail.gandi.net (Postfix) with ESMTPSA id 5E4A62000F; Mon, 30 Sep 2024 09:19:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1727687957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=08CqMCR40QeByk4ty6nskGAarldWWiP1HXvLuo/jmq8=; b=aryuuA522t22D8cTiaR7wOrrrGfDITc/83JLG7Jb/SzmS/GFsmyD7kPvEqzaqvtRZ8JhTh DqvJ9QEo9K3e69VI9MQzf5f7FArwYHbcNVyeVG+DR6qkPaV9N6OytyFv6MUqJu1Rk6a41Q pjJMF0s8zolKg0F6Nkfaudp+au93S7qmnwUEtp/yLsAXPUN1FE1V76z7Eqn8sqxJgeUc0r Uk8TAT0Y0oeEplXvLsoUieX6TaC95JvVNjj3QP/S9jE4akg/aMvrGhoIrhND4RdKknlP1s ImKyhYXYuGirdnUn6QiePxg5j62zCSjKN5QPRf117LZiWPzRkWg9Dzi5pGtqtA== Date: Mon, 30 Sep 2024 11:19:14 +0200 From: Miquel Raynal To: "Peng Fan (OSS)" Cc: Tudor Ambarus , Pratyush Yadav , Michael Walle , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Marco Felsch , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Peng Fan Subject: Re: [PATCH v2 2/3] mtd: spi-nor: support vcc-supply regulator Message-ID: <20240930111914.4b412581@xps-13> In-Reply-To: <20240930-spi-v2-2-ed7f6bcbe0df@nxp.com> References: <20240930-spi-v2-0-ed7f6bcbe0df@nxp.com> <20240930-spi-v2-2-ed7f6bcbe0df@nxp.com> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hi, peng.fan@oss.nxp.com wrote on Mon, 30 Sep 2024 17:22:25 +0800: > From: Peng Fan >=20 > SPI NOR flashes needs power supply to work properly. The power supply > maybe software controllable per board design. So add the support > for an vcc-supply regulator. >=20 > Signed-off-by: Peng Fan > --- > drivers/mtd/spi-nor/core.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c > index 9d6e85bf227b..5249c8b13916 100644 > --- a/drivers/mtd/spi-nor/core.c > +++ b/drivers/mtd/spi-nor/core.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -3462,6 +3463,10 @@ int spi_nor_scan(struct spi_nor *nor, const char *= name, > if (!nor->bouncebuf) > return -ENOMEM; > =20 > + ret =3D devm_regulator_get_enable(dev, "vcc"); _optional ? > + if (ret) > + return ret; > + > ret =3D spi_nor_hw_reset(nor); > if (ret) > return ret; >=20 Thanks, Miqu=C3=A8l