* [PATCH 0/3] dmaengine: sh: rz-dmac: add r7s72100 support @ 2024-09-30 14:59 Wolfram Sang 2024-09-30 14:59 ` [PATCH 2/3] dt-bindings: dma: rz-dmac: Document RZ/A1L SoC Wolfram Sang 0 siblings, 1 reply; 5+ messages in thread From: Wolfram Sang @ 2024-09-30 14:59 UTC (permalink / raw) To: linux-renesas-soc Cc: Biju Das, Wolfram Sang, Conor Dooley, devicetree, dmaengine, Geert Uytterhoeven, Krzysztof Kozlowski, Magnus Damm, Philipp Zabel, Rob Herring, Vinod Koul When activating good old Genmai board for regression testing, I found out that not much is needed to activate the DMA controller for A1L. Which makes sense, because the driver was initially written for this SoC. Let it come home ;) Patch 1 is a generic fix. The other patches are the actual enablement. A branch with DTS additions for MMCIF can be found here: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/genmai-upstreaming These will be upstreamed once the driver parts are in next. Adding SDHI is still WIP because RZ/A1L usage exposes a SDHI driver bug. So much for the value of regression testing... Wolfram Sang (3): dmaengine: sh: rz-dmac: handle configs where one address is zero dt-bindings: dma: rz-dmac: Document RZ/A1L SoC dmaengine: sh: rz-dmac: add r7s72100 support .../bindings/dma/renesas,rz-dmac.yaml | 27 +++++++++++++------ drivers/dma/sh/Kconfig | 6 ++--- drivers/dma/sh/rz-dmac.c | 27 ++++++++++--------- 3 files changed, 37 insertions(+), 23 deletions(-) -- 2.45.2 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/3] dt-bindings: dma: rz-dmac: Document RZ/A1L SoC 2024-09-30 14:59 [PATCH 0/3] dmaengine: sh: rz-dmac: add r7s72100 support Wolfram Sang @ 2024-09-30 14:59 ` Wolfram Sang 2024-09-30 15:18 ` Geert Uytterhoeven 0 siblings, 1 reply; 5+ messages in thread From: Wolfram Sang @ 2024-09-30 14:59 UTC (permalink / raw) To: linux-renesas-soc Cc: Biju Das, Wolfram Sang, Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven, Magnus Damm, dmaengine, devicetree Document the Renesas RZ/A1L DMAC block. This one does not require clocks and resets, so update the bindings accordingly. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- .../bindings/dma/renesas,rz-dmac.yaml | 27 +++++++++++++------ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml b/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml index ca24cf48769f..e05aaf24eb64 100644 --- a/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml +++ b/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml @@ -4,18 +4,16 @@ $id: http://devicetree.org/schemas/dma/renesas,rz-dmac.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Renesas RZ/{G2L,G2UL,V2L} DMA Controller +title: Renesas RZ/{A1L,G2L,G2UL,V2L} DMA Controller maintainers: - Biju Das <biju.das.jz@bp.renesas.com> -allOf: - - $ref: dma-controller.yaml# - properties: compatible: items: - enum: + - renesas,r7s72100-dmac # RZ/A1L - renesas,r9a07g043-dmac # RZ/G2UL and RZ/Five - renesas,r9a07g044-dmac # RZ/G2{L,LC} - renesas,r9a07g054-dmac # RZ/V2L @@ -93,13 +91,26 @@ required: - reg - interrupts - interrupt-names - - clocks - - clock-names - '#dma-cells' - dma-channels - power-domains - - resets - - reset-names + +allOf: + - $ref: dma-controller.yaml# + + - if: + not: + properties: + compatible: + contains: + enum: + - renesas,r7s72100-dmac + then: + required: + - clocks + - clock-names + - resets + - reset-names additionalProperties: false -- 2.45.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3] dt-bindings: dma: rz-dmac: Document RZ/A1L SoC 2024-09-30 14:59 ` [PATCH 2/3] dt-bindings: dma: rz-dmac: Document RZ/A1L SoC Wolfram Sang @ 2024-09-30 15:18 ` Geert Uytterhoeven 2024-09-30 19:26 ` Wolfram Sang 0 siblings, 1 reply; 5+ messages in thread From: Geert Uytterhoeven @ 2024-09-30 15:18 UTC (permalink / raw) To: Wolfram Sang Cc: linux-renesas-soc, Biju Das, Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven, Magnus Damm, dmaengine, devicetree Hi Wolfram, Thanks for your patch! On Mon, Sep 30, 2024 at 5:00 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > Document the Renesas RZ/A1L DMAC block. This one does not require clocks RZ/A1H > and resets, so update the bindings accordingly. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- a/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml > +++ b/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml > @@ -4,18 +4,16 @@ > $id: http://devicetree.org/schemas/dma/renesas,rz-dmac.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Renesas RZ/{G2L,G2UL,V2L} DMA Controller > +title: Renesas RZ/{A1L,G2L,G2UL,V2L} DMA Controller "A1H", or perhaps just "RZ-series"? > > maintainers: > - Biju Das <biju.das.jz@bp.renesas.com> > > -allOf: > - - $ref: dma-controller.yaml# > - > properties: > compatible: > items: > - enum: > + - renesas,r7s72100-dmac # RZ/A1L RZ/A1H The rest LGTM. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3] dt-bindings: dma: rz-dmac: Document RZ/A1L SoC 2024-09-30 15:18 ` Geert Uytterhoeven @ 2024-09-30 19:26 ` Wolfram Sang 2024-10-01 7:44 ` Biju Das 0 siblings, 1 reply; 5+ messages in thread From: Wolfram Sang @ 2024-09-30 19:26 UTC (permalink / raw) To: Geert Uytterhoeven Cc: linux-renesas-soc, Biju Das, Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven, Magnus Damm, dmaengine, devicetree [-- Attachment #1: Type: text/plain, Size: 296 bytes --] > > Document the Renesas RZ/A1L DMAC block. This one does not require clocks > > RZ/A1H Argh, I managed to mix it up again. Thanks! > > -title: Renesas RZ/{G2L,G2UL,V2L} DMA Controller > > +title: Renesas RZ/{A1L,G2L,G2UL,V2L} DMA Controller I'd vote for your suggestion. Biju? [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 2/3] dt-bindings: dma: rz-dmac: Document RZ/A1L SoC 2024-09-30 19:26 ` Wolfram Sang @ 2024-10-01 7:44 ` Biju Das 0 siblings, 0 replies; 5+ messages in thread From: Biju Das @ 2024-10-01 7:44 UTC (permalink / raw) To: Wolfram Sang, Geert Uytterhoeven Cc: linux-renesas-soc@vger.kernel.org, Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven, Magnus Damm, dmaengine@vger.kernel.org, devicetree@vger.kernel.org Hi Wolfram, > -----Original Message----- > From: Wolfram Sang <wsa+renesas@sang-engineering.com> > Sent: Monday, September 30, 2024 8:26 PM > Subject: Re: [PATCH 2/3] dt-bindings: dma: rz-dmac: Document RZ/A1L SoC > > > > > Document the Renesas RZ/A1L DMAC block. This one does not require clocks > > > > RZ/A1H > > Argh, I managed to mix it up again. Thanks! > > > > -title: Renesas RZ/{G2L,G2UL,V2L} DMA Controller > > > +title: Renesas RZ/{A1L,G2L,G2UL,V2L} DMA Controller > > I'd vote for your suggestion. Biju? This list is going to grow like RZ/A1, RZ/A2, RZ/G2L, RZ/G2LC, RZ/G2UL, RZ/V2L, RZ/Five, RZ/G3 devices, RZ/V2H and future generation SoCs. So maybe some thing generic should fit here. On RZ family, majority of devices, except RZ/G1 and RZ/G2{H,M,N,E} uses this DMA. Maybe we can mention this as "RZ DMA controller" and on commit message mention about "RZ/G1 and RZ/G2{H,M,N,E} devices". Cheers, Biju ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-10-01 7:44 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-09-30 14:59 [PATCH 0/3] dmaengine: sh: rz-dmac: add r7s72100 support Wolfram Sang 2024-09-30 14:59 ` [PATCH 2/3] dt-bindings: dma: rz-dmac: Document RZ/A1L SoC Wolfram Sang 2024-09-30 15:18 ` Geert Uytterhoeven 2024-09-30 19:26 ` Wolfram Sang 2024-10-01 7:44 ` Biju Das
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).