devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>,
	 Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Rishi Gupta <gupt21@gmail.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	 Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	 Javier Carrasco <javier.carrasco.cruz@gmail.com>
Subject: [PATCH v3 1/9] iio: light: veml6030: add set up delay after any power on sequence
Date: Tue, 01 Oct 2024 22:21:14 +0200	[thread overview]
Message-ID: <20241001-veml6035-v3-1-d789f6ff147c@gmail.com> (raw)
In-Reply-To: <20241001-veml6035-v3-0-d789f6ff147c@gmail.com>

The veml6030 requires a delay of 4 ms after activating the sensor. That
is done correctly during the hw initialization, but it's missing after
resuming.

Move the delay to the power on function to make sure that it is always
observerd. When at it, use fsleep() instead of usleep_range() as such a
narrow range is not required.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 drivers/iio/light/veml6030.c | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/drivers/iio/light/veml6030.c b/drivers/iio/light/veml6030.c
index 4c436c5e0787..94e38a983cf3 100644
--- a/drivers/iio/light/veml6030.c
+++ b/drivers/iio/light/veml6030.c
@@ -144,8 +144,17 @@ static const struct attribute_group veml6030_event_attr_group = {
 
 static int veml6030_als_pwr_on(struct veml6030_data *data)
 {
-	return regmap_clear_bits(data->regmap, VEML6030_REG_ALS_CONF,
-				 VEML6030_ALS_SD);
+	int ret;
+
+	ret = regmap_clear_bits(data->regmap, VEML6030_REG_ALS_CONF,
+				VEML6030_ALS_SD);
+	if (ret)
+		return ret;
+
+	/* Wait 4 ms to let processor & oscillator start correctly */
+	fsleep(4000);
+
+	return 0;
 }
 
 static int veml6030_als_shut_down(struct veml6030_data *data)
@@ -767,9 +776,6 @@ static int veml6030_hw_init(struct iio_dev *indio_dev)
 		return ret;
 	}
 
-	/* Wait 4 ms to let processor & oscillator start correctly */
-	usleep_range(4000, 4002);
-
 	/* Clear stale interrupt status bits if any during start */
 	ret = regmap_read(data->regmap, VEML6030_REG_ALS_INT, &val);
 	if (ret < 0) {

-- 
2.43.0


  reply	other threads:[~2024-10-01 20:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-01 20:21 [PATCH v3 0/9] iio: light: veml6030: fix issues and add support for veml6035 Javier Carrasco
2024-10-01 20:21 ` Javier Carrasco [this message]
2024-10-01 20:21 ` [PATCH v3 2/9] iio: light: veml6030: use dev_err_probe() Javier Carrasco
2024-10-01 20:21 ` [PATCH v3 3/9] dt-bindings: iio: light: veml6030: add vdd-supply property Javier Carrasco
2024-10-01 20:21 ` [PATCH v3 4/9] iio: light: veml6030: add support for a regulator Javier Carrasco
2024-10-01 20:21 ` [PATCH v3 5/9] iio: light: veml6030: use read_avail() for available attributes Javier Carrasco
2024-10-01 20:21 ` [PATCH v3 6/9] iio: light: veml6030: drop processed info for white channel Javier Carrasco
2024-10-01 20:21 ` [PATCH v3 7/9] iio: light: veml6030: power off device in probe error paths Javier Carrasco
2024-10-01 20:21 ` [PATCH v3 8/9] dt-bindings: iio: light: veml6030: add veml6035 Javier Carrasco
2024-10-01 20:21 ` [PATCH v3 9/9] iio: light: veml6030: add support for veml6035 Javier Carrasco
2024-10-06 14:10 ` [PATCH v3 0/9] iio: light: veml6030: fix issues and " Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241001-veml6035-v3-1-d789f6ff147c@gmail.com \
    --to=javier.carrasco.cruz@gmail.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gupt21@gmail.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).