From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A03CC192B79 for ; Tue, 1 Oct 2024 08:51:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727772673; cv=none; b=LqmV+nZ9D3o8bfO1nmgUUIrY6wSkglHNaKAAzwnPUuJOHs7cp3YuGm6FRumm4hrCRrUK9Y53B/72nR4A70lXFG0QbgPGndrT71mydyWwHvknGunL+40mtv8oWZOOg8gUJZ+8tOk/ceYeu1aW44hKFv1dsTVJlM0mDS2nwqhu068= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727772673; c=relaxed/simple; bh=rvq0jjtSeXp6memC+hL47Wgc3u62FSCpJtOGWn6ptDg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mSRRDHKXLYltc3Ccr7R4OONqQzLY/sFjg+7FKpVXxkD69exndBoRqIGQijvSYqtJbhV4XbwuG/NtgzNJT2cPMVYFcTGze7DTal7wip4heW3V4E5yub4Pgr/v0jpZmgQ3NIgZPTHGrc7P7qUwMfZDO1ud5VCaf5a/IucIrdH6p8A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=J2tOZD6/; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="J2tOZD6/" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-71dbdb7afe7so255640b3a.0 for ; Tue, 01 Oct 2024 01:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727772671; x=1728377471; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=T33uUeB7DNOOLKHqcQQSNjPbvyI7kdL3R1vLdSkp1S0=; b=J2tOZD6/NHWwqbYxZ0MzAzhGv/flSDro1qgJEvJbkRtSfZ/jn99bOV805biPCD1iY+ joqoI21pEVMDOuBGBi8H3V0FrGx2ptbTXIgSu0GaBeUgM8q3tMynmDZA46xUsldc6N8L abKDRCLTmzlUlIMxXPMeuR/HXBKIEXmJrHGRQT6I/d9rd1CD2Ce//IxCLG6dBBslV4yB 2RlezwkTMuE08BYsOr2T/PE1NBP1avA80dWpUOkpskshlkk69vGYmnl949+zZOjeGbFh IEzt+kc14F8aRAX9LcTfy9aaenGrycjRwnOrkf/6gjCNlv8XGl1YdWhO7ByJpOPvXyRd OXUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727772671; x=1728377471; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T33uUeB7DNOOLKHqcQQSNjPbvyI7kdL3R1vLdSkp1S0=; b=K6sM/fQfdNxWS1b/gkNAb1dzA8kYTXr3KuZAanZi7X4zIWShV4luHSlhJtAeJ1te00 qHvd/8uEMekv810z1yfoGnBo21LNiV9yHNvVS7L1wLhz/fTs0N3VsWZrX4gOkVyzBZlh 9qI8vwkpoufJ1ztERbZQpLIt+cPqGbc6wn7fLnsTQXTqIUo9qX7OUXGS/jka0Q5deZlk pvrFsINP1l9o2Rjqydrh3tIDu22X+iQDrf24D5EUZ5xQKo72LbQJRilt9aXAnuTGdyHc VveN+neDMiq/BoAXZbJ1QjZ0fzwj6KxaxzrtWsaQNsTv6+7MbqIzo3wTyqjlE3zB9UZ0 T70g== X-Forwarded-Encrypted: i=1; AJvYcCWlvOC9OydVZ+0C4BWLJcYeoxw4D9yS7AKYay0rfX3l9dD60P0kLZQMK+2nKLHQZWKKJROWTpKAhNS6@vger.kernel.org X-Gm-Message-State: AOJu0YwabWBSGxQLe5TVDzjn9kHySIXfae1axsnA/6I5iip4SHJt3v7G kGY36eQocE8gV3YIvF9xGTcAorbGaTUri9yiKGX4LhCja4SEchg5nZMSJrwHAg== X-Google-Smtp-Source: AGHT+IHmuCbCebubZdr7M8xU2lElWO48YfR8hemV4Nj08qcFiBJIN9/yuxY2PqUtwZjWMj9SXKl//g== X-Received: by 2002:a05:6a00:b50:b0:714:160e:8f5f with SMTP id d2e1a72fcca58-71b25f39a66mr21477216b3a.11.1727772670928; Tue, 01 Oct 2024 01:51:10 -0700 (PDT) Received: from thinkpad ([36.255.17.150]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b264ba53esm7551388b3a.56.2024.10.01.01.51.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 01:51:10 -0700 (PDT) Date: Tue, 1 Oct 2024 14:21:05 +0530 From: Manivannan Sadhasivam To: Dmitry Baryshkov Cc: Bjorn Andersson , Sibi Sankar , konradybcio@kernel.org, krzk+dt@kernel.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org, abel.vesa@linaro.org, srinivas.kandagatla@linaro.org Subject: Re: [PATCH 2/2] arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows Message-ID: <20241001085105.iglzp3art5ysli2d@thinkpad> References: <20240911073337.90577-1-quic_sibis@quicinc.com> <20240911073337.90577-3-quic_sibis@quicinc.com> <1BBC34CC-92D9-4F6E-8DFA-1F2DA36D545A@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1BBC34CC-92D9-4F6E-8DFA-1F2DA36D545A@linaro.org> On Tue, Oct 01, 2024 at 09:56:30AM +0300, Dmitry Baryshkov wrote: > On October 1, 2024 5:42:35 AM GMT+03:00, Bjorn Andersson wrote: > >On Wed, Sep 11, 2024 at 10:55:05AM GMT, Dmitry Baryshkov wrote: > >> On Wed, Sep 11, 2024 at 01:03:37PM GMT, Sibi Sankar wrote: > >[..] > >> > diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts > >[..] > >> > + > >> > +&pcie5 { > >> > + perst-gpios = <&tlmm 149 GPIO_ACTIVE_LOW>; > >> > + wake-gpios = <&tlmm 151 GPIO_ACTIVE_LOW>; > >> > + > >> > + vddpe-3v3-supply = <&vreg_wwan>; > >> > >> Please use pwrseq instead. > >> > > > >What benefit is there to wrap a single 3.3V regulator in pwrseq driver? > > First of all, is it really just a 3.3V? Second, is it actually powering up the host controller (as expressed in the device tree? Is it a power supply to the slot (in this case, I think, it should be expressed differently)? Or is it a power supply to the card itself? > Yeah, we should get into the details here. We were not paying attention till now, but with the advent of pwrseq, we should describe the power supply properly in DT. Here I believe the supply is to the PCIe Mini Card connector where a modem is connected. In that case, 3.3v supply should be connected to 3.3Vaux of the connector and we should have a generic pwrseq driver for the mini cards. Sibi, please verify the above in schematics. - Mani -- மணிவண்ணன் சதாசிவம்