devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fei Shao <fshao@chromium.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: Fei Shao <fshao@chromium.org>, Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Rob Herring <robh@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: [PATCH v2 7/8] arm64: dts: mediatek: mt8188: Move vdec1 power domain under vdec0
Date: Tue,  1 Oct 2024 19:27:25 +0800	[thread overview]
Message-ID: <20241001113052.3124869-8-fshao@chromium.org> (raw)
In-Reply-To: <20241001113052.3124869-1-fshao@chromium.org>

The MT8188 video decoder pipeline has two hardware IP blocks: LAT and
Core, which are powered by vdec0 and vdec1 power domains, respectively.

The hardware design includes a dependency between the vdec0 and vdec1
power domains to ensure that Core is powered down before LAT. Without
correctly describing this dependency in DT, the system will fail to
suspend.

As a comparable reference, MT8192 also uses the LAT + Core decoding
pipeline, and it has the correct power domain dependency defined in DT.

Update vdec1 as a sub-domain of vdec0 in MT8188 DT to reflect the
hardware design. Also, use more specific clock names for both power
domains.

Signed-off-by: Fei Shao <fshao@chromium.org>
---

Changes in v2:
Revise commit message.

 arch/arm64/boot/dts/mediatek/mt8188.dtsi | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
index 790315c1bdb3..ca50ed20fca0 100644
--- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
@@ -1062,20 +1062,22 @@ power-domain@MT8188_POWER_DOMAIN_VPPSYS1 {
 							#power-domain-cells = <0>;
 						};
 
-						power-domain@MT8188_POWER_DOMAIN_VDEC1 {
-							reg = <MT8188_POWER_DOMAIN_VDEC1>;
-							clocks = <&vdecsys CLK_VDEC2_LARB1>;
-							clock-names = "ss-vdec";
-							mediatek,infracfg = <&infracfg_ao>;
-							#power-domain-cells = <0>;
-						};
-
 						power-domain@MT8188_POWER_DOMAIN_VDEC0 {
 							reg = <MT8188_POWER_DOMAIN_VDEC0>;
 							clocks = <&vdecsys_soc CLK_VDEC1_SOC_LARB1>;
-							clock-names = "ss-vdec";
+							clock-names = "ss-vdec1-soc-l1";
 							mediatek,infracfg = <&infracfg_ao>;
-							#power-domain-cells = <0>;
+							#address-cells = <1>;
+							#size-cells = <0>;
+							#power-domain-cells = <1>;
+
+							power-domain@MT8188_POWER_DOMAIN_VDEC1 {
+								reg = <MT8188_POWER_DOMAIN_VDEC1>;
+								clocks = <&vdecsys CLK_VDEC2_LARB1>;
+								clock-names = "ss-vdec2-l1";
+								mediatek,infracfg = <&infracfg_ao>;
+								#power-domain-cells = <0>;
+							};
 						};
 
 						cam_vcore: power-domain@MT8188_POWER_DOMAIN_CAM_VCORE {
-- 
2.46.1.824.gd892dcdcdd-goog


  parent reply	other threads:[~2024-10-01 11:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-01 11:27 [PATCH v2 0/8] MT8188 DT and binding fixes Fei Shao
2024-10-01 11:27 ` [PATCH v2 1/8] dt-bindings: power: mediatek: Add another nested power-domain layer Fei Shao
2024-12-02 16:07   ` Ulf Hansson
2024-10-01 11:27 ` [PATCH v2 2/8] dt-bindings: PCI: mediatek-gen3: Allow exact number of clocks only Fei Shao
2024-10-01 11:27 ` [PATCH v2 3/8] dt-bindings: media: mediatek,jpeg: Relax IOMMU max item count Fei Shao
2024-10-02  6:16   ` Krzysztof Kozlowski
2024-10-02 11:57     ` Fei Shao
2024-10-02 13:12     ` Matthias Brugger
2024-10-02 14:00       ` Krzysztof Kozlowski
2024-10-02 13:59   ` Krzysztof Kozlowski
2024-10-01 11:27 ` [PATCH v2 4/8] dt-bindings: media: mediatek,vcodec: Revise description Fei Shao
2024-10-02  6:16   ` Krzysztof Kozlowski
2024-10-01 11:27 ` [PATCH v2 5/8] arm64: dts: mediatek: mt8188: Add missing dma-ranges to soc node Fei Shao
2024-10-01 11:27 ` [PATCH v2 6/8] arm64: dts: mediatek: mt8188: Update vppsys node names to syscon Fei Shao
2024-10-01 11:27 ` Fei Shao [this message]
2024-10-01 11:27 ` [PATCH v2 8/8] arm64: dts: mediatek: mt8188: Move SPI NOR *-cells properties Fei Shao
2024-10-02  9:33 ` (subset) [PATCH v2 0/8] MT8188 DT and binding fixes AngeloGioacchino Del Regno
2024-12-02  4:24 ` Chen-Yu Tsai
2024-12-02 16:07   ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241001113052.3124869-8-fshao@chromium.org \
    --to=fshao@chromium.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).